Stream: t-compiler/shrinkmem-sprint

Topic: mir_opt_level changes


view this post on Zulip Santiago Pastorino (Mar 04 2021 at 14:24):

one thing that needs discussion now is which optimizations from level 3 do we want to make it level 2 (on by default on "release" mode)

view this post on Zulip Santiago Pastorino (Mar 04 2021 at 14:25):

I meant, we would be placing a PR and running perf on them

view this post on Zulip Santiago Pastorino (Mar 04 2021 at 14:25):

@oli told me to ask @tm about good first candidates

view this post on Zulip Santiago Pastorino (Mar 04 2021 at 14:25):

oli also told me that ? opt may be a good candidate

view this post on Zulip bjorn3 (Mar 04 2021 at 15:42):

As far as I know -Zmir-opt-level=1 is used for all optimization levels. At least MIR inlining is not enabled when optimizations are enabled, yet it only requires -Zmir-opt-level=2.

view this post on Zulip tm (Mar 04 2021 at 15:44):

In context of changes from #82736.

view this post on Zulip Santiago Pastorino (Mar 04 2021 at 15:45):

right @tm, sorry for not being clear that what I was saying is once that PR lands :)

view this post on Zulip Santiago Pastorino (Mar 04 2021 at 15:46):

so the idea now is that the optimizations we have on level 3 on that PR, we would like to provide followup PRs that move each one to level 2 and run perf on them

view this post on Zulip Santiago Pastorino (Mar 04 2021 at 15:46):

my question for @tm was, which optimizations are the ones you consider more important to try first?

view this post on Zulip tm (Mar 04 2021 at 16:15):

After looking a bit, I don't think I will have any concrete suggestions.

view this post on Zulip Santiago Pastorino (Mar 08 2021 at 15:27):

the "setup" changes have landed

view this post on Zulip Santiago Pastorino (Mar 08 2021 at 15:28):

opened #82903, #82904, #82905, #82906 to check on each opt if there are improvements so we can move to level 2

view this post on Zulip Santiago Pastorino (Mar 08 2021 at 15:29):

the only in that is currently in level 3 that I didn't touch is the inliner because @oli told me that @Wesley Wiser was on it

view this post on Zulip Wesley Wiser (Mar 08 2021 at 15:30):

Yeah, #82280 seems to be basically the same idea in practice.


Last updated: Oct 21 2021 at 20:47 UTC