Stream: rustdoc

Topic: tidy


view this post on Zulip GuillaumeGomez (Nov 26 2020 at 09:53):

@Joshua Nelson Btw: I installed tidy and I have a huge issue with the output: it's super cool because it displays exactly the diff between the two HTMLs, but then it displays ALL the HTML (which is a bit problematic). Would it be possible to only keep the (small) diffs?

view this post on Zulip Joshua Nelson (Nov 26 2020 at 13:38):

@GuillaumeGomez it should only be showing the diff now - can you post a screenshot?

view this post on Zulip GuillaumeGomez (Nov 26 2020 at 13:42):

Not really since it litterally shows ALL the HTML

view this post on Zulip GuillaumeGomez (Nov 26 2020 at 13:42):

so my terminal is completely full

view this post on Zulip GuillaumeGomez (Nov 26 2020 at 13:42):

a screenshot wouldn't help much haha

view this post on Zulip Joshua Nelson (Nov 26 2020 at 13:52):

I'm really confused :/ which test is this for?

view this post on Zulip GuillaumeGomez (Nov 26 2020 at 13:56):

./x.py test src/test/rustdoc --stage 1 --jobs 2

view this post on Zulip Joshua Nelson (Nov 26 2020 at 13:56):

right, yes, but which tests are failing?

view this post on Zulip GuillaumeGomez (Nov 26 2020 at 13:57):

Nothing is failing, I was testing out the tidy output by making on purpose a failing change haha

view this post on Zulip GuillaumeGomez (Nov 26 2020 at 13:57):

and even though the specific diff lines are great, the rest is just waaaaaaaaaaaaaaaay too much

view this post on Zulip Joshua Nelson (Nov 26 2020 at 13:57):

I am still not clear what changes you're asking for.

view this post on Zulip Joshua Nelson (Nov 26 2020 at 13:58):

can you post what it looks like now, and maybe a mockup of what you'd like it to be?

view this post on Zulip GuillaumeGomez (Nov 26 2020 at 13:59):

I'll create the file by redirecting output then

view this post on Zulip GuillaumeGomez (Nov 26 2020 at 14:00):

but it'll be huge

view this post on Zulip Joshua Nelson (Nov 26 2020 at 14:00):

sure, that's fine - thanks!

view this post on Zulip Joshua Nelson (Nov 26 2020 at 14:30):

@GuillaumeGomez ok I found the issue - there was a change in ayu.css and it wasn't formatted by tidy so it showed the whole file

view this post on Zulip Joshua Nelson (Nov 26 2020 at 14:31):

I think the best solution is to ignore .css and .js files in the diff, since they're never autogenerated

view this post on Zulip Joshua Nelson (Nov 26 2020 at 14:32):

in the short term I think it will be fixed with rustup default nightly, since that will compare to a version of rustdoc that has the same CSS output

view this post on Zulip GuillaumeGomez (Nov 26 2020 at 14:33):

Still remain highly not efficient. I was afraid of such issues, but I see that as the first step before big improvements. For the time being, I'll just not use tidy I guess

view this post on Zulip Joshua Nelson (Nov 26 2020 at 14:34):

getting rid of tidy won't help, it will still generate a diff

view this post on Zulip Joshua Nelson (Nov 26 2020 at 14:34):

I'll make a PR ignoring .css files

view this post on Zulip GuillaumeGomez (Nov 26 2020 at 14:34):

Well, at least I won't have the whole HTML in my terminal haha

view this post on Zulip Joshua Nelson (Nov 26 2020 at 14:34):

no, you still will :P

view this post on Zulip Joshua Nelson (Nov 26 2020 at 14:35):

unless you don't have a local rustdoc at all

view this post on Zulip Joshua Nelson (Nov 26 2020 at 14:36):

err actually that's waiting on https://github.com/rust-lang/rust/pull/79370

view this post on Zulip Noah Lev (Nov 26 2020 at 20:35):

I installed tidy

What does that mean? Do you meant tidy as in ./x.py test tidy? I'm curious to see what this tool is :)

view this post on Zulip GuillaumeGomez (Nov 26 2020 at 20:35):

No, I mean the tidy binary haha

view this post on Zulip GuillaumeGomez (Nov 26 2020 at 20:36):

@Joshua Nelson made a PR recently to improve the output of errors when running x.py test src/test/rustdoc

view this post on Zulip GuillaumeGomez (Nov 26 2020 at 20:36):

and that improvement uses the tidy binary

view this post on Zulip GuillaumeGomez (Nov 26 2020 at 20:36):

so not linked ;)

view this post on Zulip Noah Lev (Nov 26 2020 at 21:27):

Ah, were you referring to this project?

view this post on Zulip Joshua Nelson (Nov 26 2020 at 23:42):

Yes, that's it.

view this post on Zulip Joshua Nelson (Dec 12 2020 at 13:40):

fyi @GuillaumeGomez https://github.com/rust-lang/rust/pull/79370 has been waiting on review a while

view this post on Zulip GuillaumeGomez (Dec 12 2020 at 14:18):

Arf! I thought it was waiting on Mark XD

view this post on Zulip GuillaumeGomez (Dec 12 2020 at 14:18):

taking a look then!


Last updated: Oct 11 2021 at 22:34 UTC