@Joshua Nelson Btw: I installed tidy and I have a huge issue with the output: it's super cool because it displays exactly the diff between the two HTMLs, but then it displays ALL the HTML (which is a bit problematic). Would it be possible to only keep the (small) diffs?
@GuillaumeGomez it should only be showing the diff now - can you post a screenshot?
Not really since it litterally shows ALL the HTML
so my terminal is completely full
a screenshot wouldn't help much haha
I'm really confused :/ which test is this for?
./x.py test src/test/rustdoc --stage 1 --jobs 2
right, yes, but which tests are failing?
Nothing is failing, I was testing out the tidy output by making on purpose a failing change haha
and even though the specific diff lines are great, the rest is just waaaaaaaaaaaaaaaay too much
I am still not clear what changes you're asking for.
can you post what it looks like now, and maybe a mockup of what you'd like it to be?
I'll create the file by redirecting output then
but it'll be huge
sure, that's fine - thanks!
@GuillaumeGomez ok I found the issue - there was a change in
ayu.css and it wasn't formatted by tidy so it showed the whole file
I think the best solution is to ignore .css and .js files in the diff, since they're never autogenerated
in the short term I think it will be fixed with
rustup default nightly, since that will compare to a version of rustdoc that has the same CSS output
Still remain highly not efficient. I was afraid of such issues, but I see that as the first step before big improvements. For the time being, I'll just not use tidy I guess
getting rid of tidy won't help, it will still generate a diff
I'll make a PR ignoring .css files
Well, at least I won't have the whole HTML in my terminal haha
no, you still will :P
unless you don't have a local
rustdoc at all
err actually that's waiting on https://github.com/rust-lang/rust/pull/79370
I installed tidy
What does that mean? Do you meant tidy as in
./x.py test tidy? I'm curious to see what this tool is :)
No, I mean the
tidy binary haha
@Joshua Nelson made a PR recently to improve the output of errors when running
x.py test src/test/rustdoc
and that improvement uses the
so not linked ;)
Ah, were you referring to this project?
Yes, that's it.
fyi @GuillaumeGomez https://github.com/rust-lang/rust/pull/79370 has been waiting on review a while
Arf! I thought it was waiting on Mark XD
taking a look then!
Last updated: Oct 11 2021 at 22:34 UTC