Stream: rustdoc

Topic: rustdoc/issue-80893.rs test


view this post on Zulip Mara (Jan 20 2021 at 23:56):

Hi rustdoc team,

The rustdoc/issue-80893.rs test has been failing randomly quite often lately, on unrelated PRs. Not sure what is going wrong, the only output is status: signal: 13 aka SIGPIPE. Example of such a failure: https://github.com/rust-lang-ci/rust/runs/1738335854

Not sure what the problem is, but it's always on this specific test.

The only thing this test does, is checking that --test-builder true works. Apparently that causes some race condition with pipes when used in the test suite.

view this post on Zulip Joshua Nelson (Jan 21 2021 at 00:05):

@Mara https://github.com/rust-lang/rust/pull/81197

view this post on Zulip Joshua Nelson (Jan 21 2021 at 00:05):

if you want to approve that works for me

view this post on Zulip Mara (Jan 21 2021 at 00:08):

Ah cool, thanks for fixing this!

view this post on Zulip Mara (Jan 21 2021 at 00:08):

I'm probably not the right person to review this though.

view this post on Zulip Joshua Nelson (Jan 21 2021 at 00:16):

@simulacrum do you have a second to review? this is causing other spurious failures

view this post on Zulip Joshua Nelson (Jan 21 2021 at 00:16):

or if you have a suggestion for another reviewer, that works too

view this post on Zulip simulacrum (Jan 21 2021 at 00:16):

Not today, likely not till this weekend at earliest. r=me on just dropping the test for now

view this post on Zulip Joshua Nelson (Jan 21 2021 at 00:17):

hmm, ok, I'll make a PR for that

view this post on Zulip Joshua Nelson (Jan 21 2021 at 00:20):

https://github.com/rust-lang/rust/pull/81231


Last updated: Oct 11 2021 at 22:34 UTC