Stream: rustdoc

Topic: help stripping shadowed glob imports


view this post on Zulip Ali MJ Al-Nasrawy (Sep 07 2021 at 13:31):

Hi, I claimed #70380 as my first issue and I'd like to have some input on my suggested solution.

The problem is here in this code, which adds glob imported items unconditionally to the module

I would fix this by adding shadowable flag to doctree::Module items and then have a second pass here to strinp shadowed symbols.

Would that be ok? Any other suggestion?

view this post on Zulip Joshua Nelson (Sep 07 2021 at 14:03):

I don't have time to look into it right now, but I suggest looking at how https://github.com/rust-lang/rust/pull/83872 did it

view this post on Zulip Joshua Nelson (Sep 07 2021 at 14:03):

Also, why would you need a second pass? Why not just strip the item immediately?


Last updated: Oct 11 2021 at 22:34 UTC