Stream: rustdoc

Topic: error-index rendering as all-boldface?


view this post on Zulip Taylor Yu [they/she] (Jun 20 2021 at 23:01):

not sure if this belongs here or in #t-infra? https://doc.rust-lang.org/error-index.html is rendering as mostly all-boldface for body text (at least for me). digging around in Safari's web inspector, i discovered that https://doc.rust-lang.org/error-index.html and https://doc.rust-lang.org/stable/error-index.html (which renders without all-bold body text) are getting different sets of 404 errors for the Source*.woff fonts. https://doc.rust-lang.org/error-index.html is managing to load https://doc.rust-lang.org/SourceSerifPro-Bold.ttf.woff and https://doc.rust-lang.org/SourceSerifPro-It.ttf.woff but not https://doc.rust-lang.org/SourceCodePro-Regular.woff or https://doc.rust-lang.org/SourceSerifPro-Regular.ttf.woff

https://doc.rust-lang.org/stable/error-index.html is getting 404 errors for all of the Source*.woff fonts, so it seems like it renders "correctly" by accident.

view this post on Zulip GuillaumeGomez (Jun 20 2021 at 23:07):

This page is kinda handled on its own and weirdly: it uses rustdoc for generation, but uses its own style files for some reasons... I sent a PR to make it use rustdoc files directly but it got rejected. Might be worth sending another one though?

view this post on Zulip Eric Huss (Jun 21 2021 at 01:16):

Posted https://github.com/rust-lang/rust/pull/86503 to update the fonts.

view this post on Zulip Joshua Nelson (Jun 21 2021 at 01:25):

GuillaumeGomez said:

This page is kinda handled on its own and weirdly: it uses rustdoc for generation, but uses its own style files for some reasons... I sent a PR to make it use rustdoc files directly but it got rejected. Might be worth sending another one though?

which PR was that? I don't remember it and I can't find it in github search

view this post on Zulip GuillaumeGomez (Jun 21 2021 at 13:59):

It's an "old" one (last year or even before?). It was reviewed by the infra iirc.


Last updated: Oct 11 2021 at 22:34 UTC