Stream: rustdoc

Topic: automatic pings on changes to rustdoc-json-types


view this post on Zulip Joshua Nelson (Apr 23 2021 at 19:50):

hey @CraftSpider @Nixon Enraght-Moony I'm about to add a warning when someone changes rustdoc-json-types:

        "src/rustdoc-json-types": {
          "message": "rustdoc-json-types is a **public** (although nightly-only) API. Consider changing `src/librustdoc/json/conversions.rs` instead.",

are one of you interested in getting pinged on those changes to look at the new API? no problem if not, I can put myself as the reviewer instead

view this post on Zulip Joshua Nelson (Apr 23 2021 at 19:51):

this doesn't add anything to the whole /json folder because it would be way too noisy

view this post on Zulip CraftSpider (Apr 23 2021 at 23:20):

I'd be interested in being pinged for it

view this post on Zulip Joshua Nelson (Apr 23 2021 at 23:25):

awesome! I'll put you down :) you don't have to be on the hook for reviewing, it's just in case someone not from rustdoc gets assigned

view this post on Zulip Joshua Nelson (Apr 23 2021 at 23:30):

https://github.com/rust-lang/highfive/pull/331

view this post on Zulip Nixon Enraght-Moony (Apr 23 2021 at 23:54):

Do we have a list of people using the JSON. I know of https://github.com/Maan2003/druid-rustdoc-frontend, and @HeroicKatora has something, I think.

view this post on Zulip Joshua Nelson (Apr 24 2021 at 00:00):

that's everyone I know of


Last updated: Oct 21 2021 at 21:32 UTC