Stream: rustdoc

Topic: Trait implementation self-links


view this post on Zulip Léo Lanteri Thauvin (Jan 23 2021 at 15:57):

#32558 changed the rendering of traits "implementors" section to not self-link. However, in the "implementation on foreign traits" section, implementations do self-link. Should those be united? If so, what is the preferred behavior?

view this post on Zulip Léo Lanteri Thauvin (Jan 23 2021 at 15:58):

Maybe the link isn't important, but we should keep the color?

view this post on Zulip Joshua Nelson (Jan 23 2021 at 16:15):

I think it would be nice to, rather than special casing traits, detect whenever a link points to the current page without an anchor and strip it if so

view this post on Zulip Joshua Nelson (Jan 23 2021 at 16:15):

Keeping the color sounds reasonable

view this post on Zulip Noah Lev (Jan 23 2021 at 20:11):

Joshua Nelson said:

I think it would be nice to, rather than special casing traits, detect whenever a link points to the current page without an anchor and strip it if so

I feel like that would be hard to implement without much benefit though.

view this post on Zulip Joshua Nelson (Jan 23 2021 at 20:18):

well, then why do it for traits?

view this post on Zulip Joshua Nelson (Jan 23 2021 at 20:18):

I don't see much point in only doing this for traits and nothing else

view this post on Zulip Léo Lanteri Thauvin (Jan 23 2021 at 20:19):

Joshua Nelson said:

I don't see much point in only doing this for traits and nothing else

Which is why I'd personally prefer to revert #32558 :big_smile:

view this post on Zulip Joshua Nelson (Jan 23 2021 at 20:21):

I would be fine with that

view this post on Zulip Noah Lev (Jan 23 2021 at 21:51):

Same here I think.

view this post on Zulip Léo Lanteri Thauvin (Jan 23 2021 at 21:57):

Would that need a FCP?

view this post on Zulip Léo Lanteri Thauvin (Jan 23 2021 at 21:58):

I'll just open a PR for now

view this post on Zulip Léo Lanteri Thauvin (Jan 23 2021 at 21:58):

Do what you want with it :D

view this post on Zulip Noah Lev (Jan 23 2021 at 22:18):

Not sure if it would need an FCP, but should be a pretty small change :)

view this post on Zulip Léo Lanteri Thauvin (Jan 23 2021 at 22:55):

Opened #81313


Last updated: Oct 11 2021 at 22:34 UTC