Stream: rustdoc

Topic: Rustdoc performance blog post


view this post on Zulip Joshua Nelson (Jan 14 2021 at 15:55):

Hello all! @GuillaumeGomez and I wrote up a post about the performance improvements in rustdoc over the last few months. I'd be interested in your feedback on the post :) My main concern is it's too long, but I'm not sure how to trim it down without losing information.

https://hackmd.io/K9fQV8uqTxG7KUnO4iZmxg

view this post on Zulip GuillaumeGomez (Jan 14 2021 at 15:56):

(I think the amount of information is ok since it's a technical blog post but some wording improvement could be needed :) )

view this post on Zulip Poliorcetics (Jan 15 2021 at 02:06):

Once that was done, I was able to get rid of large parts

Who is ‘I’ here ? Both GuillaumeGomez and Joshua Nelson are cited in the third person in the post.

Same problem in other parts of the posts

view this post on Zulip Poliorcetics (Jan 15 2021 at 02:06):

Else it’s great

view this post on Zulip Poliorcetics (Jan 15 2021 at 02:07):

(How do I mention people without highlighting them on mobile ?)

view this post on Zulip Joshua Nelson (Jan 15 2021 at 02:09):

Poliorcetics said:

(How do I mention people without highlighting them on mobile ?)

probably you can't, mobile zulip is very broken :sweat_smile:

view this post on Zulip Joshua Nelson (Jan 15 2021 at 02:10):

Poliorcetics said:

Once that was done, I was able to get rid of large parts

Who is ‘I’ here ? Both GuillaumeGomez and Joshua Nelson are cited in the third person in the post.

Same problem in other parts of the posts

I think I'll just change that to 'we', I and Guillaume both contributed

view this post on Zulip Joshua Nelson (Jan 15 2021 at 02:17):

cleaned up the wording a bit

view this post on Zulip GuillaumeGomez (Jan 15 2021 at 19:19):

cc @Manish Goregaokar

view this post on Zulip Manish Goregaokar (Jan 15 2021 at 19:29):

"too long" is fine for inside rust

view this post on Zulip Manish Goregaokar (Jan 15 2021 at 19:29):

I like this post, and yeah, change it to "we"

view this post on Zulip Manish Goregaokar (Jan 15 2021 at 19:30):

@Joshua Nelson we can mark you as the author of the post and you can start with we (The Rustdoc Team)

view this post on Zulip Joshua Nelson (Jan 15 2021 at 19:40):

it ended up being less focused on performance than I planned, but I think it gives a better idea of what's been going on in rustdoc

view this post on Zulip Joshua Nelson (Jan 15 2021 at 19:44):

opened https://github.com/rust-lang/blog.rust-lang.org/pull/760

view this post on Zulip Dániel Buga (Jan 15 2021 at 20:24):

So, the intra-doc link cache didn't make the cut with the what, 800% improvement for embedded crates? :stuck_out_tongue: Just kidding, nice post ^^

view this post on Zulip Joshua Nelson (Jan 15 2021 at 20:26):

oh yeah I should probably add that lol

view this post on Zulip Joshua Nelson (Jan 15 2021 at 20:26):

and not looking for blanket impls

view this post on Zulip Joshua Nelson (Jan 15 2021 at 20:26):

@Dániel Buga do you want to write those up? :smile:

view this post on Zulip Dániel Buga (Jan 15 2021 at 20:27):

Nah, knowing my communication skills it's probably better if you do it :smile:

view this post on Zulip Joshua Nelson (Jan 15 2021 at 20:27):

ok, I probably won't get around to it until tomorrow then

view this post on Zulip Léo Lanteri Thauvin (Jan 16 2021 at 17:27):

Joshua Nelson said:

Poliorcetics said:

(How do I mention people without highlighting them on mobile ?)

probably you can't, mobile zulip is very broken :sweat_smile:

I usually add the _ manually, which works fine

view this post on Zulip Noah Lev (Jan 16 2021 at 19:58):

Is there a way to do it other than typing @_... on desktop?

view this post on Zulip Joshua Nelson (Jan 16 2021 at 21:52):

well on desktop it will auto-complete people's names even with @_

view this post on Zulip Noah Lev (Jan 17 2021 at 19:19):

Oh, I didn't realize that auto-complete didn't work for @_ on mobile. Thanks!

view this post on Zulip GuillaumeGomez (Jan 18 2021 at 20:49):

Any news on that btw? Is there anything else that needs to be done?

view this post on Zulip Joshua Nelson (Jan 18 2021 at 20:58):

camelid left a ton of comments I haven't had time to respond to

view this post on Zulip Noah Lev (Jan 18 2021 at 21:09):

Sorry about that :embarrassed:

Most of them are fine to be ignored.

view this post on Zulip Joshua Nelson (Jan 18 2021 at 21:13):

@Camelid btw I gave you push access if you want to fix the typos and such yourself

view this post on Zulip Tshepang Lekhonkhobe (Jan 22 2021 at 03:42):

first link on this section, [rustdoc] is pointing nowhere

view this post on Zulip Joshua Nelson (Jan 22 2021 at 03:44):

it's not meant to be a link, that's the name of the PR

view this post on Zulip Joshua Nelson (Jan 22 2021 at 03:44):

maybe we should just remove it

view this post on Zulip Noah Lev (Jan 22 2021 at 03:48):

Joshua Nelson said:

maybe we should just remove it

That seems like a good idea.


Last updated: Oct 11 2021 at 22:34 UTC