Stream: rustdoc

Topic: Is there an approved HTML parser?


view this post on Zulip Joshua Nelson (Jan 19 2021 at 07:36):

@simulacrum at some point I would like to add deadlinks to rustdoc (pending FCP, etc). Unfortunately, several of its dependencies have neither an MIT nor an Apache license: https://github.com/deadlinks/cargo-deadlinks/issues/105#issuecomment-762651349
Are BSD-3-Clause and MPL-2.0 ok? If not, is there an approved HTML parser I can use besides lol_html?

view this post on Zulip simulacrum (Jan 19 2021 at 11:31):

Licensing is not a question I can currently help with I'm afraid. Tidy has a list of exceptions, though.

view this post on Zulip Joshua Nelson (Jan 19 2021 at 14:34):

Hmm, ok. Is there someone better to ask? I don't want to put a ton of time into this if it's going to get tied up in licensing

view this post on Zulip simulacrum (Jan 19 2021 at 15:08):

You can email core@, but I would not expect a quick response right now. That's the right avenue though.

view this post on Zulip Joshua Nelson (Jan 19 2021 at 16:46):

oh it actually turns out that html5ever meets all the licenses

view this post on Zulip Joshua Nelson (Jan 19 2021 at 16:46):

so the simple fix for this is to just make the HTML parser swappable and use html5ever in rustdoc

view this post on Zulip GuillaumeGomez (Jan 19 2021 at 16:50):

Use kuchiki instead maybe

view this post on Zulip GuillaumeGomez (Jan 19 2021 at 16:51):

It makes the API a bit better (and I'm a maintainer in case of issue)

view this post on Zulip Joshua Nelson (Jan 19 2021 at 16:52):

@GuillaumeGomez that hits the same licensing issue

tidy error: invalid license `MPL-2.0` in `cssparser 0.27.2 (registry+https://github.com/rust-lang/crates.io-index)`
tidy error: invalid license `MPL-2.0` in `cssparser-macros 0.6.0 (registry+https://github.com/rust-lang/crates.io-index)`
tidy error: invalid license `MPL-2.0` in `dtoa-short 0.3.3 (registry+https://github.com/rust-lang/crates.io-index)`
tidy error: invalid license `MPL-2.0` in `selectors 0.22.0 (registry+https://github.com/rust-lang/crates.io-index)`
tidy error: invalid license `MPL-2.0` in `thin-slice 0.1.1 (registry+https://github.com/rust-lang/crates.io-index)`

view this post on Zulip GuillaumeGomez (Jan 19 2021 at 16:52):

kuchiki?

view this post on Zulip Joshua Nelson (Jan 19 2021 at 16:52):

yes

view this post on Zulip Joshua Nelson (Jan 19 2021 at 17:07):

sent an email to core

view this post on Zulip GuillaumeGomez (Jan 19 2021 at 17:17):

We can always change the license on kuchiki if needed

view this post on Zulip Joshua Nelson (Jan 19 2021 at 17:18):

kuchiki isn't the issue, it's the dependencies

view this post on Zulip Joshua Nelson (Jan 19 2021 at 17:18):

cssparser and friends

view this post on Zulip GuillaumeGomez (Jan 19 2021 at 19:03):

ah I see

view this post on Zulip GuillaumeGomez (Jan 19 2021 at 19:03):

servo people being "out", gonna be complicated

view this post on Zulip Noah Lev (Jan 19 2021 at 20:10):

Maybe ask on the Servo Zulip?

view this post on Zulip Joshua Nelson (Jan 19 2021 at 20:16):

I think it is unlikely they'll change the license, but I'll see what core says

view this post on Zulip Joshua Nelson (Jan 19 2021 at 20:16):

The issue is they'd need to get everyone who's ever contributed to agree

view this post on Zulip Joshua Nelson (Jan 19 2021 at 20:23):

(also I'd really prefer to use lol_html because it has better performance, but that's a long shot)


Last updated: Oct 21 2021 at 20:47 UTC