Stream: rustdoc

Topic: I cannot reproduce a bug in #82042


view this post on Zulip Takayuki Maeda (Feb 16 2021 at 04:53):

I'm working on #82042 and I cannot reproduce a bug this issue says in the doc I built locally. Then I compared doc.rust-lang.org with the doc and I found that they have a difference HTML source like the following.

In doc.rust-lang.org

https://rust-lang.zulipchat.com/user_uploads/4715/DiT1tH21rp71PjQLLGfgPw_w/スクリーンショット-2021-02-16-13.41.42.png

https://rust-lang.zulipchat.com/user_uploads/4715/U3C6e927ia8xnpe9TRWNIQkH/スクリーンショット-2021-02-16-13.38.13.png

In local doc

https://rust-lang.zulipchat.com/user_uploads/4715/fVZGiNqGuv8t757Zc4sF8RMX/スクリーンショット-2021-02-16-13.41.42.png

https://rust-lang.zulipchat.com/user_uploads/4715/F8Bi-QUAYQHD1FY_f8qHhtrD/スクリーンショット-2021-02-16-13.37.53.png

The order of span tags is different and I think this causes the bug. Does anyone know why this happens?

view this post on Zulip Joshua Nelson (Feb 16 2021 at 04:55):

are you sure the versions of rustdoc you're using are the same?

view this post on Zulip Joshua Nelson (Feb 16 2021 at 05:01):

also I tried this on rust-lang.org and I can't reproduce the bug either, I would say something to the issue author

view this post on Zulip Takayuki Maeda (Feb 16 2021 at 05:16):

Joshua Nelson said:

are you sure the versions of rustdoc you're using are the same?

I will check it.

Joshua Nelson said:

also I tried this on rust-lang.org and I can't reproduce the bug either, I would say something to the issue author

I can reproduce the bug in doc.rust-lang.org by following the steps in #82042.

view this post on Zulip Joshua Nelson (Feb 16 2021 at 05:16):

oh weird

view this post on Zulip Joshua Nelson (Feb 16 2021 at 05:16):

what browser are you using?

view this post on Zulip Takayuki Maeda (Feb 16 2021 at 05:17):

I'm using Google Chrome.

view this post on Zulip Joshua Nelson (Feb 16 2021 at 05:18):

I'm on firefox, maybe it matters?

view this post on Zulip Takayuki Maeda (Feb 16 2021 at 05:18):

I'm going to try this on other browsers.

view this post on Zulip Takayuki Maeda (Feb 16 2021 at 05:21):

I can't reproduce the bug on Safari.

view this post on Zulip Takayuki Maeda (Feb 16 2021 at 06:26):

I cannot reproduce the bug In https://doc.rust-lang.org/nightly/std on Google Chrome. And the order of span tags in nightly std doc is as I expected.

view this post on Zulip Takayuki Maeda (Feb 16 2021 at 06:32):

The following commit changed the order of span tags, so I can't reproduce the bug in nightly std doc.
https://github.com/rust-lang/rust/commit/74f26a1e620e2f9c7a53e3bc1d8907c525c1e9ad

view this post on Zulip Takayuki Maeda (Feb 16 2021 at 06:34):

As a result, I think the bug is specific to older versions of rustdoc.

view this post on Zulip Joshua Nelson (Feb 16 2021 at 06:43):

Ok, ping me tomorrow and I can close the issue. It could use a test ideally but I have no idea how to test it.

view this post on Zulip Takayuki Maeda (Feb 16 2021 at 06:45):

As mentioned above, I think the bug is specific to older versions of rustdoc and the kind of browsers doesn't have a direct relationship with it. @Joshua Nelson

view this post on Zulip Takayuki Maeda (Feb 20 2021 at 03:19):

@Joshua Nelson Could you close this issue?

view this post on Zulip Joshua Nelson (Feb 20 2021 at 18:19):

@Takayuki Maeda the author said they could reproduce in Chrome

view this post on Zulip Takayuki Maeda (Feb 20 2021 at 18:41):

@Joshua Nelson
Ok. As mentioned above, the easiest way to solve this bug is build https://doc.rust-lang.org/stable/std/ and other docs with newer version of rustdoc. Could you tell me how to do it properly?

view this post on Zulip Noah Lev (Feb 20 2021 at 23:42):

Once /stable/std is built, it doesn't change until the next version. So we just have to wait until the next release.

view this post on Zulip Noah Lev (Feb 20 2021 at 23:42):

(At least, that's my understanding.)

view this post on Zulip Noah Lev (Feb 21 2021 at 00:00):

Issue closed; OP confirmed that bug is fixed on beta and nightly.

view this post on Zulip Takayuki Maeda (Feb 21 2021 at 04:03):

@Camelid
Ohh I get it. Thank you for closing this issue!
Next time, I’ll make sure to ask if the author can reproduce bugs on other versions of rustdoc.


Last updated: Oct 11 2021 at 22:34 UTC