Stream: rustdoc

Topic: Browser support


view this post on Zulip Aru Sahni (Jan 04 2021 at 03:05):

I'm currently investigating some rendering issues with the sidebar nav that were noticed when tackling a docs.rs bug. While acquainting myself with the sidebar code, I've noticed additional parts of the markup that I feel could do with some modernization/cleanup. To better inform a plan of attack, what are rustdoc's targeted browsers?

view this post on Zulip Joshua Nelson (Jan 04 2021 at 03:07):

https://rust-lang.github.io/rfcs/1985-tiered-browser-support.html#supported-browsers

view this post on Zulip Joshua Nelson (Jan 04 2021 at 03:08):

but in practice rustdoc supports a lot more than those; @GuillaumeGomez is the one to ask

view this post on Zulip Aru Sahni (Jan 04 2021 at 03:08):

Thanks!

view this post on Zulip GuillaumeGomez (Jan 04 2021 at 09:15):

IE9 is the minimum supported browser (unofficially but still)

view this post on Zulip GuillaumeGomez (Jan 04 2021 at 09:15):

Most sidebar issues come from safari ios though

view this post on Zulip Aru Sahni (Jan 04 2021 at 22:49):

Ah, yeah, IE9 would do it :-\ (i.e., no flexbox) . For iOS Safari, are we solely targeting the latest Safari, or supporting a tail of those versions, too?

view this post on Zulip GuillaumeGomez (Jan 05 2021 at 09:34):

No idea how the updates are handled in safari. But some things officially supported aren't working. Like position: static.

view this post on Zulip Joshua Nelson (Jan 05 2021 at 13:13):

@GuillaumeGomez IE9 is a long way back ... Is there a reason you support back that far?

view this post on Zulip Joshua Nelson (Jan 05 2021 at 13:13):

(is that even tested? I'd expect it to break often otherwise)

view this post on Zulip GuillaumeGomez (Jan 05 2021 at 13:14):

Nothing on the front is tested. And iirc, it's "working"

view this post on Zulip GuillaumeGomez (Jan 05 2021 at 13:14):

at least it's readable XD

view this post on Zulip GuillaumeGomez (Jan 05 2021 at 13:15):

To be clear: I don't mind rising the minimum IE to 11, but the current issue is safari on iOS

view this post on Zulip GuillaumeGomez (Jan 05 2021 at 13:15):

and that one unfortunately, we can't drop it

view this post on Zulip Aru Sahni (Jan 05 2021 at 23:30):

@GuillaumeGomez position: static is the default positioning for an element. Were you thinking of a different positioning value (e.g, sticky)?

view this post on Zulip Aru Sahni (Jan 05 2021 at 23:30):

Safari's updates are bound to major iOS releases, so unsupported devices are stuck on older browser versions.

view this post on Zulip Aru Sahni (Jan 05 2021 at 23:31):

If you have time for a brain dump on where Safari support fell over, I'd love to help think through this to see if circumstances have changed.

view this post on Zulip GuillaumeGomez (Jan 05 2021 at 23:32):

Arf, I meant fixed. If you have a fixed inside a static, the fixed positioning is completely broken

view this post on Zulip GuillaumeGomez (Jan 05 2021 at 23:32):

I think it was something around the line that forced me to write horrible code to handle the sidebar on mobile instead of just having a position: fixed

view this post on Zulip GuillaumeGomez (Jan 05 2021 at 23:33):

let me check my last affirmation (about the static part)

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:34):

If needed I have the equipment to test safari rendering on Mac/iPad/iPhone (and Apple Watch :joy:)

view this post on Zulip GuillaumeGomez (Jan 05 2021 at 23:34):

ok no, not static but absolute

view this post on Zulip GuillaumeGomez (Jan 05 2021 at 23:34):

I'm damn tired

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:34):

I’m not a web developer at all though

view this post on Zulip GuillaumeGomez (Jan 05 2021 at 23:35):

if you have a fixed inside an absolute, things get weird on safari iOS

view this post on Zulip GuillaumeGomez (Jan 05 2021 at 23:35):

Poliorcetics said:

If needed I have the equipment to test safari rendering on Mac/iPad/iPhone (and Apple Watch :joy:)

I have a (old) mac so for now I can test :)

view this post on Zulip GuillaumeGomez (Jan 05 2021 at 23:35):

but thanks for the proposition! :D

view this post on Zulip Aru Sahni (Jan 05 2021 at 23:35):

Did you observe differing behavior between desktop Safari and iOS Safari?

view this post on Zulip Aru Sahni (Jan 05 2021 at 23:36):

@Poliorcetics we may need to validate behavior on the watch :stuck_out_tongue_wink:

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:36):

I have never tried to open rust docs on a watch

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:36):

Let me try

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:43):

BB7C9CAF-C6B1-4D07-B8D2-173B660DEBD5.jpg

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:43):

26094BDA-300B-448E-9AD9-E01062D91F87.jpg

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:43):

9FE2346C-FF57-4DB2-8FED-84D14E437CF1.jpg

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:43):

2CDC1093-2C16-41BB-B04C-395B63D9AB03.jpg

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:43):

7BE36A3C-6038-4000-B063-2816CCBBD460.jpg

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:43):

758FF42F-0082-43BB-BC6D-D07265C5358C.jpg

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:43):

Quite nice

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:44):

Readability is a hundred times what I expected

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:46):

Not so much on source pages

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:46):

37DB4BE4-8947-47D0-A31E-119A0DDE9322.jpg

view this post on Zulip Aru Sahni (Jan 05 2021 at 23:47):

Out of curiosity, how does the sidebar look?

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:47):

Code is below

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:47):

BF6CF604-9C6E-4ED2-BD99-F078CA955BAF.jpg

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:48):

@Aru Sahni I can’t access it

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:48):

The browser forces some alternative mode with only the main content it seems

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:49):

That’s okay given the size of the screen

view this post on Zulip Poliorcetics (Jan 05 2021 at 23:50):

A watch should not be used to read docs for more than a very very quick glance

view this post on Zulip Joshua Nelson (Jan 06 2021 at 03:09):

Honestly that looks really good for a watch lol

view this post on Zulip Poliorcetics (Jan 06 2021 at 11:35):

Yeah, the amount of scrolling is insane though


Last updated: Oct 11 2021 at 22:34 UTC