Stream: rustdoc

Topic: `download-rustc` is open for business!


view this post on Zulip Joshua Nelson (Feb 24 2021 at 05:53):

Since the beta bump today, download-rustc should work out of the box :) It speeds up compile times by a factor of about 60 by downloading rustc instead of compiling it from source. I encourage you to try it out! You can enable it by adding download-rustc = true under [rust] in config.toml. There's a list of known issues at https://github.com/rust-lang/rust/issues/81930; if you run into something not on the list, please report it.

Happy hunting!

view this post on Zulip Léo Lanteri Thauvin (Feb 24 2021 at 08:49):

Finally! :heart:

view this post on Zulip Poliorcetics (Feb 24 2021 at 09:46):

I haven’t tested this yet, but how does it interact with modifications to rustc when the feature is on ? Like adding a rustdoc specific-feature that need to exists in the active.rs file of rustc

view this post on Zulip Joshua Nelson (Feb 24 2021 at 13:48):

@Poliorcetics it doesn't. If you need to change rustc you'll have to turn it off. It will warn you if you have changes to compiler/.

view this post on Zulip Poliorcetics (Feb 24 2021 at 13:51):

Oh :frown: Time to keep two copies of the rust git maybe :thinking:

view this post on Zulip Léo Lanteri Thauvin (Feb 24 2021 at 13:52):

git worktree!

view this post on Zulip Noah Lev (Feb 25 2021 at 01:55):

Yes, Git worktrees are amazing! I can't emphasize enough how great they are.

view this post on Zulip CraftSpider (Feb 27 2021 at 23:01):

I just got Not running bootstrap::test::RustdocJson because its artifacts have been downloaded from CI (download-rustc is set), which seems undesirable. Any fix for this?

view this post on Zulip Joshua Nelson (Feb 27 2021 at 23:02):

@CraftSpider cherry pick
https://github.com/rust-lang/rust/pull/82480

view this post on Zulip Joshua Nelson (Mar 02 2021 at 14:32):

Joshua Nelson said:

CraftSpider cherry pick
https://github.com/rust-lang/rust/pull/82480

this has now been merged :)

view this post on Zulip Nelson J Morais (Mar 20 2021 at 21:00):

first try and built a rustdoc in less then two minutes. add to that the package metadata for rust-analyzer, rustc_private = true in Cargo.toml of librustdoc and theres code completion in-tree for all the code i've looked at so far.
really good :+1: :tada:

view this post on Zulip Joshua Nelson (Mar 21 2021 at 16:03):

btw this will be broken this week because it's release week: https://github.com/rust-lang/rust/issues/81930

view this post on Zulip Joshua Nelson (Mar 21 2021 at 16:17):

you can work around it by cherry-picking https://github.com/rust-lang/rust/pull/83350

view this post on Zulip Joshua Nelson (Mar 21 2021 at 17:18):

Joshua Nelson said:

btw this will be broken this week because it's release week: https://github.com/rust-lang/rust/issues/81930

oh oops I take it back, #83350 was already approved :smiley: thank you simulacrum !

view this post on Zulip Nelson J Morais (Mar 21 2021 at 17:37):

ok, thanks for the heads up. I see you already working on fixing that release week issue here: https://github.com/rust-lang/rust/issues/81930#issuecomment-803611902 ?

view this post on Zulip Joshua Nelson (Mar 22 2021 at 07:10):

ok I just spent far too much time on this and I think everything is in flight for this to be turned on by default :)


Last updated: Oct 11 2021 at 22:34 UTC