I noticed while writing release notes that it looks like https://github.com/rust-lang/rust/pull/84176 was merged as insta-stable, which seems surprising to me.
@Joshua Nelson do you know if you just missed this when r+'ing it? I decollapsed most of the main conversation threads but that PR has a lot of commits, some of which revert each other, and back and forth in the discussion thread (and it seems no clear FCP...) so not sure if this was a decision made intentionally
Generally it seems like we shouldn't be adding things insta-stable, even if it is "just" a CLI flag in some sense.
ugh, I could have sworn it was supposed to be unstable
this is still in beta, right, we have time to change it?
wait no, this is unstable: https://github.com/rust-lang/rust/pull/84176/files#diff-9cc5ccbf184245761c03c4d631f96f29d73b3d62aa7c933e9be5dd171b9b9ea3R610
what made you think it was stable?
oh, I was looking in config.rs where it's parsed
I guess we define stability at definition time?
I saw some checks for unstable-options in config.rs so assumed wrong, my bad.
yeah, these should be set at the time they're defined
the checks for unstable-options are because rustdoc's options are a mess and
--output-format json --show-coverage doesn't require
--output-format json alone does
When will we see this in the official docs? (doc.rust-lang.org)
I see that this already works in stdrs.dev but not in doc.rust-lang.org/nightly
I'm completely lost, what are you talking about?
@Elichai Turkel this is still unstable and we don't plan to turn it on for libstd until it's stable
Speaking of which I don't see a tracking issue - @GuillaumeGomez can you open one?
I still have no idea what we're talking about...
Or whatever you named the flag
the "jump to def" feature
ah indeed, didn't open a tracking issue, my bad
Opening one right now
Here it is: https://github.com/rust-lang/rust/issues/89095
(If you feel like I missed something, don't hesitate to edit the issue directly!)
I'm going to remove "check for bugs" if you don't mind, since it's not really actionable
Add support to go to both source definition and documentation page
Hmm, @GuillaumeGomez do you think this needs to block stabilization? It seems useful even without that feature
For me it is
it's actually pretty easy to do too
the biggest blocker is the UI itself imo
I'll send a PR for it next week if you want :)
Sure, that would be great :)
Last updated: Oct 11 2021 at 22:34 UTC