Stream: t-cargo/PubGrub

Topic: pubgrub#46


view this post on Zulip Alex Tokarev (Oct 24 2020 at 15:49):

Currently the only thing holding back pubgrub#46 is naming. I thought discussing it in chat platform may be easier than on Github.

AllowedVersions should be changed to Dependencies per @Matthieu Pizenberg suggestion
Current Dependencies enum should be changed to ???. It is a replacement for what previously was Option, and contains either Unavailable or Known(AllowedVersions) variants.

Does anyone have suggestions for that enum naming?

view this post on Zulip Matthieu Pizenberg (Oct 24 2020 at 16:04):

Hey sorry, with family again this weekend. I'll try detailing a bit more next review with a global review. First one wasmostly saying what my thoughts were when reading commits one after the other

view this post on Zulip Alex Tokarev (Oct 24 2020 at 16:08):

No worries, I think you've done a wonderful job. I was just posting here to see if anyone else had some ideas on naming, which is usually a topic everyone can participate in :smile:

view this post on Zulip Eh2406 (Oct 24 2020 at 16:38):

Enjoy the time with your family! And thank you for the consistently careful reviews.
Also how is this affected by a redesign like pubgrub#50?

view this post on Zulip Alex Tokarev (Oct 24 2020 at 16:42):

Also how is this affected by a redesign like pubgrub#50?

There may be trivial conflicts, but we largely touched different parts of public API as far as I noticed.


Last updated: Oct 21 2021 at 20:33 UTC