Stream: t-cargo/PubGrub

Topic: Some PRs are ripe for merge


view this post on Zulip Matthieu Pizenberg (Oct 12 2020 at 15:45):

It seems to me that #25 (SPDX), #32 (package choice) and #29 (incompat redundancy) are ready to be merged if @Alex Tokarev agrees with these. Don't hesitate to merge those @Alex Tokarev when you have time to review if they are ok.

view this post on Zulip Alex Tokarev (Oct 12 2020 at 19:11):

Indeed. I didn't want to merge any without you having a look. The only one I was brave enough to just merge was clickable documentation links, since it was very hard to do something wrong there.

I'll go over them now.

view this post on Zulip Alex Tokarev (Oct 12 2020 at 19:46):

I've reworded docs a little in #32 (details in the PR) and merged all 3.

view this post on Zulip Alex Tokarev (Oct 12 2020 at 19:47):

By the way, issues in this chat reference the core Rust repository. I wonder if we can change it in settings.

view this post on Zulip Eh2406 (Oct 12 2020 at 20:44):

I don't know the details but there was a conversation about it a while back:
https://rust-lang.zulipchat.com/#narrow/stream/122653-zulip/topic/Clippy.20stream.3F

view this post on Zulip Alex Tokarev (Oct 12 2020 at 20:47):

pubgrub-rs#32

view this post on Zulip Eh2406 (Oct 12 2020 at 20:47):

mpizenberg/pubgrub-rs#32

view this post on Zulip Alex Tokarev (Oct 12 2020 at 20:48):

Yeah a general linkifier algorithm doesn't allow us to quickly write #32 and be done with it.

view this post on Zulip Alex Tokarev (Oct 12 2020 at 20:49):

And typing mpizenberg/pubgrub-rs#32is slower than opening the issue and copying full link

view this post on Zulip Alex Tokarev (Oct 12 2020 at 20:50):

Do you have an access to "Organization Settings > Linkifier" @Eh2406 ?

view this post on Zulip Eh2406 (Oct 12 2020 at 20:52):

I don't have access to that. @Alex Crichton can you change the "Linkifier" rules for this stream? Or do you know who dose?

view this post on Zulip Alex Crichton (Oct 12 2020 at 20:58):

pubgrub#32

view this post on Zulip Alex Crichton (Oct 12 2020 at 20:58):

added a linkifier for pubgrub#nnnn

view this post on Zulip Eh2406 (Oct 12 2020 at 20:58):

You are the best!

view this post on Zulip Alex Crichton (Oct 12 2020 at 20:58):

it doesn't appear to be per-channel

view this post on Zulip Alex Tokarev (Oct 12 2020 at 20:59):

@Alex Crichton Thanks a bunch!


Last updated: Oct 21 2021 at 19:46 UTC