Stream: project-error-handling

Topic: method overviews for `Option` and `Result`


view this post on Zulip Taylor Yu [they/she] (Jun 11 2021 at 04:00):

kind of a draft for now; not really complete yet
https://github.com/rust-lang/rust/pull/86211

view this post on Zulip Taylor Yu [they/she] (Jun 23 2021 at 16:29):

updated Option and Result method overviews pull request, probably ready
https://github.com/rust-lang/rust/pull/86211#issuecomment-866327019

view this post on Zulip Jane Lusby (Jun 23 2021 at 17:11):

looks like josh just did a review, I'll hold off until you've resolved his comments to do a final pass review

view this post on Zulip Josh Triplett (Jun 23 2021 at 17:17):

My comments are very much at the micro-level. With the sole exception of the ones about one section of the transformations heading, none of them affect the overall organization. I think it'd be safe to go ahead and review in parallel.

view this post on Zulip Josh Triplett (Jun 23 2021 at 17:18):

I don't have any further comments beyond what I already posted. (I didn't go through and systematically make the same changes under Result that I did for Option; please apply the analogous edits in both cases, such as to section headings.)

view this post on Zulip Taylor Yu [they/she] (Jun 23 2021 at 17:52):

thanks for the review!

view this post on Zulip Taylor Yu [they/she] (Jul 14 2021 at 00:46):

@Josh Triplett when you get a chance, could you also please look at the updates to https://github.com/rust-lang/rust/pull/86211 to see if they address your feedback? thanks!

view this post on Zulip Josh Triplett (Jul 14 2021 at 01:02):

@Taylor Yu [they/she] I just read through it. One minor wording typo, and otherwise it's ready to merge. Thank you for this awesome work!

view this post on Zulip Josh Triplett (Jul 14 2021 at 01:03):

If you can push that commit I'll r+ it right now.

view this post on Zulip Taylor Yu [they/she] (Jul 14 2021 at 01:08):

thanks! i responded with a note about how it's already fixed (at least i'm pretty sure it is) in a separate existing commit.

view this post on Zulip Joshua Nelson (Jul 14 2021 at 01:14):

wow this PR is awesome :D

view this post on Zulip Joshua Nelson (Jul 14 2021 at 01:14):

you opened it on my birthday, what a great birthday present haha

view this post on Zulip Josh Triplett (Jul 14 2021 at 01:17):

Taylor Yu [they/she] said:

thanks! i responded with a note about how it's already fixed (at least i'm pretty sure it is) in a separate existing commit.

Ah, so it is! Thank you, and sorry for the confusion. I was trying to review the specific commit that I thought had all your changes in response to my feedback, and forgot there were more commits after.

view this post on Zulip Taylor Yu [they/she] (Jul 14 2021 at 01:17):

it's ok! these things are easy to miss sometimes.

view this post on Zulip Josh Triplett (Jul 14 2021 at 01:17):

Thanks for all the detailed work making the documentation wildly better.

view this post on Zulip Josh Triplett (Jul 14 2021 at 01:18):

@Taylor Yu [they/she] Do you have a Twitter handle? I'd love to mention this work there.

view this post on Zulip Josh Triplett (Jul 14 2021 at 01:18):

(if you don't object)

view this post on Zulip Taylor Yu [they/she] (Jul 14 2021 at 01:18):

and that was a fascinatingly roundabout r=me @Joshua Nelson

view this post on Zulip Taylor Yu [they/she] (Jul 14 2021 at 01:19):

Josh Triplett said:

Taylor Yu [they/she] Do you have a Twitter handle? I'd love to mention this work there.

sure, that would be great! i'm @argonblueon Twitter. i haven't updated it in forever though :upside_down:

view this post on Zulip Joshua Nelson (Jul 14 2021 at 01:19):

triage does it pretty often; I'm not technically on the triage team but I like to pretend sometimes haha

view this post on Zulip Josh Triplett (Jul 14 2021 at 01:23):

@Taylor Yu [they/she] Scheduled a tweet for tomorrow, once the change has gone in and the nightly documentation has hopefully been regenerated.

view this post on Zulip Josh Triplett (Jul 14 2021 at 01:23):

Thanks again!

view this post on Zulip Joshua Nelson (Jul 14 2021 at 01:25):

@Josh Triplett fyi bors may not get to it in the next ~4 hours before the next nightly release, so you may not want to make the tweet automatic

view this post on Zulip Josh Triplett (Jul 14 2021 at 01:25):

/me reschedules it for Thursday. :)

view this post on Zulip Josh Triplett (Jul 14 2021 at 01:27):

If I don't arrange these things when I think of them, they don't happen.

view this post on Zulip Josh Triplett (Jul 14 2021 at 01:27):

Scheduling helps.

view this post on Zulip Joshua Nelson (Jul 14 2021 at 01:28):

Josh Triplett said:

If I don't arrange these things when I think of them, they don't happen.

I completely understand, I'm the same way with homework :laughing:

view this post on Zulip Jane Lusby (Jul 14 2021 at 01:34):

Lmk when that goes live so I can retweet

view this post on Zulip Taylor Yu [they/she] (Jul 14 2021 at 01:57):

wow thank you all for the kind words!

view this post on Zulip Josh Triplett (Jul 14 2021 at 03:19):

Jane Lusby said:

Lmk when that goes live so I can retweet

US/Pacific 9:27am Thursday.

view this post on Zulip Josh Triplett (Jul 14 2021 at 03:19):

@Taylor Yu [they/she] This is the kind of work we rarely get someone enthusiastic about doing. You're getting some very real appreciation here. :)

view this post on Zulip Jane Lusby (Jul 14 2021 at 03:20):

It's on my calendar

view this post on Zulip Josh Triplett (Jul 14 2021 at 03:20):

@Jane Lusby ...that'd be a fun feature to have: "share my upcoming scheduled tweets with these specific users, and let them schedule retweets".

view this post on Zulip Jane Lusby (Jul 14 2021 at 03:21):

Yea


Last updated: Jan 29 2022 at 10:51 UTC