Stream: project-error-handling

Topic: Meeting 2021-12-06


view this post on Zulip Jane Lusby [she/her] (Dec 06 2021 at 18:28):

Hey everyone, I know a lot of people are going to be out for the next month so I figure we should do the next couple of error handling meetings async

view this post on Zulip Jane Lusby [she/her] (Dec 06 2021 at 18:28):

Agenda: https://hackmd.io/@rust-libs/Byt9ERjFt

view this post on Zulip Jane Lusby [she/her] (Dec 06 2021 at 18:29):

My current focus is getting the Error trait into core

view this post on Zulip Jane Lusby [she/her] (Dec 06 2021 at 18:30):

which mainly boils down two issues

view this post on Zulip Jane Lusby [she/her] (Dec 06 2021 at 18:31):

  1. adding the requisite lang items to split the downcast methods across core and alloc: https://github.com/rust-lang/rust/pull/90328

view this post on Zulip Jane Lusby [she/her] (Dec 06 2021 at 18:31):

and

view this post on Zulip Jane Lusby [she/her] (Dec 06 2021 at 18:31):

  1. landing generic member access on nightly and removing fn backtrace from the Error trait

view this post on Zulip Jane Lusby [she/her] (Dec 06 2021 at 18:32):

2 could also be done via the Backtrace in core RFC but my impression / hope is that we avoid that implementation short term since it is significantly more complicated

view this post on Zulip Nick Cameron (Dec 06 2021 at 18:34):

I did a pass on the provide any rfc and answered most comments today, so it’s ready for another round of review

view this post on Zulip Jane Lusby [she/her] (Dec 06 2021 at 18:34):

perfect

view this post on Zulip Jane Lusby [she/her] (Dec 06 2021 at 18:35):

@Nick Cameron did you want to also setup a PR implementing the provide_any RFC on nightly?

view this post on Zulip Nick Cameron (Dec 06 2021 at 18:36):

I could do, yeah. I’ll probably have time Thursday or Friday. I’d expect to put it all into the any module as suggested rather than the existing separate module, so I expect refactoring the documentation of the mega module will be the most time consuming

view this post on Zulip Jane Lusby [she/her] (Dec 06 2021 at 18:36):

ack

view this post on Zulip Jane Lusby [she/her] (Dec 06 2021 at 18:37):

also lmk if I can help at all

view this post on Zulip Jane Lusby [she/her] (Dec 06 2021 at 18:37):

beyond providing further review for the RFC

view this post on Zulip Jane Lusby [she/her] (Dec 06 2021 at 18:37):

which I already plan on doing

view this post on Zulip Nick Cameron (Dec 06 2021 at 18:38):

Cool, thanks! I’ll let you know if anything comes up, otherwise it should just be merging my prototype crate into std

view this post on Zulip Jane Lusby [she/her] (Dec 06 2021 at 18:38):

:+1:

view this post on Zulip Nick Cameron (Dec 10 2021 at 18:18):

So I almost have a PR ready for adding provide_any to core, but I found a little snag in the design - the blanket impl I use won't work for downstream crates (or in the docs). Error is not affected (or at least it won't be once it is moved to core). I'll investigate a little bit, but I expect there is a fairly easy fix. Anyway, I hope I'll have an update for the RFC plus the draft PR ready early next week

view this post on Zulip Jane Lusby [she/her] (Dec 10 2021 at 18:42):

awesome!

view this post on Zulip Nick Cameron (Dec 15 2021 at 16:26):

I was off work the last few days, but here is the PR: https://github.com/rust-lang/rust/pull/91970 I've updated the RFC slightly too

view this post on Zulip Jane Lusby [she/her] (Dec 15 2021 at 16:29):

Amazing!


Last updated: Jan 26 2022 at 14:20 UTC