Stream: t-release/triage

Topic: rustbot, new user UX


view this post on Zulip Christian Thäter (Oct 24 2021 at 17:12):

Just FYI/Discussion...

I got a message from rustbot today:

Ping from triage:
@cehteh can you please address the comments and set S-waiting-on-review when you're done? Thank you.

This left me a bit puzzled about how to do this. I known that 'labels' are a github feature, but i didn't seen any UI for changing those. Searching for 'github set label' was not really helpful either. Thus I just asked on the PR how to handle this. Thankfully some kind soul (thanks hkratz) gave me the hint (and by that did this for me):

 Like this:
@rustbot label -S-waiting-on-author +S-waiting-on-review

(rustbot documentation)

Instead it would be nice when rustbot could give such an hint in the first place:

Ping from triage:
@cehteh can you please address the comments then reply with '@rustbot label -S-waiting-on-author +S-waiting-on-review'

Looks to me like some very simple change which would make contribution a lot simpler (and bind less human resources, petting noobs like me).

Furthermore, a bit more complicated: How about a '@rustbot done' command, which just scans what it requested most recently from the user and then applies that (Of course rustbots helpful hint should then include '... or reply with @rustbot done).

view this post on Zulip The 8472 (Oct 24 2021 at 18:10):

Furthermore, a bit more complicated: How about a '@rustbot done' command

@rustbot ready

https://github.com/rust-lang/triagebot/blob/e89e1d524a83d9084c3a3c447a695322f574c5eb/src/handlers/shortcut.rs

view this post on Zulip Noah Lev (Oct 24 2021 at 19:45):

Christian Thäter said:

I got a message from rustbot today:

Ping from triage:
@cehteh can you please address the comments and set S-waiting-on-review when you're done? Thank you.

@rustbot does not send messages like that. Those messages are sent by human triagers. That said, I think we could try to include a mention of @rustbot ready in our messages.

view this post on Zulip John Simon (Oct 24 2021 at 23:28):

@The 8472 sorry I didn't realize that that people not in the "The Rust Programming Language" group had limits on which tags could be set on github. Please ignore that. Thanks

view this post on Zulip Christian Thäter (Oct 25 2021 at 08:47):

I didn't even know that this was a message from a human, was thinking that it was an automated reminder done by triage. Nevermind then.
Still I think it would be nice that for such basics things one doesn't need to read a tons of docs, there is some information overflow. Nevertheless I do like that everything is nicely documented in rust, just with that much docs, discoverability becomes a problem.


Last updated: Jan 26 2022 at 14:20 UTC