Stream: t-release/triage

Topic: reopening PRs


view this post on Zulip Mara (Feb 13 2021 at 02:03):

Hey @DPC, is there a reason you're now suggesting authors of inactive-closed PRs to open a new PR, instead of saying they can re-open the existing one?

view this post on Zulip DPC (Feb 13 2021 at 02:04):

generally when they get to it - theres a chance that conflicts might accumulate. So easier to start with a new PR

view this post on Zulip Mara (Feb 13 2021 at 02:05):

i see. okay

view this post on Zulip DPC (Feb 13 2021 at 02:05):

i know the disadvantage is that it loses context and discussions from the original PR

view this post on Zulip DPC (Feb 13 2021 at 02:05):

also that's an auto reply which I use for all PRs that i'm closing (and generally most of those have conflicts)

view this post on Zulip Mara (Feb 13 2021 at 02:06):

DPC said:

i know the disadvantage is that it loses context and discussions from the original PR

nah i'm not to worried about that. more worried that it feels like a bigger obstacle for them to continue on their work later. but in practice re-opening the same one is probably more effort, yeah.

view this post on Zulip Mara (Feb 13 2021 at 02:06):

alright, thanks :)

view this post on Zulip DPC (Feb 13 2021 at 02:08):

generally they would have the branch on their local fork

view this post on Zulip scottmcm (Feb 13 2021 at 02:20):

I also recall there being some weird github behaviour where you have to reopen the PR before pushing to the branch or it gets confused, so it might be net easier to just make a new one.

view this post on Zulip Léo Lanteri Thauvin (Feb 13 2021 at 08:02):

I think you can't re-open a PR if you force-pushed to it while it was closed

view this post on Zulip tm (Feb 13 2021 at 10:06):

FYI: Last time my PR was closed by the reviewer I didn't have a permission to re-open it (and I didn't push to the branch or anything).

view this post on Zulip John Simon (Feb 14 2021 at 15:35):

https://github.com/rust-lang/rust/pull/79425#issuecomment-763810887 - Author asks: would you prefer that I abandon this PR, or change it to "draft", while I work on that experiment?
I forget - do we have a policy around long-standing WIP PRs?

view this post on Zulip DPC (Feb 14 2021 at 15:49):

you can mark it as draft / s-experiment label

view this post on Zulip DPC (Feb 14 2021 at 15:49):

done already

view this post on Zulip DPC (Feb 14 2021 at 15:50):

ah nvm, the experiment is another PR

view this post on Zulip John Simon (Feb 14 2021 at 16:49):

DPC said:

ah nvm, the experiment is another PR

so should I ask the author to close it or mark it as draft?

view this post on Zulip DPC (Feb 14 2021 at 22:55):

i've marked it as draft already @John Simon


Last updated: Jan 26 2022 at 13:46 UTC