Stream: t-release/triage

Topic: meeting 2021-02-03


view this post on Zulip Noah Lev (Feb 03 2021 at 16:02):

We're meeting now, right?

view this post on Zulip Noah Lev (Feb 03 2021 at 16:03):

@WG-triage I think it's meeting time!

view this post on Zulip DPC (Feb 03 2021 at 16:03):

Yeah sorry

view this post on Zulip DPC (Feb 03 2021 at 16:05):

I think it's just the 2 of us

view this post on Zulip Joel Palmer (Feb 03 2021 at 16:05):

I'm here

view this post on Zulip Alex Macleod (Feb 03 2021 at 16:05):

I'm also here

view this post on Zulip DPC (Feb 03 2021 at 16:05):

Ah cool

view this post on Zulip DPC (Feb 03 2021 at 16:07):

So I think I have 2 things to discuss - first thing is the number of prs have been increasing over the last few months lesser reviewers

view this post on Zulip DPC (Feb 03 2021 at 16:07):

And also reviewers asking for a longer review period

view this post on Zulip Noah Lev (Feb 03 2021 at 16:08):

(Current PR count is 376, down from ~410 earlier)

view this post on Zulip DPC (Feb 03 2021 at 16:08):

So feel free if you want to close a few prs that are waiting on author (esp non-members) and also if you feel certain prs could be pushed a bit more aggressively just add them to the report

view this post on Zulip Noah Lev (Feb 03 2021 at 16:08):

I think we also were going to discuss report format?

view this post on Zulip DPC (Feb 03 2021 at 16:09):

Yes that's the 2nd thing

view this post on Zulip DPC (Feb 03 2021 at 16:09):

So as far as the report is concerned - I'm not that worried about what format you use

view this post on Zulip DPC (Feb 03 2021 at 16:09):

As long as I have the following things covered -

view this post on Zulip DPC (Feb 03 2021 at 16:11):

1) pr number with link to the pr for easy checking
2) author + reviewer
3) status of the pr (would appreciate grouping the prs by status label makes it easier for me)
4) last state of the pr (if it has conflicts or someone else has reviewed etc )

view this post on Zulip Noah Lev (Feb 03 2021 at 16:11):

(cc forge#501)

view this post on Zulip DPC (Feb 03 2021 at 16:12):

I'll approve that later today

view this post on Zulip Noah Lev (Feb 03 2021 at 16:12):

(No rush, just wanted to mention it since it documents what you just posted :)

view this post on Zulip DPC (Feb 03 2021 at 16:12):

Any other information if you wish to add will be helpful

view this post on Zulip Noah Lev (Feb 03 2021 at 16:13):

I think part of why I was wondering about the format was that I thought my format might not be particularly readable:

#12345 21 days - has conflicts - author: foo, assignee: bar
#45678 21 days - has conflicts - author: foo, assignee: bar

view this post on Zulip DPC (Feb 03 2021 at 16:13):

Seems readable to me

view this post on Zulip Noah Lev (Feb 03 2021 at 16:13):

Okay, if it works for you then great! :)

view this post on Zulip DPC (Feb 03 2021 at 16:14):

As long as that is grouped by what label it is

view this post on Zulip DPC (Feb 03 2021 at 16:14):

Or mentioned if it is waiting on review or author

view this post on Zulip Noah Lev (Feb 03 2021 at 16:14):

Yeah I group under the label.

view this post on Zulip DPC (Feb 03 2021 at 16:14):

That's fine since mostly it's me looking at the reports

view this post on Zulip Noah Lev (Feb 03 2021 at 16:15):

Although it seems other people look at them too (like Mara)

view this post on Zulip DPC (Feb 03 2021 at 16:15):

And some other members but that's mostly to pick stuff

view this post on Zulip Noah Lev (Feb 03 2021 at 16:15):

Yeah, they can just glance through it or search for their username I think

view this post on Zulip DPC (Feb 03 2021 at 16:15):

As long as the top 4 points are covered should be fine

view this post on Zulip Noah Lev (Feb 03 2021 at 16:16):

Btw, I filtered the PR list and it seems we have 281 non-blocked, non-waiting-on-team, non-draft PRs.

view this post on Zulip DPC (Feb 03 2021 at 16:16):

If people have doubts they can check the pr

view this post on Zulip Noah Lev (Feb 03 2021 at 16:17):

(for meetings it would be really nice if Zulip said when people were typing :laughing:)

view this post on Zulip DPC (Feb 03 2021 at 16:17):

Yeah some of the prs are often in conflict-review loops

view this post on Zulip DPC (Feb 03 2021 at 16:17):

Agreed

view this post on Zulip DPC (Feb 03 2021 at 16:17):

We've raised this issue with zulip maintainers as well

view this post on Zulip DPC (Feb 03 2021 at 16:18):

I'll look into list of open prs again and see what can be pushed

view this post on Zulip Noah Lev (Feb 03 2021 at 16:18):

Yeah I like sometimes that it doesn't show who's typing all the time, but for meetings it would be kind of nice.

view this post on Zulip DPC (Feb 03 2021 at 16:18):

That's it from my end. Anyone has anything to add?

view this post on Zulip Noah Lev (Feb 03 2021 at 16:18):

You mentioned about lengthening review window?

view this post on Zulip DPC (Feb 03 2021 at 16:18):

No I didn't

view this post on Zulip Noah Lev (Feb 03 2021 at 16:18):

DPC said:

And also reviewers asking for a longer review period

view this post on Zulip Noah Lev (Feb 03 2021 at 16:19):

Did I misunderstand what you were saying?

view this post on Zulip Charles Lew (Feb 03 2021 at 16:19):

it had already changed , it used to be 7 days

view this post on Zulip DPC (Feb 03 2021 at 16:20):

Yeah sorry I meant earlier when it changed from 1 week to 2 weeks

view this post on Zulip Noah Lev (Feb 03 2021 at 16:20):

Oh, when did that happen?

view this post on Zulip DPC (Feb 03 2021 at 16:20):

Which means more likely they'll be more open prs and more conflicts

view this post on Zulip Charles Lew (Feb 03 2021 at 16:21):

-

view this post on Zulip DPC (Feb 03 2021 at 16:21):

Happened a year back iirc when people needed more time due to the lockdown and a few reviewers opting out of review cycle

view this post on Zulip DPC (Feb 03 2021 at 16:23):

Anyone has anything to add?

view this post on Zulip Noah Lev (Feb 03 2021 at 16:23):

@triagebot end-meeting

view this post on Zulip triagebot (Feb 03 2021 at 16:23):

Does anyone have something to bring up?
React with :working_on_it: if you have something to say.
React with :all_good: if you're ready to end the meeting.

view this post on Zulip DPC (Feb 03 2021 at 16:23):

Don't have it linked to my account yet

view this post on Zulip Noah Lev (Feb 03 2021 at 16:24):

@DPC just ping triagebot now and it will tell you how to set up

view this post on Zulip Noah Lev (Feb 03 2021 at 16:24):

(e.g. it will give your Zulip ID)

view this post on Zulip DPC (Feb 03 2021 at 16:24):

Anyway, thanks for the efforts and attending the meeting. Next one should be on 03.03.2021 at the same time

view this post on Zulip DPC (Feb 03 2021 at 16:24):

Yeah I'm aware but I'm on mobile now so will do it later

view this post on Zulip DPC (Feb 03 2021 at 16:25):

Have a safe February


Last updated: Jan 26 2022 at 13:46 UTC