Stream: t-release/triage

Topic: labeling closed due to inactivity PRs


view this post on Zulip The 8472 (Jul 28 2021 at 20:41):

Would it make sense to put a label on PRs that were closed due to inactivity in case someone else wants to pick up the work later? Sometimes work is nearly finished but abandoned for reasons, so it might not be hard to pick up. Could even be useful for beginners.

Otherwise it's not easy to distinguish them from PRs that were closed due to other reasons.

view this post on Zulip bstrie (Jul 28 2021 at 20:42):

IMO ideally PRs should reference an open issue. As long as that issue remains open, that PR will be linked from the issue, and you can leave a comment on the issue to explicitly note the PR when the PR is closed, in case someone working on the issue wants to pick it back up.

view this post on Zulip bstrie (Jul 28 2021 at 20:42):

And if a PR doesn't reference an open issue and you want to close it, it might make sense to open an issue to track whatever concern it was trying to address

view this post on Zulip The 8472 (Jul 28 2021 at 20:42):

I think i've seen a few that had no associated issue.

view this post on Zulip Yuki Okushi (Jul 28 2021 at 20:43):

Triagers should add the S-inactive label: https://github.com/rust-lang/rust/pulls?q=is%3Apr+label%3AS-inactive+is%3Aclosed

view this post on Zulip Joshua Nelson (Jul 28 2021 at 20:43):

There's already S-inactive for this

view this post on Zulip The 8472 (Jul 28 2021 at 20:43):

Oh nice, didn't know about that one!

view this post on Zulip bstrie (Jul 28 2021 at 20:44):

Is that preferred to just closing the PR?

view this post on Zulip The 8472 (Jul 28 2021 at 20:44):

i'm looking at the list, it's added to the closed ones

view this post on Zulip Joshua Nelson (Jul 28 2021 at 20:44):

You should both close the PR and add the label

view this post on Zulip The 8472 (Jul 28 2021 at 20:45):

Would it make sense to point beginners to the graveyard if they're interested in necromancy? :sweat_smile:

view this post on Zulip Yuki Okushi (Jul 28 2021 at 20:46):

sounds good

view this post on Zulip DPC (Jul 29 2021 at 00:24):

we already add s-inactive label when closing prs,
also yes i often pas those prs to newcomers to work on :stuck_out_tongue:


Last updated: Jan 29 2022 at 09:28 UTC