Stream: t-release/triage

Topic: glacier review


view this post on Zulip Noah Lev (Dec 01 2020 at 18:59):

What do I need to do as part of review before merging a glacier PR? For adding a new ICE, do I just make sure CI passes and glance at the code to make sure it's not malicious?

view this post on Zulip Léo Lanteri Thauvin (Dec 01 2020 at 19:06):

I don't even know who's responsible for merging these :D
Maybe @Jonas Schievink can help

view this post on Zulip Jonas Schievink [he/him] (Dec 01 2020 at 19:07):

Never worked on glacier, sorry

view this post on Zulip Léo Lanteri Thauvin (Dec 01 2020 at 19:08):

Maybe @simulacrum then?

view this post on Zulip simulacrum (Dec 01 2020 at 19:08):

I have no context in terms of glacier, haven't touched it.

view this post on Zulip simulacrum (Dec 01 2020 at 19:09):

It seems fine to do as you suggest though.

view this post on Zulip Noah Lev (Dec 01 2020 at 19:22):

Perhaps @Alex Macleod knows: I think you've been active on glacier

view this post on Zulip Alex Macleod (Dec 01 2020 at 19:59):

Yeah, apart from that double check the issue number in the filename is correct

view this post on Zulip John Simon (Dec 02 2020 at 16:07):

sorry, do we have a triage meeting scheduled right now?

view this post on Zulip DPC (Dec 02 2020 at 16:33):

@John Simon yes but unfortunately had some emergency work at that time and couldn''t connect to inform y'all


Last updated: Jan 26 2022 at 14:20 UTC