Hey @Joshua Nelson, I'm triaging #77290 and reading its thread and the related PRs. #78666 fixes the errors and I don't think it's much worth applying shellcheck's suggestions to our source, while fighting a lot of regressions, so I'm going to close the issue. You reviewed the PRs so I'd like to ask, do you think we still have some work to fix here (i.e. we shouldn't close it)?
I think it's fine to close it
ok, closed, thanks!
Last updated: Jan 26 2022 at 14:02 UTC