Stream: t-release/triage

Topic: Question: -label +label ?


view this post on Zulip Mara (Jan 30 2021 at 13:03):

Hey triage team!

I have a question: I often see a someone from triage just remove and add the same label, without pinging anyone. What is that for?

view this post on Zulip Noah Lev (Jan 30 2021 at 18:55):

It's so that GitHub treats the PR as updated recently so the next triage person doesn't see that PR.

view this post on Zulip Noah Lev (Jan 30 2021 at 18:56):

It's annoying to do and kind of a "hacky" approach, but it works :)

view this post on Zulip Mara (Jan 30 2021 at 20:50):

Ah, i see. So that's done in cases where the author/reviewer isn't pinged on purpose? Is there any guideline for when people get pinged from triage?

view this post on Zulip Noah Lev (Jan 30 2021 at 20:54):

forge#501 :smile:

view this post on Zulip Mara (Jan 30 2021 at 21:00):

Ah, thanks!

view this post on Zulip Mara (Jan 30 2021 at 21:00):

If the author is a member of a Rust team (..)

Ah, that explains why the pings have stopped ^^'

view this post on Zulip Noah Lev (Jan 30 2021 at 21:01):

That PR is derived from this:

-> filter prs that aren't active for more than 15 days (by updated at, stupid metric but limited by gh)
-> check label to find the status of the pr (update if necessary by changing the label)
-> if waiting on review:
----> if it has new conflicts, CI failed, or a new review has been made:
---------> update label accordingly to waiting-on-author, ping author
----> don't ping anyone, add the pr to a "report" (explained later)
-> if waiting on author:
----> if it was waiting on author to make changes or resolve conflicts, update the label to waiting-on-review
----> is author a rust team member?
----> if yes, don't png anyone, add the pr to the report
----> if no, ping the author, can add to the report if feel so
-> occasionally (maybe once a month), check for blocked prs: (s-blocked)
---> if it is still blocked, leave as is
---> if it is unblocked (blocked pr is merged), then unblock and update the status accordingly

(It's been posted at various times in this stream by DPC.)

view this post on Zulip DPC (Jan 30 2021 at 22:54):

it is just done so that the pr is marked as "triaged" and the next person who does triage doesn't pick the same PR

view this post on Zulip DPC (Jan 30 2021 at 22:54):

when it comes to pinging people or leaving a comment there, it isn't needed, because the pr gets updated so it wont show up in other people's filters


Last updated: Jan 26 2022 at 14:46 UTC