Stream: t-release/triage

Topic: Moving forward in the PR process


view this post on Zulip J. Ryan Stinnett (Jan 11 2021 at 17:37):

(I am still learning about compiler team processes, so please let me know if there's a better place for this, etc.)

One of my PRs (https://github.com/rust-lang/rust/pull/79757) has had an initial round of review about 1 month ago, but since then things have gone quiet. Maybe this is expected with holidays and such? I noticed the reviewer seems to have a large queue of reviews... Would it make sense for someone else to take a look? It's not urgent, but I am just curious whether I should keep waiting or what... I know we're all quite busy, so again just trying to learn what's appropriate here. Thanks! :smile:

view this post on Zulip Joshua Nelson (Jan 11 2021 at 18:24):

@J. Ryan Stinnett Esteban Küber was offline for all of december, I'd just ping them again

view this post on Zulip J. Ryan Stinnett (Jan 11 2021 at 18:39):

Okay, thanks!

view this post on Zulip DPC (Jan 11 2021 at 22:29):

i wouldn't pinged them (too late i know), we usually do that and there are many prs waiting on them so we can prio based on that. anyway too late


Last updated: Jan 29 2022 at 10:51 UTC