Stream: t-release/triage

Topic: Meeting 2020-10-07


view this post on Zulip DPC (Oct 07 2020 at 16:00):

@WG-triage meeting time, react with :wave: to indicate prescence

view this post on Zulip DPC (Oct 07 2020 at 16:03):

thanks everyone for triaging over the last month, your efforts are appreciated.

view this post on Zulip DPC (Oct 07 2020 at 16:03):

I'm assuming some of the team members are busy in life, so that's fine, so decided to add a few members to the team just to help out and ensure there's still enough triage happening

view this post on Zulip DPC (Oct 07 2020 at 16:04):

I would like to welcome @Camelid to the wg-triage team :smile:

view this post on Zulip Noah Lev (Oct 07 2020 at 16:04):

Hello! Thanks for inviting me :smile:

view this post on Zulip DPC (Oct 07 2020 at 16:05):

since you are added to rust-lang/team, your permissions should be sorted, and I added you to the team ping here so that should be good enough

view this post on Zulip DPC (Oct 07 2020 at 16:05):

let me pull up the existing schedule quickly

view this post on Zulip DPC (Oct 07 2020 at 16:07):

the current schedule is:
monday - @JohnCSimon
tues - @JoelPalmer
wed - @Alex Macleod
thurs - @Elinvynia
fri - @crlf0710
sat - @Muirrum
sun - vacant

so Camelid are you available on wednesdays to triage? (since Elinvynia seems to be "afk" for a few weeks i bet)

view this post on Zulip Noah Lev (Oct 07 2020 at 16:07):

Okay, that sounds good

view this post on Zulip DPC (Oct 07 2020 at 16:08):

cool

view this post on Zulip DPC (Oct 07 2020 at 16:09):

you can pick any time and way of doing that comfortable to you not a problem, once you are done you can submit a report in the respective weekly thread

view this post on Zulip Noah Lev (Oct 07 2020 at 16:09):

I know you sent me a workflow for triaging PRs - do I triage issues too?

view this post on Zulip DPC (Oct 07 2020 at 16:09):

i'm not too bothered about the format, you can pick whatever suits you or what the others do to maintain consistency

view this post on Zulip DPC (Oct 07 2020 at 16:10):

uhm yes, you can triage the new issues if you wish or once in a while (maybe once in a month) you can scan older issues just to check if any labels need to be added (just a nice-to-do not mandatory)

view this post on Zulip DPC (Oct 07 2020 at 16:11):

also pr wise, if you wish you can pick just one label and triage all of them

view this post on Zulip DPC (Oct 07 2020 at 16:12):

our main focus normally is waiting-on-review and waiting-on-author, the others don't need to be triaged every week (across all triagists)

view this post on Zulip DPC (Oct 07 2020 at 16:12):

with respect to permissions, i'll add you later to the calendar invite. We have a meeting on first Wednesday of every month at the sae time

view this post on Zulip Noah Lev (Oct 07 2020 at 16:13):

Okay, I already added it to my calendar :smile:

view this post on Zulip DPC (Oct 07 2020 at 16:13):

i'll send you the invite anyway, makes it easier if we change time in the future

view this post on Zulip DPC (Oct 07 2020 at 16:14):

we don't have much else to discuss today, so for this month the triage work remains same as usual

view this post on Zulip DPC (Oct 07 2020 at 16:14):

i'm assuming @John Simon you are triaging rustbot-claimed-inactive issues right?

view this post on Zulip DPC (Oct 07 2020 at 16:15):

oh wait it wasn't you

view this post on Zulip DPC (Oct 07 2020 at 16:15):

Alex isn't around today, so i'll ask them some other today

view this post on Zulip Noah Lev (Oct 07 2020 at 16:15):

By the way, rustbot doesn't seem to be assigning itself these days - it seems to directly assign now

view this post on Zulip DPC (Oct 07 2020 at 16:16):

ah okay

view this post on Zulip DPC (Oct 07 2020 at 16:17):

anyone has anything to talk about? any feedback from triage work?

view this post on Zulip John Simon (Oct 07 2020 at 16:18):

so far so good

view this post on Zulip DPC (Oct 07 2020 at 16:18):

just to go back through it, and since I had written it on chat, here's our current workflow:
mainly the process is :
-> filter prs that aren't active for more than 15 days (by updated at, stupid metric but limited by gh)
-> check label to find the status of the pr (update if necessary by changing the label)
-> if waiting on review:
----> if it has new conflicts, CI failed, or a new review has been made:
---------> update label accordingly to waiting-on-author, ping author
----> don't ping anyone, add the pr to a "report" (explained later)
-> if waiting on author:
----> if it was waiting on author to make changes or resolve conflicts, update the label to waiting-on-review
----> is author a rust team member?
----> if yes, don't png anyone, add the pr to the report
----> if no, ping the author, can add to the report if feel so
-> occasionally (maybe once a month), check for blocked prs: (s-blocked)
---> if it is still blocked, leave as is
---> if it is unblocked (blocked pr is merged), then unblock and update the status accordingly

view this post on Zulip John Simon (Oct 07 2020 at 16:20):

is this description of the procedure up to date?
https://forge.rust-lang.org/release/triage-procedure.html

view this post on Zulip DPC (Oct 07 2020 at 16:20):

also if any of you have other ways to find inactive prs, i've no problem with that (as long as 15 days from review/last-commit is kept in mind)

view this post on Zulip DPC (Oct 07 2020 at 16:20):

i think that question pops up every meeting :grinning:

view this post on Zulip DPC (Oct 07 2020 at 16:21):

that doesn't talk about not mentioning members, so i think nope

view this post on Zulip Noah Lev (Oct 07 2020 at 16:21):

I see a PR that was re-assigned 12 days ago, but the PR hasn't been reviewed in 29 days: should I add it to my report?

view this post on Zulip DPC (Oct 07 2020 at 16:22):

since it was reassigned i would say no

view this post on Zulip DPC (Oct 07 2020 at 16:22):

though it's 12 days (so just 3 days short), and I wouldn't mind if you added it

view this post on Zulip DPC (Oct 07 2020 at 16:23):

also normally look for reviews from main assigned person, unless it's an important rust member who has left a review

view this post on Zulip Noah Lev (Oct 07 2020 at 16:24):

It's been ready for review for 29 days, was assigned to nikomatsakis but went without review, then was re-assigned to Esteban Küber 12 days ago but still hasn't been reviewed

view this post on Zulip DPC (Oct 07 2020 at 16:24):

if any member finds a pr that they arent sure what to do, you can add them to the report

view this post on Zulip DPC (Oct 07 2020 at 16:25):

add it to the report, i'll look into later

view this post on Zulip DPC (Oct 07 2020 at 16:25):

anyone has anything else to talk about?

view this post on Zulip Noah Lev (Oct 07 2020 at 16:26):

Does anyone have any GitHub searches to recommend?

view this post on Zulip Joshua Nelson (Oct 07 2020 at 16:27):

I sort by 'least recently updated' on prs and that works pretty well

view this post on Zulip DPC (Oct 07 2020 at 16:27):

yah that's the normal workflow

view this post on Zulip DPC (Oct 07 2020 at 16:28):

but prob is it also takes into account a few things -
comments left by people
label changes

view this post on Zulip Noah Lev (Oct 07 2020 at 16:28):

I assume I shouldn't triage draft PRs?

view this post on Zulip DPC (Oct 07 2020 at 16:28):

you can triage them no problem

view this post on Zulip Noah Lev (Oct 07 2020 at 16:29):

I guess except for things like Pietro's CI playground :)

view this post on Zulip DPC (Oct 07 2020 at 16:29):

if it's an experiment pr, i wold say not to ping

view this post on Zulip DPC (Oct 07 2020 at 16:29):

yeah

view this post on Zulip DPC (Oct 07 2020 at 16:29):

there was joshua's playground at some stage :grinning:

view this post on Zulip John Simon (Oct 07 2020 at 16:29):

@camelid
I always use the github searches here, waiting on author, waiting on review https://forge.rust-lang.org/release/triage-procedure.html

view this post on Zulip Noah Lev (Oct 07 2020 at 16:29):

Great, thanks!

view this post on Zulip DPC (Oct 07 2020 at 16:29):

occassionally i also do "sort by oldest prs"

view this post on Zulip DPC (Oct 07 2020 at 16:30):

just to search any PRs that triagists might have missed

view this post on Zulip DPC (Oct 07 2020 at 16:30):

and to push some of the older ones

view this post on Zulip DPC (Oct 07 2020 at 16:30):

also when you triage, and not ping remember to change the label to the same label so that others during the week don't track the same pr when they triage

view this post on Zulip Joshua Nelson (Oct 07 2020 at 16:31):

DPC said:

there was joshua's playground at some stage :D

bootstrap :very_angry: https://github.com/rust-lang/rust/pull/76800

view this post on Zulip Noah Lev (Oct 07 2020 at 16:31):

You mean change to S-waiting-on-author if there are conflicts?

view this post on Zulip DPC (Oct 07 2020 at 16:31):

i wasn't referring to that but you can do it

view this post on Zulip Joshua Nelson (Oct 07 2020 at 16:31):

Camelid said:

You mean change to S-waiting-on-author if there are conflicts?

I still don't like this policy tbh

view this post on Zulip Noah Lev (Oct 07 2020 at 16:31):

Oh, what do you mean?

view this post on Zulip Joshua Nelson (Oct 07 2020 at 16:31):

https://rust-lang.zulipchat.com/#narrow/stream/242269-t-release.2Ftriage/topic/Criteria.20for.20triage.20to.20look.20at.20a.20PR

view this post on Zulip DPC (Oct 07 2020 at 16:32):

we'll discuss that separately josh :stuck_out_tongue:

view this post on Zulip DPC (Oct 07 2020 at 16:32):

camelid, what i meant was

view this post on Zulip Joshua Nelson (Oct 07 2020 at 16:32):

and https://rust-lang.zulipchat.com/#narrow/stream/242269-t-release.2Ftriage/topic/Label.20switching.20for.20outsiders.20is.20hard/near/211798390

view this post on Zulip DPC (Oct 07 2020 at 16:32):

if a pr is waiting on review, and the assignee hasn't reviewed

view this post on Zulip DPC (Oct 07 2020 at 16:32):

and you dont ping the reviewer

view this post on Zulip DPC (Oct 07 2020 at 16:32):

just remove waiting-on-review and add the same label again

view this post on Zulip Noah Lev (Oct 07 2020 at 16:33):

Ah, so GitHub picks up activity?

view this post on Zulip DPC (Oct 07 2020 at 16:33):

yep

view this post on Zulip DPC (Oct 07 2020 at 16:33):

so the person triaging the net day doesn't see the same pr

view this post on Zulip DPC (Oct 07 2020 at 16:33):

we are out of time, so thanks everyone for attending

view this post on Zulip Noah Lev (Oct 07 2020 at 16:33):

Thank you!

view this post on Zulip DPC (Oct 07 2020 at 16:34):

the next meeting will be on

view this post on Zulip Noah Lev (Oct 07 2020 at 16:34):

By the way, this might be helpful for people: https://docs.github.com/en/free-pro-team@latest/github/searching-for-information-on-github/searching-issues-and-pull-requests

view this post on Zulip Noah Lev (Oct 07 2020 at 16:34):

(If you haven't already found it)

view this post on Zulip DPC (Oct 07 2020 at 16:34):

(kindly note the time shift for those affected by end of DST in your areas)

view this post on Zulip Noah Lev (Oct 07 2020 at 16:34):

Oh yeah, thanks :)

view this post on Zulip Noah Lev (Oct 07 2020 at 16:34):

Ugh, DST: the enemy of all programmers

view this post on Zulip DPC (Oct 07 2020 at 16:34):

it's still at 16.00 UTC :smile:

view this post on Zulip DPC (Oct 07 2020 at 16:35):

that's it for today

view this post on Zulip Noah Lev (Oct 07 2020 at 16:35):

Bye! :wave:

view this post on Zulip DPC (Oct 07 2020 at 16:35):

if during the month you have anything to discuss, drop a thread in the stream

view this post on Zulip DPC (Oct 07 2020 at 16:35):

or add it items to the agenda here: https://hackmd.io/DZ2q4BlpRkSyf4RUxtil9g (Assuming people have permission)

view this post on Zulip DPC (Oct 07 2020 at 16:36):

thanks and stay safe :smile:

view this post on Zulip Noah Lev (Oct 07 2020 at 16:36):

Actually, I have a question (feel free to answer later if you have to go): do I need to fill out the Google Form mentioned on Forge?

IMPORTANT: Whenever you do PR triage, please fill out the following form: goo.gl/forms/YKYVFYjBq28Hm3qQ2. If you want to create a bookmark for yourself, you can adapt this link to prefill your GitHub username.

view this post on Zulip DPC (Oct 07 2020 at 16:37):

no, that used to be the past process

view this post on Zulip DPC (Oct 07 2020 at 16:37):

since we moved to zulip, and people are submitting reports, I don't need to check the sheet any more to know if someone has triaged

view this post on Zulip Noah Lev (Oct 07 2020 at 16:37):

Okay, maybe I'll get around to updating that page at some point...

view this post on Zulip DPC (Oct 07 2020 at 16:37):

ya thanks :grinning:

view this post on Zulip DPC (Oct 07 2020 at 16:38):

i'm a bit hesitant to update it since sometimes we have to tune our process in order to make things better and updating the document every time could be annoying :grinning:

view this post on Zulip Noah Lev (Oct 07 2020 at 16:46):

Yeah, but hopefully we can keep it roughly up to date :)

view this post on Zulip Noah Lev (Oct 07 2020 at 17:08):

DPC said:

-> if waiting on author:
----> if it was waiting on author to make changes or resolve conflicts, update the label to waiting-on-review

This part confuses me: if the author needs to make a change, should I really change to waiting-on-review?

view this post on Zulip DPC (Oct 07 2020 at 17:11):

it's a "tense" issue :stuck_out_tongue:

view this post on Zulip DPC (Oct 07 2020 at 17:11):

what i meant is : "if earlier it was waiting on author to make changes"

view this post on Zulip Noah Lev (Oct 07 2020 at 17:12):

Hmm, what do you mean?

view this post on Zulip DPC (Oct 07 2020 at 17:13):

so if a pr was waiting on an author to make changes or resolve conflicts, and they have done it (pushed a new commit), the label needs to be updated to -on-review

view this post on Zulip Noah Lev (Oct 07 2020 at 17:15):

Ah! That's what I thought, but wasn't sure :)

view this post on Zulip DPC (Oct 08 2020 at 16:35):

@Camelid are you open to triaging on thursdays instead of wednesdays?

view this post on Zulip Noah Lev (Oct 08 2020 at 20:09):

DPC said:

Camelid are you open to triaging on thursdays instead of wednesdays?

Hmm, can I get back to you?

view this post on Zulip DPC (Oct 08 2020 at 21:00):

sure :smile:

view this post on Zulip Noah Lev (Oct 09 2020 at 21:59):

@DPC Okay, I think Thursdays will work :smile:

view this post on Zulip DPC (Oct 10 2020 at 00:20):

@Camelid thanks for confirming. As i said during the meeting, if you can't make it on a given week, that's totally fine by us.


Last updated: Jan 26 2022 at 14:20 UTC