Stream: t-release/triage

Topic: Meeting 10.03.2021


view this post on Zulip DPC (Mar 10 2021 at 16:01):

@WG-triage meeting time

view this post on Zulip DPC (Mar 10 2021 at 16:03):

let's start

view this post on Zulip DPC (Mar 10 2021 at 16:04):

so just to ask - is there anyone who triages blocked prs and sees if any of those can be unblocked?

view this post on Zulip Noah Lev (Mar 10 2021 at 16:05):

I do that once in a while for a couple blocked PRs.

view this post on Zulip DPC (Mar 10 2021 at 16:05):

it's not something that needs to be done every week, just once or twice a month should be fine

view this post on Zulip John Simon (Mar 10 2021 at 16:05):

haven't done that - I'm just searching for waiting on author and reviewer - but that's definitely a thing to do
Author says "Blocked by ####" and #### is merged already

view this post on Zulip DPC (Mar 10 2021 at 16:06):

that's fine

view this post on Zulip Noah Lev (Mar 10 2021 at 16:07):

The difficult thing about triaging S-blocked PRs is that the oldest ones are likely still blocked and the newest ones are likely still blocked

view this post on Zulip DPC (Mar 10 2021 at 16:07):

i think @Camelid can do it during the triage work itself- just filter all blocked prs and see if any status has changed

view this post on Zulip DPC (Mar 10 2021 at 16:07):

yeh definitely

view this post on Zulip Noah Lev (Mar 10 2021 at 16:08):

Because the oldest ones have been blocked for forever and the new ones have only been blocked for a day

view this post on Zulip Noah Lev (Mar 10 2021 at 16:08):

So we need to find the ones that are in the middle :upside_down:

view this post on Zulip Noah Lev (Mar 10 2021 at 16:08):

Does anyone have tips for that?

view this post on Zulip Noah Lev (Mar 10 2021 at 16:08):

Or other ways to make it easier to triage S-blocked?

view this post on Zulip DPC (Mar 10 2021 at 16:09):

yeah true - but it's more about finding any ones that get unblocked and aren't reported, since those are not triaged they'll remain blocked forever unless the author/reviewer/or a random person check that

view this post on Zulip DPC (Mar 10 2021 at 16:09):

unfortunately i don't think there's a better way than checking each blocked pr

view this post on Zulip Charles Lew (Mar 10 2021 at 16:09):

it would be nice if we can tell rustbot which depends on which and it automatically act accordingly... just thinking aloud.

view this post on Zulip Noah Lev (Mar 10 2021 at 16:10):

That's an interesting idea!

view this post on Zulip Noah Lev (Mar 10 2021 at 16:10):

I wonder if I could try to implement that...

view this post on Zulip Noah Lev (Mar 10 2021 at 16:10):

Some PRs are blocked on something other than another PR merging, but most often it's another PR which is relatively easy to detect.

view this post on Zulip Noah Lev (Mar 10 2021 at 16:11):

Something like @rustbot blocked on #123.

view this post on Zulip DPC (Mar 10 2021 at 16:11):

that wouldn't be a bad idea

view this post on Zulip DPC (Mar 10 2021 at 16:11):

yeh it can either be an issue (where it is waiting for it to be solved (so closed) or a PR (merged)

view this post on Zulip Noah Lev (Mar 10 2021 at 16:11):

It might be nice to have rustbot use a label in addition to S-blocked like rustbot-blocked-tracked so those don't show up in our search.

view this post on Zulip DPC (Mar 10 2021 at 16:12):

i'm also going to go around and close some of the older blocked prs since if they are blocked for so long, it doesn't make much sense keeping them open

view this post on Zulip Noah Lev (Mar 10 2021 at 16:12):

And add S-blocked-closed I guess?

view this post on Zulip Noah Lev (Mar 10 2021 at 16:13):

Btw, should we remove S-inactive?

view this post on Zulip Noah Lev (Mar 10 2021 at 16:13):

Or is it used?

view this post on Zulip Noah Lev (Mar 10 2021 at 16:13):

I don't see any open PR with S-inactive and only one closed PR with S-inactive.

view this post on Zulip DPC (Mar 10 2021 at 16:14):

i'm not sure why that label exists, so if you wish to you can remove it (or let me know if you have don't permissions)

view this post on Zulip DPC (Mar 10 2021 at 16:15):

ye you need to add s-blocked-closed, or s-blocked itself doesn't matter since the prs are closed so it won't show up on filters

view this post on Zulip Noah Lev (Mar 10 2021 at 16:15):

DPC said:

i'm not sure why that label exists, so if you wish to you can remove it (or let me know if you have don't permissions)

Yeah, I have permissions, I just want to make sure I'm not removing something that someone uses. I might just leave it just in case.

view this post on Zulip DPC (Mar 10 2021 at 16:16):

s-inactive looks same as s-waiting-on-author for open prs or s-inactive-closed for closed prs, so I think we are covered.

view this post on Zulip DPC (Mar 10 2021 at 16:16):

anything else on this topic?

view this post on Zulip Noah Lev (Mar 10 2021 at 16:17):

Do we still use S-waiting-on-bikeshed?

view this post on Zulip Noah Lev (Mar 10 2021 at 16:17):

It looks like no.

view this post on Zulip Joshua Nelson (Mar 10 2021 at 16:17):

Camelid said:

I don't see any open PR with S-inactive and only one closed PR with S-inactive.

going to switch this to S-inactive-closed

view this post on Zulip Noah Lev (Mar 10 2021 at 16:18):

I feel like we have too many S- labels, which can be confusing

view this post on Zulip DPC (Mar 10 2021 at 16:18):

there's already s-inactive-closed iirc

view this post on Zulip Joshua Nelson (Mar 10 2021 at 16:18):

and removed the inactive label

view this post on Zulip DPC (Mar 10 2021 at 16:18):

well yeah but there are different states of PRs which we often use similar labels for

view this post on Zulip DPC (Mar 10 2021 at 16:19):

example if a author needs help, i think we should create a s-needs-help or similar

view this post on Zulip Noah Lev (Mar 10 2021 at 16:19):

DPC said:

example if a author needs help, i think we should create a s-needs-help or similar

I view that as S-waiting-on-review.

view this post on Zulip DPC (Mar 10 2021 at 16:19):

it's not the same though

view this post on Zulip Charles Lew (Mar 10 2021 at 16:20):

But the single reviewer is sometimes busy.

view this post on Zulip Noah Lev (Mar 10 2021 at 16:20):

E.g., if my PR was waiting-on-author and I'm unable to e.g. resolve reviewer comments I'll add waiting-on-review.

view this post on Zulip DPC (Mar 10 2021 at 16:20):

it's not about just being busy

view this post on Zulip Joshua Nelson (Mar 10 2021 at 16:20):

the difference IMO is that someone other than the reviewer can help

view this post on Zulip DPC (Mar 10 2021 at 16:20):

but often a reviewer is waiting for the author to make changes

view this post on Zulip Noah Lev (Mar 10 2021 at 16:20):

Hmm, I see.

view this post on Zulip Joshua Nelson (Mar 10 2021 at 16:20):

"reviewer" means you have to be comfortable signing off on the change, anyone can just give help

view this post on Zulip DPC (Mar 10 2021 at 16:20):

and if author needs help to make those changes

view this post on Zulip DPC (Mar 10 2021 at 16:21):

reviewer wouldn't know, and think that the pr is actually waiting on the author rather than a review

view this post on Zulip DPC (Mar 10 2021 at 16:21):

so you end up in a cycle of inactiviy

view this post on Zulip Noah Lev (Mar 10 2021 at 16:21):

wrt s-blocked it looks like there are only 30 open blocked PRs, which I think is much smaller than when I last checked. So it should be easier to triage now.

view this post on Zulip Joshua Nelson (Mar 10 2021 at 16:22):

Camelid said:

And add S-blocked-closed I guess?

this label already exists, but I don't understand how it's used - e.g. https://github.com/rust-lang/rust/pull/75298 is marked blocked-closed but it's not blocked on anything, it's just that the new API was rejected

view this post on Zulip DPC (Mar 10 2021 at 16:22):

i think it's just the lack of labels

view this post on Zulip Noah Lev (Mar 10 2021 at 16:22):

this label already exists, but I don't understand how it's used

I know it already exists, I meant apply it to the PR.

view this post on Zulip DPC (Mar 10 2021 at 16:22):

well we probably don't need a label for closed prs

view this post on Zulip DPC (Mar 10 2021 at 16:23):

other than the ones that are closed because they are inactive or blocked

view this post on Zulip Joshua Nelson (Mar 10 2021 at 16:23):

yeah IMO we should just merge S-blocked and S-blocked-closed into the same label

view this post on Zulip DPC (Mar 10 2021 at 16:23):

since they can be "recycled" and people can re-work those prs if needed

view this post on Zulip Joshua Nelson (Mar 10 2021 at 16:23):

you can filter for closed PRs automatically

view this post on Zulip Noah Lev (Mar 10 2021 at 16:23):

(And S-inactive and S-inactive-closed.)

view this post on Zulip DPC (Mar 10 2021 at 16:23):

yeh the -closed part is redundant

view this post on Zulip DPC (Mar 10 2021 at 16:23):

moving on -

view this post on Zulip Noah Lev (Mar 10 2021 at 16:24):

For whoever merges the labels: Make sure to change every blocked-closed (and same for inactive-closed -> inactive) to blocked before you remove the label.

view this post on Zulip DPC (Mar 10 2021 at 16:24):

2nd point of discuss today is - soon we might have a dashboard which might make it easier to triage prs

view this post on Zulip Noah Lev (Mar 10 2021 at 16:24):

(Otherwise we'll lose the label forever :scared: )

view this post on Zulip Joshua Nelson (Mar 10 2021 at 16:24):

Camelid said:

For whoever merges the labels: Make sure to change every blocked-closed (and same for inactive-closed -> inactive) to blocked before you remove the label.

I can do this in a few minutes

view this post on Zulip DPC (Mar 10 2021 at 16:25):

for those interested you can follow the discussion here - https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Triage.20PR.20dashboard

view this post on Zulip Noah Lev (Mar 10 2021 at 16:25):

Joshua Nelson said:

Camelid said:

For whoever merges the labels: Make sure to change every blocked-closed (and same for inactive-closed -> inactive) to blocked before you remove the label.

I can do this in a few minutes

FYI, that's probably 350 PRs, you might want to automate :)

view this post on Zulip Noah Lev (Mar 10 2021 at 16:25):

DPC said:

for those interested you can follow the discussion here - https://rust-lang.zulipchat.com/#narrow/stream/242791-t-infra/topic/Triage.20PR.20dashboard

I'm intrigued, will definitely look at that!

view this post on Zulip DPC (Mar 10 2021 at 16:26):

the pr is merged with triagebot, but the dashboard isn't available yet

view this post on Zulip Noah Lev (Mar 10 2021 at 16:26):

For a while I've been thinking of writing a script that helps me with triage but a dashboard seems quite nice.

view this post on Zulip Joshua Nelson (Mar 10 2021 at 16:26):

Camelid said:

FYI, that's probably 350 PRs, you might want to automate :)

github lets me change up to 25 at once through the ui: image.png

view this post on Zulip DPC (Mar 10 2021 at 16:26):

it will be hosted here when ready: https://triage.rust-lang.org/triage/rust-lang/rust

view this post on Zulip Noah Lev (Mar 10 2021 at 16:26):

Joshua Nelson said:

Camelid said:

FYI, that's probably 350 PRs, you might want to automate :)

github lets me change up to 25 at once through the ui: image.png

Ah, I forgot!

view this post on Zulip DPC (Mar 10 2021 at 16:28):

the person who created the dashboard, created a temporary one that they hosted so you can see it here, but i would recommend waiting till it lands on triagebot to use it: https://toriage.herokuapp.com/pulls/rust-lang/rust

view this post on Zulip Noah Lev (Mar 10 2021 at 16:29):

Theirs looks like this:

image.png

view this post on Zulip Joshua Nelson (Mar 10 2021 at 16:29):

Camelid said:

(And S-inactive and S-inactive-closed.)

there is no S-inactive label anymore - do you want me to rename inactive-closed to inactive?

view this post on Zulip Noah Lev (Mar 10 2021 at 16:29):

Joshua Nelson said:

Camelid said:

(And S-inactive and S-inactive-closed.)

there is no S-inactive label anymore - do you want me to rename inactive-closed to inactive?

I think so. What do you all think?

view this post on Zulip DPC (Mar 10 2021 at 16:29):

yeh s-inactive should be fine

view this post on Zulip Noah Lev (Mar 10 2021 at 16:30):

It looks like the dashboard shows draft PRs too.

view this post on Zulip Noah Lev (Mar 10 2021 at 16:30):

Is the triagebot one the same, just as part of triagebot?

view this post on Zulip Joshua Nelson (Mar 10 2021 at 16:30):

DPC said:

yeh s-inactive should be fine

done

view this post on Zulip DPC (Mar 10 2021 at 16:30):

yeh it's going to be migrated with some minor changes

view this post on Zulip DPC (Mar 10 2021 at 16:31):

i guess it's already done just the link isn't active yet for some reason

view this post on Zulip Noah Lev (Mar 10 2021 at 16:31):

Some weird configuration glitch probably.

view this post on Zulip Noah Lev (Mar 10 2021 at 16:31):

This is the PR that added if anyone's curious: triagebot#1223

view this post on Zulip DPC (Mar 10 2021 at 16:31):

last thing to discuss as we are almost out of time - is that timezones are shifting again - but the scheduled meeting is pinned to UTC time so shouldn't be a problem

view this post on Zulip DPC (Mar 10 2021 at 16:32):

in case you end up getting a calendar notification an hour earlier or later because calendar invites can often trip up :joy:

view this post on Zulip DPC (Mar 10 2021 at 16:33):

next meeting will be at

view this post on Zulip DPC (Mar 10 2021 at 16:33):

@triagebot end-meeting

view this post on Zulip triagebot (Mar 10 2021 at 16:33):

Does anyone have something to bring up?
React with :working_on_it: if you have something to say.
React with :all_good: if you're ready to end the meeting.

view this post on Zulip Noah Lev (Mar 10 2021 at 16:33):

(Huh, why didn't triagebot react itself? Must have been changed.)

view this post on Zulip DPC (Mar 10 2021 at 16:33):

it does for me

view this post on Zulip Noah Lev (Mar 10 2021 at 16:34):

DPC said:

it does for me

Yep, I refreshed and it works. Zulip glitch I guess.

view this post on Zulip DPC (Mar 10 2021 at 16:34):

that should be it for this meeting then. Thank you for the work and see you at the next meeting. Stay safe

view this post on Zulip DPC (Mar 10 2021 at 16:36):

sadly google calendar aligns it with local time - but i've changed the calendar note to reflect the proper time (you won't get a mail for it )

view this post on Zulip Noah Lev (Mar 10 2021 at 16:37):

I don't think I'm on the calendar actually.

view this post on Zulip Noah Lev (Mar 10 2021 at 16:37):

But I track it manually, so it's fine.

view this post on Zulip Noah Lev (Mar 10 2021 at 16:37):

See you next time!

view this post on Zulip DPC (Mar 10 2021 at 16:45):

just a reminder: if anyone wants to add anything for next month's meeting you can do so here: https://hackmd.io/@WBoc7VSWSL2YD7Wa3VKoKw/B1FWyd4_8


Last updated: Jan 29 2022 at 09:28 UTC