Stream: t-release/triage

Topic: Label switching for outsiders is hard


view this post on Zulip Charles Lew (Sep 05 2020 at 03:50):

https://github.com/rust-lang/rust/pull/73971#issuecomment-687250207

view this post on Zulip Charles Lew (Sep 05 2020 at 03:50):

:(

view this post on Zulip DPC (Sep 05 2020 at 12:52):

i agree switching is difficult, I wonder if we could add some notes to the automated bors message on how to switch labels after pushing

view this post on Zulip Joshua Nelson (Sep 05 2020 at 12:56):

That's a really strange pr though :sweat_smile:

view this post on Zulip Joshua Nelson (Sep 05 2020 at 12:56):

(deleted)

view this post on Zulip Joshua Nelson (Sep 05 2020 at 12:56):

It looks like they just kept adding more changes after the PR was approved

view this post on Zulip DPC (Sep 05 2020 at 12:57):

there were conflicts as well, so the label wasn't wrong for the entire duration (authors don't know that reviewers often wait for conflicts to be resolved before reviewing them, so i guess that's another point for us on the process improvement )

view this post on Zulip Joshua Nelson (Sep 06 2020 at 12:16):

DPC said:

i agree switching is difficult, I wonder if we could add some notes to the automated bors message on how to switch labels after pushing

this seems easy enough to add, I think it's highfive that comments though

view this post on Zulip Joshua Nelson (Sep 06 2020 at 12:16):

https://github.com/rust-lang/highfive/

view this post on Zulip DPC (Sep 06 2020 at 12:55):

that's the reviewer assignment. was referring to the conflicts message

view this post on Zulip Noah Lev (Sep 06 2020 at 18:14):

DPC said:

there were conflicts as well, so the label wasn't wrong for the entire duration (authors don't know that reviewers often wait for conflicts to be resolved before reviewing them, so i guess that's another point for us on the process improvement )

Perhaps bors could add something to its merge conflicts message that notes that reviewers likely won't review until conflicts are resolved? By the way, where is the bors source code? I found github.com/graydon/bors, but it doesn't seem to have the merge conflicts message in bors.py

view this post on Zulip Noah Lev (Sep 06 2020 at 18:21):

Ah, I found it: it's github.com/rust-lang/homu

view this post on Zulip Noah Lev (Sep 06 2020 at 18:31):

@DPC Okay, opened rust-lang/homu#101

view this post on Zulip DPC (Sep 06 2020 at 19:14):

thnks

view this post on Zulip DPC (Sep 06 2020 at 21:49):

@Camelid can you add a note on how to change the labels using rustbot once the conflicts are resolved?

view this post on Zulip Noah Lev (Sep 06 2020 at 23:00):

@DPC Done!

view this post on Zulip Joshua Nelson (Sep 07 2020 at 22:15):

opened an issue for this, @Camelid's PR (thanks!) only shows it for rebase conflicts: https://github.com/rust-lang/rustc-dev-guide/issues/855

view this post on Zulip Noah Lev (Sep 14 2020 at 00:54):

I just saw this in my notifications, which was a pleasant surprise:

image.png

view this post on Zulip Vadim Petrochenkov (Sep 30 2020 at 18:03):

Note that reviewers usually do not review pull requests until merge conflicts are resolved

It would be much closer to the truth to shorten this to just "Note that reviewers usually do not review".
Merge conflicts play secondary role in that.


Last updated: Jan 26 2022 at 14:02 UTC