Stream: t-release/triage

Topic: 2021-04-26 to 05-02


view this post on Zulip John Simon (Apr 26 2021 at 05:41):

S-waiting-on-author
pinged:
#81404 opened on Jan 25 - osa1 commented on Mar 21 - merge conflict
#80080 opened on Dec 16, 2020 by rylev • Approved updated 17 days ago - finished-final-comment-period - merge conflict
#80460 opened on Dec 28, 2020 by calebsander last commented 16 days ago - pinged author for future plans
#83660 opened 27 days ago by simonvandel last commented 16 days ago - merge conflict
#82185 opened on Feb 16 by SkiFire13 - last commented commented 16 days ago - pinged for feedback
#83614 opened 28 days ago by jessehorne updated 17 days ago - back to author to address merge conflict
#83857 opened 21 days ago by ABouttefeux last updated 16 days ago - assigned back to author

not pinged:
#82039 opened on Feb 12 untouched since feb 12
#82805 opened on Mar 5 by ojeda last updated 17 days ago - already been pinged enough
#83251 opened on Mar 17 by estebank last commented on Mar 22
#83354 opened on Mar 21 by petrochenkov updated 15 days ago - merge conflicts etc
#83719 opened 25 days ago by Aaron1011 last commented 25 days ago - broken build

S-waiting-on-review
joshtriplett
#83983 opened 18 days ago by ibraheemdev updated 18 days ago

michaelwoerister
#83214 opened on Mar 16 by cjgillot updated 18 days ago

dtolnay
#83770 opened 24 days ago by the8472 updated 17 days ago

kennytm
#83614 opened 28 days ago by jessehorne updated 17 days ago

kodraus
#82576 opened on Feb 26 by gilescope updated 17 days ago

sfackler
#83233 opened on Mar 17 by jethrogb updated 17 days ago
#82413 opened on Feb 22 by LukasKalbertodt updated 15 days ago - not sure what to do with this one, assign to author or continue review

matthewjasper
#83401 opened on Mar 22 by fee1-dead updated 17 days ago
#84045 opened 16 days ago by workingjubilee updated 16 days ago

oli-obk
#83423 opened on Mar 23 by erikdesjardins updated 17 days ago

view this post on Zulip Noah Lev (Apr 30 2021 at 03:11):

S-waiting-on-author

#82459 18 days - waiting on addressing small review comment; author GitHub status says that they're taking a break; didn't ping - author: tesuji, assignee: nagisa
#75737 Mar 8 - has merge conflicts; didn't ping (last ping was Mar 8) - author: davidtwco, assignee: oli-obk
#81366 Mar 25 - has merge conflicts; didn't ping (last ping was Mar 25) - author: estebank, assignee: oli-obk
#80918 Mar 26 - author is out of office until mid-June - author: yoshuawuyts, assignee: m-ou-se
#71482 Mar 27 - has lots of merge conflicts - author: estebank, assignee: joshtriplett

S-waiting-on-review

#82948 Mar 9 - seems to be waiting on decision about whether this change should be accepted - author: camsteffen, assignee: sfackler
#82762 Mar 26 - waiting on review - author: klensy, assignee: bjorn3
#84083 18 days - waiting on review - author: ltratt, assignee: joshtriplett
#77325 17 days - waiting on review - author: ishitatsuyuki, assignee: jackh726

view this post on Zulip Charles Lew (May 01 2021 at 08:00):

Apr 30, 2021, Friday
S-waiting-on-author
https://github.com/rust-lang/rust/pull/82719 Pinged
https://github.com/rust-lang/rust/pull/79850 Assigned S-waiting-on-team
https://github.com/rust-lang/rust/pull/76098 Pinged
https://github.com/rust-lang/rust/pull/83496 Pinged
https://github.com/rust-lang/rust/pull/83397 Pinged
https://github.com/rust-lang/rust/pull/83913 author: Aaron1011, pinged
https://github.com/rust-lang/rust/pull/76894 author: ecstatic-morse, fcp passed, failed in rollup. needs investigation. idle since Feb 28.

S-waiting-on-review
https://github.com/rust-lang/rust/pull/84221 reviewer: estebank, idle for 16 days.
https://github.com/rust-lang/rust/pull/83927 reviewer: joshtriplett, label=O-SGX, idle for 25 days.
https://github.com/rust-lang/rust/pull/84017 reviewer: ollie27, label=T-rustdoc, idle for 16 days.
https://github.com/rust-lang/rust/pull/79930 reviewer:m-ou-se, label=T-libs-impl, idle for 17 days.
https://github.com/rust-lang/rust/pull/83791 reviewer:m-ou-se, label=T-libs, idle for 17 days.

view this post on Zulip Joshua Nelson (May 03 2021 at 21:06):

@Charles Lew can you ping me if you see a PR assigned to ollie that hasn't been reviewed for 15 days? they tend to review in spurts a few months apart and usually I can manage to get a review in before then.

view this post on Zulip John Simon (May 04 2021 at 07:22):

sorry, slammed for time was only able to complete half of the set of 15 days and older
S-waiting-on-author
pinged:
#79173 opened on Nov 18, 2020 by DeveloperC286 last updated 18 days ago - seems to be continuously working on this, I thought they'd only be working on this in a private branch instead of a PR? this has been around for months.
#83016 opened on Mar 11 by JohnBSmith last commented on Mar 12 - closed as inactive, only a single comment from author
#79830 opened on Dec 8, 2020 by 4ldas last commented on Mar 26

not pinged - usually a rust team member
#83775 opened on Apr 2 by jyn514 last updated 18 days ago
#80347 opened on Dec 24, 2020 by cjgillot last committed on Mar 17
#78991 opened on Nov 12, 2020 by Aaron1011 last commented on Dec 28, 2020 •
#78781 opened on Nov 5, 2020 by eddyb • Approved updated 17 days ago
#81797 opened on Feb 5 by yoshuawuyts updated 17 days ago - listed as OOO until 2nd week of judgement
#84229 opened 18 days ago by Aaron1011 updated 18 days ago

S-waiting-on-review
estebank
#84262 opened 17 days ago by camelid updated 17 days ago
#83739 opened on Mar 31 by JohnTitor updated 17 days ago
#82985 opened on Mar 10 by cjgillot updated 17 days ago
#83724 opened on Mar 31 by Sycration updated 17 days ago
kramertj
#81363 opened on Jan 24 by jonhoo updated 17 days ago
joshtriplett
#72321 opened on May 18, 2020 by dvdhrm updated 17 days ago - been waiting in joshtriplett's review pile since Aug 25, 2020!! - another reviewer?
#83706 opened on Mar 31 by a1phyr updated 17 days ago
sfackler
#83646 opened on Mar 29 by glittershark updated 17 days ago
eddyb
#83725 opened on Mar 31 by klensy updated 17 days ago

view this post on Zulip Charles Lew (May 04 2021 at 08:54):

@Joshua Nelson Sure, do you want to be pinged from Zulip or github?

view this post on Zulip Joshua Nelson (May 04 2021 at 12:26):

@Charles Lew zulip works :)

view this post on Zulip Joshua Nelson (May 04 2021 at 12:27):

Or you can just assign the PR to me on github, that might be easier

view this post on Zulip DPC (May 04 2021 at 15:29):

i'd discussed with GG once about it (asking whether i should reassign ollie's inactive prs to them) but they told me not to

view this post on Zulip Joshua Nelson (May 04 2021 at 15:52):

:shrug: I don't think it helps to have the PR open for ages - @GuillaumeGomez do you have any objection to me reviewing PRs that ollie doesn't have time for?

view this post on Zulip GuillaumeGomez (May 04 2021 at 16:35):

No problem, go ahead and thanks!

view this post on Zulip DPC (May 04 2021 at 16:41):

yeah i know :stuck_out_tongue:


Last updated: Jan 26 2022 at 13:21 UTC