Stream: t-release/triage

Topic: 2021-04-19 to 04-25


view this post on Zulip John Simon (Apr 19 2021 at 00:19):

S-waiting-on-author
pinged:
#79341 opened on Nov 23, 2020 by Nemo157 - last updated Feb 24 - merge conflicts
#83205 opened on Mar 16 by b-naber commented 28 days ago - pinged for merge conflicts
#83536 opened 23 days ago by camelid - back to author to address merge conflict
#82037 opened on Feb 12 by calavera - calavera last commented on Mar 3, merge conflict from 16 days ago - pinged
#83748 opened 17 days ago by slerpyyy updated 16 days ago - looks like still in draft because of the conversation, assigned back to author

not pinged:
#83234 opened on Mar 17 by oli-obk updated 17 days ago
#83519 opened 23 days ago by oli-obk last 20 days ago - merge conflict

S-waiting-on-review
nikomatsakis
#83647 opened 20 days ago by lcnr updated 17 days ago
#83205 opened on Mar 16 by b-naber updated 16 days ago

kodraus
#82858 opened on Mar 7 by LinkTed updated 17 days ago
#83264 opened on Mar 18 by jendrikw updated 16 days ago - not sure if this is waiting on more feedback from author needs reviewing

joshtriplett
#83515 opened 23 days ago by tamird updated 17 days ago
#83752 opened 17 days ago by tspiteri updated 16 days ago
#83748 opened 17 days ago by slerpyyy updated 16 days ago

estebank
#83729 opened 18 days ago by JohnTitor • Approved updated 17 days ago - already has approval, looks looks ready to merge
#76808 opened on Sep 16, 2020 by LeSeulArtichaut updated 16 days ago
#83722 opened 18 days ago by jyn514 updated 16 days ago - not sure what the status of this is

tmandry
#80182 opened on Dec 19, 2020 by in42 • Approved updated 16 days ago - already has approval, looks looks ready to merge

sfackler
#83772 opened 17 days ago by jhpratt updated 16 days ago - still waiting on review

Needs reviewer
#83653 opened 20 days ago by jyn514 updated 17 days ago

view this post on Zulip Yuki Okushi (Apr 19 2021 at 03:20):

Re-assigned the PRs that were assigned to Ashley(kodraus) since they're leaving the libs team (and I assume they don't have time to review anyway)

view this post on Zulip Joshua Nelson (Apr 19 2021 at 03:48):

#83722 is still waiting on review.

view this post on Zulip Joshua Nelson (Apr 19 2021 at 03:49):

I think Zoxc is a good reviewer for #83653, they're just not in the rust org

view this post on Zulip Noah Lev (Apr 23 2021 at 03:51):

S-waiting-on-author

#81360 Mar 18 - looks like it needs docs and maybe a lint; also has conflicts - author: Aaron1011, assignee: lcnr
#79816 Mar 19 - author needs to address review; skipped ping because we pinged 18 days ago, which felt too recent - author: poliorcetics, assignee: jyn514
#75414 Feb 2 - has conflicts - author: davidtwco, assignee: oli-obk

S-waiting-on-review

#82558 Mar 18 - waiting on review - author: oli-obk, assignee: nikomatsakis
#81864 Mar 19 - seems to be waiting on response from reviewer - author: ijackson, assignee: sfackler
#83319 Mar 20 - waiting on initial review - author: tmiasko, assignee: estebank

view this post on Zulip Joshua Nelson (Apr 23 2021 at 03:53):

#79816 Mar 19 - author needs to address review; skipped ping because we pinged 18 days ago, which felt too recent - author: poliorcetics, assignee: jyn514

I'm thinking of closing this :/ it's been a month since the last update

view this post on Zulip DPC (Apr 23 2021 at 09:49):

i would go ahead and close it :stuck_out_tongue:

view this post on Zulip Charles Lew (Apr 23 2021 at 14:42):

S-waiting-on-author
https://github.com/rust-lang/rust/pull/73314 author: GuillaumeGomez field: T-rustdoc merge conflict
https://github.com/rust-lang/rust/pull/83909 author: Dylan-DPC field: T-libs merge conflict
https://github.com/rust-lang/rust/pull/81601 author: jyn514 field: A-rustbuild ci failed
https://github.com/rust-lang/rust/pull/80822 author: Aaron1011 field: A-layout merge conflict, idle since Jan 9

S-waiting-on-review
https://github.com/rust-lang/rust/pull/75522 reviewer: ollie27 field:T-rustdoc seems need fcp
https://github.com/rust-lang/rust/pull/83608 reviewer: sfackler field:T-libs idle for 18 days
https://github.com/rust-lang/rust/pull/83786 reviewer: kennytm field:T-libs idle for 19 days
https://github.com/rust-lang/rust/pull/82776 reviewer: GuillaumeGomez field:T-rustdoc idle for 16 days
https://github.com/rust-lang/rust/pull/83322 reviewer: michaelwoerister field:T-compiler idle for 17 days
https://github.com/rust-lang/rust/pull/83576 reviewer: joshtriplett field:T-libs idle for 18 days
https://github.com/rust-lang/rust/pull/75644 reviewer: dtolnay field:T-libs idle for 18 days
https://github.com/rust-lang/rust/pull/82069 author:Aaron1011 reviewer: estebank field:A-diagnostics author insist on review before fixing ci, idle for 19 days
https://github.com/rust-lang/rust/pull/83850 reviewer:nikomatsakis field:T-lang idle for 18 days
https://github.com/rust-lang/rust/pull/83433 reviewer:Mark-Simulacrum field:A-rustbuild idle for 17 days
https://github.com/rust-lang/rust/pull/83342 reviewer:sfackler field:T-libs O-windows idle for 24 days

view this post on Zulip Joshua Nelson (Apr 23 2021 at 14:47):

https://github.com/rust-lang/rust/pull/81601 author: jyn514 field: A-rustbuild ci failed

I would really like to get this working but I have no way of testing it locally :(

view this post on Zulip Joshua Nelson (Apr 23 2021 at 14:47):

my only current idea is "stare at the python code really hard and figure out how it's different from the rust"


Last updated: Jan 26 2022 at 14:20 UTC