Stream: t-release/triage

Topic: 2021-04-12 to 04-19


view this post on Zulip John Simon (Apr 12 2021 at 05:16):

S-waiting-on-author
not pinged:
#75737 opened on Aug 20, 2020 by davidtwco • Approved last updated Jan 14 - already has approval but hasn't been touched in a long while...
#81366 opened on Jan 24 by estebank updated Feb 25 - conflicts, not touched in a while
#80918 opened on Jan 11 by yoshuawuyts updated 16 days ago yoshuawuyts commented "Hey! Yeah sorry, I've been out for the past month"
#71482 opened on Apr 23, 2020 by estebank last updated on Apr 23, 2020 - merge conflicts, but rust team member so not pinging

pinged:
#82459 opened on Feb 23 by tesuji - updated Feb 24 - author lists status as "Gonna rest for a long time. Please pick up my PRs if I don't respond in a month."
#82272 opened on Feb 18 by b-naber last updated Mar 8 - merge conflict
#82324 opened on Feb 20 by eltociear - updated on Feb 20 - closed inactive - all this for a spelling typo?
#83496 opened 17 days ago by Aehmlo updated 17 days ago - joshtriplett commented 16 days ago: "This should not be insta-stable. It should be marked as unstable, with a tracking issue and a feature gate." - not sure about the process here - is this something for the author to do?
#82659 opened on Mar 1 by zesterer updated on Mar 3 - pinged for additional status
#79173 opened on Nov 18, 2020 by DeveloperC286 updated 23 days ago - pinged to fix additional merge conflict

S-waiting-on-review
Mark-Simulacrum
#83438 opened 19 days ago by CDirkx updated 17 days ago - moved to reviewer - CDirkx commented 17 days ago - Merge conflict has been resolved.

nikic
#83425 opened 19 days ago by durin42 updated 18 days ago - untouched by reviewer

kodraus
#82300 opened on Feb 19 by andersk kodraus last commented on Feb 21

nikomatsakis
#77325 opened on Sep 28, 2020 by ishitatsuyuki - nikomatsakis last commented on Dec 13, 2020

sfackler
#82948 opened on Mar 9 by camsteffen sfackler last commented on Mar 9

bjorn3
#82762 opened on Mar 4 by klensy - bjorn3 last commented on Mar 4

sfackler
#83581 opened 15 days ago by arennow - sfackler last updated 15 days ago - seems to have stalled?

view this post on Zulip Joshua Nelson (Apr 12 2021 at 08:18):

This should not be insta stable

Yes, this is something for the author to do - they need to update the feature gate and open a tracking issue.

view this post on Zulip Noah Lev (Apr 12 2021 at 19:36):

#82324 opened on Feb 20 by eltociear - updated on Feb 20 - closed inactive - all this for a spelling typo?

I opened a replacement PR to fix the typo: #84141

view this post on Zulip Joel Palmer (Apr 13 2021 at 17:05):

Waiting on review:

add the bool::not method. S-waiting-on-review T-libs #82786 opened on Mar 4 by Lokathor updated 16 days ago and assigned to @m-ou-se

Remove P: Unpin bound on impl Future for Pin A-async-await A-pin S-waiting-on-review T-libs #81363 opened on Jan 24 by jonhoo updated 16 days ago and assigned to @cramertj

rustdoc: links from items in a trait impl are inconsistent S-waiting-on-review T-rustdoc #83068 opened on Mar 12 by mockersf updated 16 days ago and assigned to @GuillaumeGomez

test/codegen: add UEFI cross-compilation test A-cross A-testsuite O-UEFI S-waiting-on-review #72321 opened on May 18, 2020 by dvdhrm updated 15 days ago and assigned to @joshtriplett

Allow deriving Into for primitive enums S-waiting-on-review S-waiting-on-team T-lang T-libs #81642 opened on Feb 1 by illicitonion updated 15 days ago and assigned to @estebank

Move std::sys_common::alloc to new module std::sys::common S-waiting-on-review T-libs-impl #82492 opened on Feb 24 by CDirkx updated 15 days ago and assigned to @m-ou-se

Add support for powerpc64le-unknown-freebsd S-waiting-on-review #83572 opened 17 days ago and assigned to by pkubaj updated 15 days ago and assigned to @estebank

Recover from if (let ...) in parsing, instead of lowering S-waiting-on-review #83407 opened 21 days ago and assigned to by osa1 updated 15 days ago and assigned to @estebank

Add u8::to_digit method S-waiting-on-review #83447 opened 20 days ago and assigned to by coolreader18 updated 15 days ago and assigned to @kennytm

view this post on Zulip Charles Lew (Apr 16 2021 at 18:15):

Had been a little busy with others things today and will do triage work tomorrow.

view this post on Zulip DPC (Apr 16 2021 at 21:32):

Charles Lew said:

Had been a little busy with others things today and will do triage work tomorrow.

it is okay, if you wish to skip this week, that's totally fine

view this post on Zulip Charles Lew (Apr 17 2021 at 03:35):

Friday, Apr 16th, 2021 (actually 17th now)
S-waiting-on-author
https://github.com/rust-lang/rust/pull/81197 Author: jyn514, passes pr ci, fails bors on windows ci. Idle for 20 days.
https://github.com/rust-lang/rust/pull/78991 Author: Aaron1011. Unblocked work since Feb 23, needs picking up again.
https://github.com/rust-lang/rust/pull/83596 Author: jyn514. needs address reviews and resolve merge conflict. Idle for 20 days.
https://github.com/rust-lang/rust/pull/78781 Author: eddyb. needs resolve merge conflict and address comments. Idle since unblock 16 days.
https://github.com/rust-lang/rust/pull/82496 Author: GuillaumeGomez. CI red. Idle for 16 days.
https://github.com/rust-lang/rust/pull/78681 Author: m-ou-se. merge conflict since feb 1.

S-waiting-on-review
https://github.com/rust-lang/rust/pull/81363 Reviewer: cramertj, idle since Feb 6.
https://github.com/rust-lang/rust/pull/72321 Reviewer: joshtriplett, idle since Aug 25 2020.
https://github.com/rust-lang/rust/pull/83646 Reviewer: sfackler, idle for 18 days.
https://github.com/rust-lang/rust/pull/83610 Reviewer: matthewjasper, idle for 17 days.
https://github.com/rust-lang/rust/pull/83706 Reviewer: joshtriplett, idle for 16 days.
https://github.com/rust-lang/rust/pull/83739 Reviewer: estebank, idle for 16 days.
https://github.com/rust-lang/rust/pull/82985 Reviewer: estebank, idle for 16 days.
https://github.com/rust-lang/rust/pull/83724 Reviewer: estebank, idle for 16 days.
https://github.com/rust-lang/rust/pull/83725 Reviewer: eddyb, idle for 16 days.
https://github.com/rust-lang/rust/pull/82973 Reviewer: kennytm, idle since Mar 17.
https://github.com/rust-lang/rust/pull/80269 Reviewer: dtolnay, idle for 16 days after changing reviewer.
https://github.com/rust-lang/rust/pull/81156 Reviewer: sfackler, idle for 16 days after changing reviewer.


Last updated: Jan 26 2022 at 14:20 UTC