Stream: t-release/triage

Topic: 2021-03-29 to 04-04


view this post on Zulip DPC (Mar 29 2021 at 00:11):

Triage report for the week starting 29.03

view this post on Zulip John Simon (Mar 29 2021 at 08:39):

S-waiting-on-author
pinged:
#81950 opened on Feb 9 by henryboisdequin updated 17 days ago - pinged to address author feedback
#79001 opened on Nov 12, 2020 by de-vri-es updated 17 days ago
#83076 opened 16 days ago by eltociear updated 16 days ago - pinged for broken build + review
#82331 opened on Feb 20 by frol • Changes requested updated 16 days ago - waiting on feedback from dtolnay, but this might be closed...
#82343 opened on Feb 20 by Plecra updated 17 days ago - merge conflict
#81988 opened on Feb 10 by jyn514 updated 17 days ago - merge conflict

not pinged:
#81797 opened on Feb 5 by yoshuawuyts updated 17 days ago - broken build
#79659 opened on Dec 3, 2020 by matklad updated 17 days ago - idle for a month
#78991 opened on Nov 12, 2020 by Aaron1011 updated 17 days ago
#78370 opened on Oct 25, 2020 by taiki-e updated 17 days ago - untouched by author since october :(
#81174 opened on Jan 18 by Aaron1011 updated 17 days ago - still has conflicts

S-waiting-on-review
GuillaumeGomez
#82864 opened 22 days ago by jyn514 updated 18 days ago - GuillaumeGomez commented 18 days ago "Apparently it's "close" to getting merge. If there's still no update in a week, let's maybe ask Mark-Simulacrum directly about it. :)" - still waiting

Mark-Simulacrum
#83015 opened 18 days ago by hyd-dev updated 18 days ago

pnkfelix
#82037 opened on Feb 12 by calavera updated 18 days ago - pnkfelix commented 18 days ago - no other movement

calebcartwright
#82208 opened on Feb 16 by jyn514 updated 17 days ago

KodrAus
#83016 opened 18 days ago by JohnBSmith updated 17 days ago

estebank
#81642 opened on Feb 1 by illicitonion updated 17 days ago - estebank last commented on Feb 2 - looks like this is stalled

joshtriplett
#72321 opened on May 18, 2020 by dvdhrm updated 17 days ago - Mark-Simulacrum assigned this to joshtriplett on Aug 25, 2020 ... maybe another reviewer?

sfackler
#82492 opened on Feb 24 by CDirkx updated 17 days ago - rust-highfive assigned sfackler on Feb 24

view this post on Zulip Joshua Nelson (Mar 29 2021 at 16:34):

The PR #82864 was blocked on has been merged, I queued a perf run.

view this post on Zulip bstrie (Mar 31 2021 at 20:29):

so for things where no action needs to be taken, the procedure is just to remove the tag and then re-add it so that it refreshes the "updated since" date?

view this post on Zulip bstrie (Mar 31 2021 at 20:29):

is there a script that people use or is this by hand?

view this post on Zulip DPC (Mar 31 2021 at 20:33):

by hand i think

view this post on Zulip DPC (Mar 31 2021 at 20:33):

you could put rustbot command in an auto-reply and do it that way if you want to do it faster

view this post on Zulip DPC (Mar 31 2021 at 20:33):

or use shortcut L for labels

view this post on Zulip bstrie (Mar 31 2021 at 20:43):

for the "days since last activity" field, what is being measured? if I assign someone new, does that count as zero days since last activity?

view this post on Zulip bstrie (Mar 31 2021 at 21:28):

waiting-on-review

#81641 by bjorn3, assigned matthewjasper - Feb 1 - never reviewed
#81619 by SkiFire13, assigned joshtriplett - Feb 1 - reviewed but not by assignee
#79943 by mqudsi, assigned m-ou-se - 19 days - never reviewed

#81156 by DrMeepster, assigned sfackler - 19 days - never reviewed, new reviewer assigned
#83129 by LeSeulArtichaut, assigned nikomatsakis - 17 days - never reviewed
#80269 by pickfire, assigned KodrAus - 16 days - never reviewed
#83161 by jyn514, assigned matthewjasper - 16 days - never reviewed
#82703 by iago-lito, assigned m-ou-se - 22 days - under discussion
#80965 by camelid, assigned Manishearth - 16 days - waiting for new review after revision
#80828 by SNCPlay42, assigned matthewjasper - 15 days - never reviewed
#82322 by scottmcm - 15 days - crater PR, can probably be closed
#82985 by cjgilliov, assigned estebank - 20 days - never reviewed
#82973 by Jackson, assigned kennytm - 15 days - under discussion
#82907 by petrochenkov, assigned matthewjasper - 15 days - lightly discussed

S-waiting-on-author

#81863 by Aaron1011, assigned none - 16 days - merge conflicts
#82375 by lolgeny, assigned sfackler - Feb 21 - changes requested
#82496 by GuillaumeGomez, assigned jyn514 - Feb 26 - failing tests
#76098 by class, assigned KodrAus - Feb 28 - failing tests
#78681 by m-ou-se, assigned KodrAus - Jan 16 - merge conflicts
#78781 by eddyb, assigned oli-obk - Jan 29 - merge conflicts

view this post on Zulip DPC (Mar 31 2021 at 21:33):

bstrie said:

for the "days since last activity" field, what is being measured? if I assign someone new, does that count as zero days since last activity?

unfortunately, yes. Since we are using github's filters and github considers removing filters, or changing assignment as the "last update".

view this post on Zulip Joshua Nelson (Mar 31 2021 at 21:34):

#83161 by jyn514, assigned matthewjasper - 16 days - never reviewed

This was merged as part of https://github.com/rust-lang/rust/pull/83185.

#80965 by camelid, assigned Manishearth - 16 days - waiting for new review after revision

oops, thanks, approved

#82496 by GuillaumeGomez, assigned jyn514 - Feb 26 - failing tests

ugh, I probably need to fix this myself. It's an important fix but it will be hard to fix the ICE (https://github.com/rust-lang/rust/pull/82496#issuecomment-786951402)

view this post on Zulip Joshua Nelson (Mar 31 2021 at 21:35):

this would be another good use case for S-waiting-on-help - did we ever come to a decision on that?

view this post on Zulip Joshua Nelson (Mar 31 2021 at 21:37):

cc @GuillaumeGomez I guess - I would rather fix this bug before it hits stable

view this post on Zulip Joshua Nelson (Mar 31 2021 at 21:38):

I think we have 6 weeks or so

view this post on Zulip Joshua Nelson (Mar 31 2021 at 21:38):

oh err it's already on stable ignore me

view this post on Zulip bstrie (Mar 31 2021 at 21:44):

unfortunately, yes

oh, I was referring to the field in my triage report, not the github thing. presumably we want to measure something differently, otherwise I don't see why we'd include this field in the report

view this post on Zulip DPC (Mar 31 2021 at 22:27):

ah okay, well it doesn't matter much to me, i infer the activity after checking the PR. You can omit it if you wish

view this post on Zulip Noah Lev (Apr 01 2021 at 17:40):

bstrie said:

unfortunately, yes

oh, I was referring to the field in my triage report, not the github thing. presumably we want to measure something differently, otherwise I don't see why we'd include this field in the report

I usually look at the last comment/push/merge conflict/etc. Basically the last time the state changed.

view this post on Zulip Noah Lev (Apr 01 2021 at 17:44):

Skipping triage for today since all PRs were updated 15 days or less ago.

view this post on Zulip DPC (Apr 01 2021 at 17:48):

that's not a skip though :stuck_out_tongue:

view this post on Zulip Joshua Nelson (Apr 01 2021 at 19:04):

ugh, I probably need to fix this myself. It's an important fix but it will be hard to fix the ICE (https://github.com/rust-lang/rust/pull/82496#issuecomment-786951402)

took a shot but no dice :(

view this post on Zulip Charles Lew (Apr 02 2021 at 12:08):

April 2nd, 2021 Friday
A few pings and reassign. Nothing to report today...

view this post on Zulip The 8472 (Apr 02 2021 at 16:56):

rust-highfive seems to have hiccups and didn't assign reviewers for some PRs

view this post on Zulip bstrie (Apr 02 2021 at 19:09):

was I, er, not supposed to do the entire 15-days-old-or-more backlog? :sweat_smile:

view this post on Zulip DPC (Apr 02 2021 at 20:03):

bstrie said:

was I, er, not supposed to do the entire 15-days-old-or-more backlog? :sweat_smile:

normally it's do as much as you can :grinning:

view this post on Zulip Joshua Nelson (Apr 02 2021 at 21:04):

Joshua Nelson said:

ugh, I probably need to fix this myself. It's an important fix but it will be hard to fix the ICE (https://github.com/rust-lang/rust/pull/82496#issuecomment-786951402)

took a shot but no dice :(

(discussion ongoing in https://github.com/rust-lang/rust/issues/83761, and I will stop disrupting triage now)

view this post on Zulip DPC (Apr 02 2021 at 21:52):

The 8472 said:

rust-highfive seems to have hiccups and didn't assign reviewers for some PRs

you can ping me on those prs, i'll assign a reviewer

view this post on Zulip The 8472 (Apr 02 2021 at 21:57):

https://github.com/rust-lang/rust/pulls?q=is%3Aopen+is%3Apr+no%3Aassignee+

view this post on Zulip Joshua Nelson (Apr 02 2021 at 22:05):

The 8472 said:

rust-highfive seems to have hiccups and didn't assign reviewers for some PRs

this usually happens when someone does r? @ghost

view this post on Zulip Joshua Nelson (Apr 02 2021 at 22:05):

or anyone else not in the rust-lang org

view this post on Zulip DPC (Apr 02 2021 at 22:12):

uhm no it didn't assign for some other ones

view this post on Zulip Noah Lev (Apr 03 2021 at 01:13):

Sometimes people use r? @ghost and then later edit the PR description to remove it, so that could be it. But I have noticed that highfive conks out occasionally.


Last updated: Jan 26 2022 at 14:46 UTC