Stream: t-release/triage

Topic: 2021-03-01 to 03-07


view this post on Zulip DPC (Mar 01 2021 at 01:30):

Triage reports for the week starting 01.03.2021.

view this post on Zulip John Simon (Mar 01 2021 at 03:59):

S-waiting-on-author
pinged:
#77916 opened on Oct 13, 2020 by Ericson2314 - has a few approvals but bounced to author for merge conflicts because the PR wasn't merged before it developed conflicts.
#81114 opened on Jan 17 by bugadani updated 17 days ago - merge conflict
#79746 opened on Dec 5, 2020 by hosseind88 updated 21 days ago - conflict and comments - might be abandoned.
#80943 opened on Jan 12 by vladdoster updated 21 days ago - closed as inactive
#79665 opened on Dec 3, 2020 by steffahn updated 21 days ago - closed as inactive, looks abandoned
#81778 opened 24 days ago by maisiliym updated 20 days ago
#81569 opened 29 days ago by tomcumming updated 20 days ago Can you please address the comments from @Mark-Simulacrum?
#81345 opened on Jan 24 by osa1 updated 17 days ago
#79382 opened on Nov 24, 2020 by g2p updated 15 days ago - closed as inactive
#73945 opened on Jul 1, 2020 by est31 • Approved updated 15 days ago - pinged again this has approvals but is blocked by a merge conflict. can anyone address this? Author has apparently abandoned the PR.

not pinged:
#79366 opened on Nov 23, 2020 by nikomatsakis updated 21 days ago
#79171 opened on Nov 18, 2020 by eddyb updated 21 days ago
#78551 opened on Oct 29, 2020 by Lucretiel updated 21 days ago 3 of 3
#75923 opened on Aug 25, 2020 by eddyb updated 21 days ago
#80822 opened on Jan 8 by Aaron1011 updated 17 days ago - merge conflict
#79892 opened on Dec 10, 2020 by scottmcm updated 17 days ago
#81197 opened on Jan 19 by jyn514 • Approved updated 17 days ago
#81197 opened on Jan 19 by jyn514 • Approved updated 17 days ago - already has approval might need another reviewer - Mark-Simulacrum commented 17 days ago Yeah I'm afraid I don't have the time to do a deep dive into why the rustc being passed isn't found
#81041 opened on Jan 15 by osa1 • Approved updated 16 days ago - osa1 commented 16 days ago Sigh.. You're right that the cranelift version is never shown. I don't know how to make it work -- author needs help!

*S-waiting-on-review
GuillaumeGomez
#80705 opened on Jan 4 by tspiteri • Approved updated 21 days ago - still waiting

joshtriplett
#77916 opened on Oct 13, 2020 by Ericson2314 updated 17 days ago -

m-ou-se
#80460 opened on Dec 28, 2020 by calebsander updated 20 days ago - Dylan-DPC commented 20 days ago - r? m-ou-se
#81607 opened 28 days ago by the8472 updated 17 days ago Mark-Simulacrum commented 17 days ago r? m-ou-se (possibly for further reassignment), I don't have a lot of knowledge about iterators right now and probably not the time to do a deep dive
#81617 opened 28 days ago by sdroege updated 17 days ago Mark-Simulacrum commented 17 days ago r? m-ou-se for reassignment
#81825 opened 23 days ago by voidc updated 16 days ago
#80076 opened on Dec 16, 2020 by mahkoh updated 16 days ago - Dylan-DPC commented 16 days ago mahkoh m-ou-se whats the status of this?

davidtwco
#80763 opened on Jan 6 by petrochenkov • Approved updated 15 days ago - already has approval from estebank petrochenkov commented 15 days ago r? davidtwco

steveklabnik
#80805 opened on Jan 7 by camelid updated 15 days ago

oli-obk
#75737 opened on Aug 20, 2020 by davidtwco • Approved updated 21 days ago - davidtwco has already rebased and fixed test and already has an approval

estebank
#81056 opened on Jan 15 by Aaron1011 updated 19 days ago - seems to have stalled

pnkfelix
#81635 opened 27 days ago by michaelwoerister updated 21 days ago - michaelwoerister commented 21 days ago The PR passes all tests now.
#80826 opened on Jan 8 by camelid updated 19 days ago - pnkfelix commented 19 days ago

nukomatsakis
#81309 opened on Jan 23 by lcnr updated 17 days ago - stalled for a month

sfackler
#81864 opened 21 days ago by ijackson updated 20 days ago ijackson says: Fixed these issues I think.
#81747 opened 25 days ago by tmiasko updated 19 days ago - pnkfelix commented 19 days ago seems to have stalled but I want to go review the footage

spastorino
#80543 opened on Dec 30, 2020 by LeSeulArtichaut updated 21 days ago - camelid commented on Dec 30, 2020 Blocked on rust-lang/triagebot#1078.

view this post on Zulip John Simon (Mar 01 2021 at 03:59):

(deleted)

view this post on Zulip Joshua Nelson (Mar 01 2021 at 04:14):

#81197 opened on Jan 19 by jyn514 • Approved updated 17 days ago

This one is listed twice. It doesn't need another approval, I just need to debug why it doesn't work. It's low-priority so I haven't gotten around to it.

#81041 opened on Jan 15 by osa1 • Approved updated 16 days ago - osa1 commented 16 days ago Sigh.. You're right that the cranelift version is never shown. I don't know how to make it work -- author needs help!

are you sure this should be waiting on author? The author posted a pretty lengthy comment and I think they're waiting on the reviewer for feedback.

view this post on Zulip Yuki Okushi (Mar 01 2021 at 06:03):

Agree with Joshua, changed the label to waiting-on-reviewer on #81041

view this post on Zulip Joshua Nelson (Mar 02 2021 at 00:51):

@DPC hey why did you close https://github.com/rust-lang/rust/pull/79746#event-4392865780? The author said they were going to work on it this week

view this post on Zulip DPC (Mar 02 2021 at 00:52):

ah lol misread 14 hours as 14 days :grinning: my bad :stuck_out_tongue:

view this post on Zulip DPC (Mar 02 2021 at 00:53):

reopened

view this post on Zulip Joshua Nelson (Mar 02 2021 at 00:53):

thanks!

view this post on Zulip Joel Palmer (Mar 02 2021 at 20:12):

Waiting on Review, Mar 2, 2021:

#80505 opened on Dec 30, 2020 by andersk updated 16 days ago - assigned to @m-ou-se

#80720 opened on Jan 5 by steffahn updated 16 days ago - assigned to @joshtriplett

#76345 opened on Sep 4, 2020 by okready updated 16 days ago

#80823 opened on Jan 8 by 1011X updated 16 days ago - assigned to @sfackler

#80320 opened on Dec 22, 2020 by RDambrosio016 updated 16 days ago - assigned to @GuillaumeGomez

#81866 opened 23 days ago by nagisa updated 16 days ago - assigned to @matthewjasper

#82130 opened 16 days ago by jhpratt updated 15 days ago - assigned to @ecstatic-morse

#80522 opened on Dec 30, 2020 by cjgillot updated 15 days ago

view this post on Zulip John Simon (Mar 04 2021 at 04:25):

Joshua Nelson said:

are you sure this should be waiting on author? The author posted a pretty lengthy comment and I think they're waiting on the reviewer for feedback.

I don't have the background to tell either way. :shrug:

view this post on Zulip Charles Lew (Mar 05 2021 at 19:03):

I'm back : )

view this post on Zulip Charles Lew (Mar 05 2021 at 19:03):

Friday, March 5th 2021
Needs-action:
https://github.com/rust-lang/rust/pull/80273 seems needs a new perf run.

Waiting-on-author:
https://github.com/rust-lang/rust/pull/78909 author Nemo157 - area T-rustdoc - merge conflict since november; need review; consider close ?
https://github.com/rust-lang/rust/pull/72878 author cjgillot - area T-compiler - merge conflict and performance regression since january.
https://github.com/rust-lang/rust/pull/82122 author bstrie - area T-libs - pending on a submodule bump, not sure whether has happened.
https://github.com/rust-lang/rust/pull/79572 author m-ou-se - area T-lang unstable-attribute - waiting on author since dec 16
https://github.com/rust-lang/rust/pull/76531 author workingjubilee - area T-libs - waiting on author since nov 7; consider close ?
https://github.com/rust-lang/rust/pull/82039 author estebank - area T-compiler

Waiting on review:
https://github.com/rust-lang/rust/pull/82191 reviewer sfackler - area T-libs-impl - impl optimizations
https://github.com/rust-lang/rust/pull/82179 reviewer sfackler - area T-libs - new function; needs decision
https://github.com/rust-lang/rust/pull/80522 reviewer wesleywiser - area T-compiler - easy to bitrot PR, currently in merge conflict
https://github.com/rust-lang/rust/pull/79846 reviewer m-ou-se - area T-libs-impl - impl optimizations.
https://github.com/rust-lang/rust/pull/80193 reviewer m-ou-se - area T-libs - fcp has finished on tracking issue. seems needs r+ from reviewer.
https://github.com/rust-lang/rust/pull/81858 reviewer m-ou-se - area T-libs O-unix waiting on review since feb 8
https://github.com/rust-lang/rust/pull/81047 reviewer shepmaster - area T-lib - needs someone to start fcp
https://github.com/rust-lang/rust/pull/81244 reviewer nikomatsakis - area D-edition - waiting on review since jan 22
https://github.com/rust-lang/rust/pull/81992 reviewer nikomatsakis - area D-edition - waiting on review since feb 11
https://github.com/rust-lang/rust/pull/81866 reviewer matthewjasper - area A-sanitizers - waiting on review since feb 8
https://github.com/rust-lang/rust/pull/78204 reviewer KodrAus - area T-libs - no decision yet
https://github.com/rust-lang/rust/pull/80720 reviewer joshtriplett - area T-doc - doc formatting change. not sure who is the best reviewer here.

view this post on Zulip Joshua Nelson (Mar 05 2021 at 19:35):

https://github.com/rust-lang/rust/pull/78909 author Nemo157 - area T-rustdoc - merge conflict since november; need review; consider close ?

other than the merge conflicts, this is waiting on review AFAICT. I would hate to close this, it fixes a long-standing rustdoc bug (that was bad enough cargo started warning about it).

https://github.com/rust-lang/rust/pull/80720 reviewer joshtriplett - area T-doc - doc formatting change. not sure who is the best reviewer here.

I asked Steve Klabnik to review


Last updated: Jan 26 2022 at 13:32 UTC