Stream: t-release/triage

Topic: 2021-02-08 to 02-14


view this post on Zulip John Simon (Feb 08 2021 at 14:59):

Triage report for the week starting 08.02.2021

view this post on Zulip John Simon (Feb 08 2021 at 15:00):

author / reviewer

S-waiting-on-author
https://github.com/rust-lang/rust/pull/80080 - rylev / oli-obk - merge conflicts
https://github.com/rust-lang/rust/pull/80438 - crlf0710 / m-ou-se - merge conflicts
https://github.com/rust-lang/rust/pull/79746
https://github.com/rust-lang/rust/pull/79366 - nikomatsakis / matthewjasper - merge conflicts
https://github.com/rust-lang/rust/pull/77728 - needs decision
https://github.com/rust-lang/rust/pull/80943 - vladdoster / steveklabnik - needed to address
https://github.com/rust-lang/rust/pull/80452 - cjgillot / oli-obk - merge conflicts
https://github.com/rust-lang/rust/pull/79665 - steffahn / joshtriplett - apparently this still needs more work
https://github.com/rust-lang/rust/pull/79979 - GuillaumeGomez commented on Dec 26, 2020 - I don't like the idea of adding JS config/lock files either, which is why I first suggested adding submodule. I just wanted to answer to your last reply because it didn't seem much better. Anyway, we can go with that as well, I'm fine with it!
... maybe ready for review?
https://github.com/rust-lang/rust/pull/79730 - b-naber commented 28 days ago - We agreed on trying another approach for this issue (#80788). This PR will be closed if the other PR is accepted.
don't know if this should be closed
https://github.com/rust-lang/rust/pull/80839 - tblah / Mark-Simulacrum - tblah added 2 commits 29 days ago - pinged for more info
https://github.com/rust-lang/rust/pull/78551 - Lucretiel / joshtriplett - merge conflicts
https://github.com/rust-lang/rust/pull/80339 - jyn514 / GuillaumeGomez - merge conflicts
https://github.com/rust-lang/rust/pull/79892 - scottmcm / m-ou-se - merge conflicts
https://github.com/rust-lang/rust/pull/75923 - eddyb CR has sat for a while.
https://github.com/rust-lang/rust/pull/79296 - nico-abram / RalfJung closed as inactive
https://github.com/rust-lang/rust/pull/78634 - dtolnay / petrochenkov - waiting on merge conflict
https://github.com/rust-lang/rust/pull/71481 - estebank / nikomatsakis - merge conflict
https://github.com/rust-lang/rust/pull/76716 - still waiting on discussion form the team
https://github.com/rust-lang/rust/pull/80308 - nvzqz / m-ou-se - pinged author
https://github.com/rust-lang/rust/pull/79849 - Digital-Chaos / m-ou-se pinged author for status
https://github.com/rust-lang/rust/pull/77675 - Anthuang / Mark-Simulacrum closed due to to inactivity - author hasnt't addressed comments in two months - sad because it's their first PR to rust.
https://github.com/rust-lang/rust/pull/79382 - g2p / Mark-Simulacrum - not sure what to do with this

-- leaving off here for author reviews - 23 days and earlier

S-waiting-on-review
https://github.com/rust-lang/rust/pull/78360 - tmiasko / wesleywiser
https://github.com/rust-lang/rust/pull/76447 - pickfire / estebank - pickfire commented 25 days ago - I think I should wait for estebank to review first.
https://github.com/rust-lang/rust/pull/79665
https://github.com/rust-lang/rust/pull/80076 - mahkoh / m-ou-se - 23 days ago
https://github.com/rust-lang/rust/pull/72209 - Nemo157 / estebank Dylan-DPC commented 22 days ago - estebank this is waiting for your final review. Looks ready imo :smiley:
https://github.com/rust-lang/rust/pull/81127 - hanmertens / shepmaster -
https://github.com/rust-lang/rust/pull/80427 - Skgland / oli-obk oli-obk commented 27 days ago
The PR is from 2016 and the RFC is from 2014, the whole idea should probably be revised before proceeding. cc Kimundi Nemo157 how do you feel about abolishing this scheme entirely and coming up with something new that does not conflict with macro imports?
https://github.com/rust-lang/rust/pull/79728 - ethanboxx / KodrAus - don't know if this is for reviewer or author
https://github.com/rust-lang/rust/pull/79850 - charles-r-earp / joshtriplett - don't know if this is for reviewer or author
https://github.com/rust-lang/rust/pull/80432 - xfix / cramertj - still waiting on review
https://github.com/rust-lang/rust/pull/80460 - calebsander / sfackler - still waiting on review
https://github.com/rust-lang/rust/pull/81126 - oxalica / m-ou-se - commented 15 days ago m-ou-se Fixed. Also updated the benchmark result.
https://github.com/rust-lang/rust/pull/79846 - the8472 / m-ou-se -
https://github.com/rust-lang/rust/pull/80705 - tspiteri / GuillaumeGomez crlf0710 commented 17 days ago - Triage: What's the current status? already has approval
https://github.com/rust-lang/rust/pull/80771 - thomcc / withoutboats - apparently just waiting for approval?
https://github.com/rust-lang/rust/pull/79930 - tgnottingham / m-ou-se - author resolved conflicts - please review
https://github.com/rust-lang/rust/pull/79692 - KodrAus / sfackler
https://github.com/rust-lang/rust/pull/80543 - LeSeulArtichaut / spastorino - blocked
https://github.com/rust-lang/rust/pull/78360 - tmiasko / wesleywiser
https://github.com/rust-lang/rust/pull/80076 - mahkoh / m-ou-se - still waiting on review author addressed comments
https://github.com/rust-lang/rust/pull/72209 - Nemo157 / estebank Dylan-DPC commented 22 days ago - estebank this is waiting for your final review. Looks ready imo :smiley:
https://github.com/rust-lang/rust/pull/80705 - crlf0710 commented 17 days ago Triage: What's the current status?
https://github.com/rust-lang/rust/pull/80705 - tspiteri / GuillaumeGomez already has approval
https://github.com/rust-lang/rust/pull/75737 - davidtwco / oli-obk addressed comment and now has approval, assigned to reviewer
https://github.com/rust-lang/rust/pull/79965 - ijackson / m-ou-se - author addressed questions, moved to reviewer
https://github.com/rust-lang/rust/pull/81041 - osa1 / Mark-Simulacrum - pinged author for status

entirely too many this week

view this post on Zulip Noah Lev (Feb 12 2021 at 05:00):

S-waiting-on-review

#80076 28 days - seems like people are unsure if this is the right solution - author: mahkoh, assignee: m-ou-se
#81309 19 days - waiting on initial review - author: lcnr, assignee: nikomatsakis
#81312 19 days - waiting on review - author: dylni, assignee: shepmaster
#80822 19 days - has conflicts - author: Aaron1011, assignee: oli-obk
#77916 19 days - has conflicts, but didn't ping because needs decision - author: Ericson2314, assignee: joshtriplett
#81238 18 days - waiting on review after perf showed good results - author: RalfJung, assignee: cramertj
#81345 17 days - new review -> now waiting on author - author: osa1, assignee: RalfJung
#81114 17 days - waiting on review after perf showed slight improvements - author: bugadani, assignee: estebank
#81207 16 days - auto-generated perf PR - not sure how to triage this! - assignee: rylev (self-assigned)

S-waiting-on-author

#79892 Dec 17 - has conflicts and new review, but team member so no ping - author: scottmcm, assignee: m-ou-se
#76716 Nov 8 - has conflicts and new review, but team member so no ping - author: GuillaumeGomez, assignee: jyn514
#80523 27 days - unsure of status, left comment - author: LeSeulArtichaut, assignee: jyn514
#73111 24 days - unsure of status, left comment - author: clarfonthey, assignee: m-ou-se
#79500 Dec 30 - actually is blocked, still blocked - author: TimDiekmann, assignee: Amanieu

view this post on Zulip Joshua Nelson (Feb 12 2021 at 05:11):

#81207 16 days - auto-generated perf PR - not sure how to triage this! - assignee: rylev (self-assigned)

This was discussed in https://github.com/rust-lang/rust/pull/80796#issuecomment-767861331, so it can probably be closed. You may want to check with rylev just in case.

view this post on Zulip Noah Lev (Feb 12 2021 at 05:15):

Update on #80523:

jyn514: Yes, @LeSeulArtichaut can you please also add #[doc(inline)] to pub use kw_generated::*? r=me after that.


Last updated: Jan 29 2022 at 10:01 UTC