Stream: t-release/triage

Topic: 2021-01-11 to 01-17


view this post on Zulip Charles Lew (Jan 11 2021 at 05:53):

Triage reports for the week starting 11.01.2021

view this post on Zulip John Simon (Jan 11 2021 at 08:19):

Welcome Back everyone, big one this time since we've been off for so long

S-waiting-on-author
https://github.com/rust-lang/rust/pull/79588 - CI fails - assigned back to author
https://github.com/rust-lang/rust/pull/79670 - merge conflict
https://github.com/rust-lang/rust/pull/79775 - CI fails - assigned back to author
https://github.com/rust-lang/rust/pull/78551 - CI fails, merge conflict - assigned back to author Lucretiel
https://github.com/rust-lang/rust/pull/78515 - merge conflict - assignedback to author Lucretiel
https://github.com/rust-lang/rust/pull/78370 - assigned back to author
https://github.com/rust-lang/rust/pull/79052 - merge conflict - assigned back to author GuillaumeGomez
https://github.com/rust-lang/rust/pull/79989 - merge conflict - assigned back to author scottmcm
https://github.com/rust-lang/rust/pull/79659 - merge conflict - assigned back to author matklad - last message "scottmcm commented 26 days ago "
https://github.com/rust-lang/rust/pull/79730 - merge conflict assigned back to b-naber and pinged
https://github.com/rust-lang/rust/pull/73314 - merge conflict - assigned back to author GuillaumeGomez, Manishearth requested changes
https://github.com/rust-lang/rust/pull/79399 - assigned back to author pickfire to address changes
https://github.com/rust-lang/rust/pull/78259 - merge conflict assigned back to plaflamme and pinged
https://github.com/rust-lang/rust/pull/77377 - Dylan-DPC commented on Nov 17, 2020 @ecstatic-morse any updates?
https://github.com/rust-lang/rust/pull/78909 - pinged author Nemo157 for merge conflicts
https://github.com/rust-lang/rust/pull/74765 - already has an approval - pinged dlrobertson
https://github.com/rust-lang/rust/pull/79171 - eddyb - not triaging
https://github.com/rust-lang/rust/pull/77435 - not sure about this - is it ready for review? to be assigned to scottmcm?
https://github.com/rust-lang/rust/pull/78634 - dtolnay - not triaging
https://github.com/rust-lang/rust/pull/75065 - joshtriplett - not triaging
https://github.com/rust-lang/rust/pull/71481 - estebank - not triaging but has merge conflicts
https://github.com/rust-lang/rust/pull/76734 - dtolnay - not triaging but has merge conflicts
https://github.com/rust-lang/rust/pull/75923 - eddyb - not triaging but has merge conflicts, last touched by "alecmocatta commented on Oct 15, 2020"
https://github.com/rust-lang/rust/pull/76240 - matklad - not triaging matklad commented on Dec 11, 2020 - I think it's fair to decide that we in general want to fix this somehow, but, given that this is low priority, and that there might be future considirations here, to just punt on this.
https://github.com/rust-lang/rust/pull/79323 - alerted author
https://github.com/rust-lang/rust/pull/72603 - alerted author @jsgf to address conflicts and comments
https://github.com/rust-lang/rust/pull/78181 - GuillaumeGomez commented on Dec 4, 2020 "Ok, seems to be ready!" not there are now merge conflicts
https://github.com/rust-lang/rust/pull/79819 - Aaron1011 - CI is broken
https://github.com/rust-lang/rust/pull/79830 -
https://github.com/rust-lang/rust/pull/79086 - Not Pinging: euclio commented 29 days ago Still on my radar. Hoping to get some time to work on this over the holidays.
https://github.com/rust-lang/rust/pull/79747 - camelid - not triaging
https://github.com/rust-lang/rust/pull/75571 - Not Pinging: JulianKnodt commented 26 days ago - I'm going to leave this up, but probably won't update it too much while the manually drop issue is still pending.
https://github.com/rust-lang/rust/pull/79100 - pinged author a1phyr for status
https://github.com/rust-lang/rust/pull/79001 - Pinged author de-vri-es to address merge conflicts.
https://github.com/rust-lang/rust/pull/76531 - workingjubilee - not triaging
https://github.com/rust-lang/rust/pull/79403 - author bishtpawan commented 24 days ago- I commented on the issue regarding the issue but didn't get any response from the issue's owner. Still waiting for @follower's response. Thanks
https://github.com/rust-lang/rust/pull/76716 - GuillaumeGomez - not triaging
https://github.com/rust-lang/rust/pull/79232 - yoshuawuyts - not triaging
https://github.com/rust-lang/rust/pull/79382 - pinged g2p for status , no reviewers assigned, only Mark-Simulacrum listed as Assignee
https://github.com/rust-lang/rust/pull/79296 - nico-abram commented 22 days ago @crlf0710 No updates, still have to analyze the crater report (I got started with it but haven't touched it in a couple weeks. Still planning to work on it, probably after december)
https://github.com/rust-lang/rust/pull/77675 - not sure what to do with this - jyn514 commented 21 days ago, looks like it's waiting on another priority
https://github.com/rust-lang/rust/pull/78781 - eddyb - not triaging
https://github.com/rust-lang/rust/pull/73945 - Pinged @est31 to address conflicts- already has an approval
https://github.com/rust-lang/rust/pull/79979 - GuillaumeGomez - not triaging
https://github.com/rust-lang/rust/pull/78991 - Aaron1011 commented 14 days ago - I'll revisit this after #79819 is merged

S-waiting-on-review
Waiting for Oli-Obk
https://github.com/rust-lang/rust/pull/79591 - Dec 3, 2020
https://github.com/rust-lang/rust/pull/77693 - last touched "bugadani commented on Dec 9, 2020"

Waiting for estebank
https://github.com/rust-lang/rust/pull/79012
https://github.com/rust-lang/rust/pull/79746 - jyn514 commented on Dec 6, 2020 r? estebank
https://github.com/rust-lang/rust/pull/79757 - already has approval from pickfire
https://github.com/rust-lang/rust/pull/76219 - not sure how to triage this: Files changed 371
https://github.com/rust-lang/rust/pull/80215 - rust-highfive assigned estebank 22 days ago
https://github.com/rust-lang/rust/pull/80232 - rust-highfive assigned estebank 22 days ago

Waiting for joshtriplett
https://github.com/rust-lang/rust/pull/79665
https://github.com/rust-lang/rust/pull/79850 - Last touched "scottmcm commented on Dec 10, 2020"
https://github.com/rust-lang/rust/pull/79113 - andjo403 commented on Nov 26, 2020 @joshtriplett what do you think close or not?
https://github.com/rust-lang/rust/pull/72321

Waiting for KodrAus
https://github.com/rust-lang/rust/pull/72160 - already has approval from joshtriplett
https://github.com/rust-lang/rust/pull/79085 - Dec 4, 2020
https://github.com/rust-lang/rust/pull/78818 - Dylan-DPC commented on Nov 24, 2020 r? KodrAus
https://github.com/rust-lang/rust/pull/78880 - shepmaster commented on Nov 16, 2020 r? KodrAus
https://github.com/rust-lang/rust/pull/78681 - Dylan-DPC commented on Nov 24, 2020 r? KodrAus
https://github.com/rust-lang/rust/pull/78455 - RustyYato commented 25 days ago
https://github.com/rust-lang/rust/pull/77633 - Dylan-DPC commented on Nov 30, 2020 r? KodrAus
https://github.com/rust-lang/rust/pull/80254 - rust-highfive assigned estebank 21 days ago
https://github.com/rust-lang/rust/pull/80017 - last touched when pickfire reviewed 21 days ago, don't know if this should be assigned back to author

Waiting for lcnr
https://github.com/rust-lang/rust/pull/79291

Waiting for pickfire
https://github.com/rust-lang/rust/pull/79728 - pickfire reviewed on Dec 6, 2020

waiting for pnkfelix
https://github.com/rust-lang/rust/pull/79804 - varkor commented on Dec 10, 2020 Implementation looks fine, but I'm not familiar enough with the purpose of no_niche to be happy reviewing. r? pnkfelix
https://github.com/rust-lang/rust/pull/76447 - pickfire author - not sure if the comment from estebank was resolved

waiting for withoutboats
https://github.com/rust-lang/rust/pull/75793 - a1phyr last commented on Dec 10, 2020 ... not sure if still in review or if author needs to do something
https://github.com/rust-lang/rust/pull/79884 - Digital-Chaos marked this pull request as ready for review on Dec 10, 2020
https://github.com/rust-lang/rust/pull/80201 - rust-highfive rust-highfive assigned withoutboats 22 days ago

waiting for ecstatic-morse
https://github.com/rust-lang/rust/pull/77487 - Dylan-DPC commented on Nov 20, 2020 ecstatic-morse any updates on this?

Waiting for tmandry
https://github.com/rust-lang/rust/pull/79689 - Vooblin commented 28 days ago r? tmandry

waiting for jyn514
https://github.com/rust-lang/rust/pull/79986 - 28 days ago

waiting for cramertj
https://github.com/rust-lang/rust/pull/79100 - a1phyr force-pushed the a1phyr:better_assert_eq branch from 00b0bfa to f1b8672 25 days ago

waiting for matklad
https://github.com/rust-lang/rust/pull/76808 - Dylan-DPC commented on Nov 13, 2020 @matklad any updates?

waiting for sfackler
https://github.com/rust-lang/rust/pull/79943 - last touched scottmcm commented 23 days agoscottmcm commented 23 days ago

waiting for kennytm
https://github.com/rust-lang/rust/pull/79380 - rustbot added the S-blocked label 23 days ago

waiting for matthewjasper
https://github.com/rust-lang/rust/pull/79554 - rust-highfive assigned matthewjasper on Nov 30, 2020 - don't know if still being worked on by author

waiting for dtolnay
https://github.com/rust-lang/rust/pull/80269 - rust-highfive assigned dtolnay 21 days ago
https://github.com/rust-lang/rust/pull/75644 - c410-f3r commented on Nov 17, 2020 "Any news? It's been 3 months already" last touched "WaffleLapkin commented 18 days ago"

waiting for Dylan-DPC
https://github.com/rust-lang/rust/pull/79983 - Dylan-DPC commented 29 days ago looks good to me and seems consistent with others

waiting for nikomatsakis
https://github.com/rust-lang/rust/pull/77325 - last touched when ishitatsuyuki commented 16 days ago

Unassigned but still in review
https://github.com/rust-lang/rust/pull/76345 - Dylan-DPC commented on Nov 9, 2020 r? @jethrogb

view this post on Zulip Poliorcetics (Jan 11 2021 at 11:59):

I think ecstatic-morse is not on the review rotation anymore (about #77487)

view this post on Zulip Joshua Nelson (Jan 11 2021 at 12:44):

https://github.com/rust-lang/rust/pull/77675 - not sure what to do with this - jyn514 commented 21 days ago, looks like it's waiting on another priority

it's not waiting on another priority, it's waiting for an org member to take action other than r+ (because r+ is insufficient here, see my comment)

view this post on Zulip DPC (Jan 11 2021 at 22:27):

yeah since we were on a 2-3 week break it'll be a huge list, thanks will go through it

view this post on Zulip Noah Lev (Jan 12 2021 at 00:20):

Poliorcetics said:

I think ecstatic-morse is not on the review rotation anymore (about #77487)

Actually they are, but I'm not sure if they are still doing reviews.

view this post on Zulip Poliorcetics (Jan 12 2021 at 16:47):

That’s what I meant to say, bad phrasing on my part

view this post on Zulip Noah Lev (Jan 15 2021 at 04:47):

S-waiting-on-review

#79591 Dec 3 - waiting on author to add a test - didn't ping because I know estebank has a lot of stuff to get to (and was off for December) - author: estebank, assignee: oli-obk
#79665 Dec 3 - waiting on review - author: steffahn, assignee: joshtriplett
#79423 Dec 4 - waiting on team decision - author: camelid, assignee: GuillaumeGomez
#79706 Dec 4 - seems experimental? - author: bjorn3, assignee: (none)
#79728 Dec 6 - waiting on review - should maybe be re-assigned - author: ethanboxx, assignee: withoutboats
#77693 Dec 9 - waiting on author - pinged - author: bugadani, assignee: oli-obk
#79804 Dec 10 - waiting on review - author: tmiasko, assignee: pnkfelix
#79884 Dec 10 - waiting on review - author: Digital-Chaos, assignee: withoutboats
#79850 Dec 10 - waiting on review - I left a small review too - author: charles-r-earp, assignee: joshtriplett
#79986 Dec 14 - waiting on reviewer decision on whether the change is worthwhile - author: GuillaumeGomez, assignee: jyn514
#72209 Nov 12 - the FCP finished, I think all that's left is for this to be merged - author: Nemo157, assignee: estebank
#76808 Nov 13 - waiting on review - author: LeSeulArtichaut, assignee: matklad

view this post on Zulip Charles Lew (Jan 15 2021 at 14:25):

Happy new year!
Jan 15th, 2020, Friday

needs action items:
https://github.com/rust-lang/rust/pull/79296 <- needs help with analyzing crater report.
https://github.com/rust-lang/rust/pull/70904 needs fcp votes from t-lib members.
https://github.com/rust-lang/rust/pull/77675 seems need special operation to able to land.

S-waiting-on-author

https://github.com/rust-lang/rust/pull/79892 scottmcm
https://github.com/rust-lang/rust/pull/75923 eddyb
https://github.com/rust-lang/rust/pull/78781 eddyb
https://github.com/rust-lang/rust/pull/78634 dtolnay, needs a rebase and some more tests
https://github.com/rust-lang/rust/pull/76734 dtolnay, needs a rebase
https://github.com/rust-lang/rust/pull/75065 joshtriplett
https://github.com/rust-lang/rust/pull/71481 estebank
https://github.com/rust-lang/rust/pull/74879 GuillaumeGomez
https://github.com/rust-lang/rust/pull/78181 GuillaumeGomez
https://github.com/rust-lang/rust/pull/76716 GuillaumeGomez
https://github.com/rust-lang/rust/pull/80527 jyn514

S-waiting-on-review
https://github.com/rust-lang/rust/pull/75522 ollie27
https://github.com/rust-lang/rust/pull/80011 m-ou-se
https://github.com/rust-lang/rust/pull/79233 joshtriplett
https://github.com/rust-lang/rust/pull/79313 matthewjasper
https://github.com/rust-lang/rust/pull/79951 nikomatsakis
https://github.com/rust-lang/rust/pull/80144 nikomatsakis
https://github.com/rust-lang/rust/pull/77325 nikomatsakis
https://github.com/rust-lang/rust/pull/79846 withoutboats
https://github.com/rust-lang/rust/pull/79753 withoutboats
https://github.com/rust-lang/rust/pull/80201 withoutboats
https://github.com/rust-lang/rust/pull/80454 eddyb
https://github.com/rust-lang/rust/pull/80404 ecstatic-morse
https://github.com/rust-lang/rust/pull/80385 cramertj


Last updated: Jan 26 2022 at 14:20 UTC