Stream: t-release/triage

Topic: 2020-11-30 to 12-06


view this post on Zulip DPC (Nov 30 2020 at 13:31):

Triage reports for the week starting 30.11.2020. Monthly meeting will be held on

view this post on Zulip John Simon (Nov 30 2020 at 16:50):

S-waiting-on-author
https://github.com/rust-lang/rust/pull/78454 - assigned back to bugadani because it looks like this PR needs more work.
https://github.com/rust-lang/rust/pull/76066 - assigned back to author pickfire to resolve merge conflict... jyn514 left a comment • "crlf0710 this needs a new reviewer, I think Lukas has left the libs team."
https://github.com/rust-lang/rust/pull/78181 - assigned back to author GuillaumeGomez because of build failure, not pinging
https://github.com/rust-lang/rust/pull/78928 - assigned back to author simonvandel for merge conflicts. but
https://github.com/rust-lang/rust/pull/77035 - assinged to mibac138 to fix merge conflicts
https://github.com/rust-lang/rust/pull/76215 - estebank PR, could be closed maybe? "Aaron1011 commented on Sep 12 - Personally, I'd prefer if we limited this to cases where the previous output is potentially confusing, as I described in my comment. However, I don't feel very strongly about this, so I'll leave it up to you to decide."
https://github.com/rust-lang/rust/pull/76130 - WIP PR, not doing anything
https://github.com/rust-lang/rust/pull/76301 - matklad PR, merge conflict, not pinging
https://github.com/rust-lang/rust/pull/78177 - From another comment it looks like ecstatic-morse is no longer active - but was still assigned this PR to review, still assigned to author

S-waiting-on-review
https://github.com/rust-lang/rust/pull/78399 - looks like a test environment failure - oli-obk commented 17 days ago - cc rust-lang/clippy maybe we should revisit our test suite?
https://github.com/rust-lang/rust/pull/79012 - waiting on review from estebank
https://github.com/rust-lang/rust/pull/77633 - still waiting on review but has sat idle for a month
https://github.com/rust-lang/rust/pull/75414 - still waiting on review from eddyb, also idle for over a month
https://github.com/rust-lang/rust/pull/77530 - unsure what to do with this, maybe it should be closed because the work is going to be added elsewhere? pinged author MikailBag
https://github.com/rust-lang/rust/pull/76808 - still waiting on review from matklad
https://github.com/rust-lang/rust/pull/79015 - still waiting on review from KodrAus

view this post on Zulip Noah Lev (Dec 04 2020 at 02:32):

S-waiting-on-review

#78399 21 days - unsure; seems like there was a weird bors CI failure that can't be easily fixed? - assignee: oli-obk
#79012 21 days - this is a perf-oriented PR IIUC but perf was negligible - assignee: estebank
#77801 18 days - seems like backported to beta but not merged to master? confusing :shrug: - seems like this fixes UB in std, so it's an important PR - assignee: withoutboats
#79084 17 days - reassigned from estebank to oli-obk since I think oli's a better reviewer for it

S-waiting-on-author

#76301 Sept 13 - all this needs is a rebase; pinged author (matklad) - assignee: jonas-schievink
#76723 Oct 26 - author needs to address review - author is a Rust team member (jonas-schievink), but it's been 6 weeks so I pinged - assignee: oli-obk
#78177 20 days - waiting on review; re-assigned to jyn514
#77307 Oct 28 - author (lcnr) needs to find time to work on it (as of Oct 28) - no ping - assignee: wesleywiser
#77377 17 days - DPC pinged author (ecstatic-morse) 17 days ago; no reply since - assignee: pnkfelix

view this post on Zulip Noah Lev (Dec 04 2020 at 02:33):

Update for #77801: Mark-Simulacrum just posted this:

Going to go ahead and renominate for 1.49 backport (will do that this weekend). Would be great to make some progress here though.

view this post on Zulip Noah Lev (Dec 04 2020 at 02:34):

Update for #79012: Author (Tyson Nottingham) just posted this:

Yeah, I don't have strong feelings on whether or not to push forward with this. I'll note that cycles, cpu-clock, and task-clock stats saw moderate improvements even though instruction counts saw very small improvements. But it's possible that was just luck with the variance.

view this post on Zulip Joshua Nelson (Dec 04 2020 at 05:09):

fyi I think ecstatic-morse is taking a break from rust for a while

view this post on Zulip Joshua Nelson (Dec 04 2020 at 05:09):

#78177 20 days - waiting on review; re-assigned to jyn514

taking a look at this now, this is a fun pr to review :) lots of code archeology

view this post on Zulip Joshua Nelson (Dec 04 2020 at 05:29):

done, wow that was a lot of git magic :laughing:

view this post on Zulip Mara (Dec 04 2020 at 09:17):

re #77801: boats doesn't have much time to review things, but i'm not sure who else could review this. but yeah, bit of a weird situation that this is backported to both 1.48 and 1.49, but not approved for nightly.

view this post on Zulip simulacrum (Dec 04 2020 at 13:44):

@Mara do you think you could bring it up at a libs meeting perhaps? I could take a stab at it but I'm not sure how I feel overriding/interpreting boats' concerns on Pin usage

view this post on Zulip Mara (Dec 04 2020 at 13:49):

@simulacrum Yeah good idea, although boats said in an email this week they won't be joining any meetings until january.

It came up shortly during a meeting a while ago, while talking about general guidelines for PRs involving Pin. But we didn't go into this PR specifically much. boats just said they still needed to take a closer look at it.

view this post on Zulip simulacrum (Dec 04 2020 at 13:50):

you know -- I think we should just land it on master

view this post on Zulip simulacrum (Dec 04 2020 at 13:50):

it's not like we can't revert

view this post on Zulip simulacrum (Dec 04 2020 at 13:50):

Can you reassign to me?

view this post on Zulip Charles Lew (Dec 04 2020 at 14:38):

Dec 4th, 2020, Friday.
S-waiting-on-review

https://github.com/rust-lang/rust/pull/75522 ollie27
https://github.com/rust-lang/rust/pull/79085 KodrAus
https://github.com/rust-lang/rust/pull/72160 KodrAus
https://github.com/rust-lang/rust/pull/79174 withoutboats - should this be reassigned?


Last updated: Jan 26 2022 at 14:20 UTC