Stream: t-release/triage

Topic: 2020-11-23 to 11-29


view this post on Zulip DPC (Nov 22 2020 at 23:57):

Triage for week starting 23.11.2020

view this post on Zulip John Simon (Nov 24 2020 at 02:40):

S-waiting-on-author
https://github.com/rust-lang/rust/pull/69218 - pinged marwes, lots of work in this one so don't want to close for inactivity
https://github.com/rust-lang/rust/pull/78051 - not pinging blitzerr, but has been idle for a month
https://github.com/rust-lang/rust/pull/73928 - pinged LeSeulArtichaut, idle for over a month
https://github.com/rust-lang/rust/pull/77031 - MIR pr, but still sitting idle for two months, closed due to inactivity.
https://github.com/rust-lang/rust/pull/76447 - pickfire was already pinged two weeks ago and posted status.
https://github.com/rust-lang/rust/pull/78704 - from bjorn3, a rust team member, not pinging, but idle for two weeks
https://github.com/rust-lang/rust/pull/78407 - oli-obk PR, not pinging
https://github.com/rust-lang/rust/pull/75737 - davidtwco PR, not pinging
https://github.com/rust-lang/rust/pull/76531 - bounced back to author workingjubilee to address comments from m-ou-se
https://github.com/rust-lang/rust/pull/78776 - bounced back to author pickfire to address merge conflict
https://github.com/rust-lang/rust/pull/78525 - not pinging GuillaumeGomez because rust team member, but bounced back to address merge conflict

S-waiting-on-review
https://github.com/rust-lang/rust/pull/77728 - still waiting on review "Dylan-DPC commented 24 days ago not sure who is a good candidate to review this"
https://github.com/rust-lang/rust/pull/72321 - "Dylan-DPC commented on Oct 15 joshtriplett any updates?"
https://github.com/rust-lang/rust/pull/77325 - Still waiting on review since oct 17 ... looks like author needs additional help
https://github.com/rust-lang/rust/pull/78142 - waiting on review from ecstatic-morse since oct 20
https://github.com/rust-lang/rust/pull/77916 - not sure how to triage this, listed as "Waiting on decision" but has an approval but also merge conflicts
https://github.com/rust-lang/rust/pull/78818 - waiting on review from sfackler
https://github.com/rust-lang/rust/pull/78833 - waiting on review from LukasKalbertodt
https://github.com/rust-lang/rust/pull/78681 - waiting on review from Amanieu
https://github.com/rust-lang/rust/pull/78853 - waiting on review from spastorino ... untouched
https://github.com/rust-lang/rust/pull/77148 - listed as do not merge, ignoring
https://github.com/rust-lang/rust/pull/78551 - sitting idle, waiting on review from joshtriplett
https://github.com/rust-lang/rust/pull/77671 - already has an approval, waiting on review from eddyb
https://github.com/rust-lang/rust/pull/78609 - PR from lcnr, rust team member, not triaging but has broken build
https://github.com/rust-lang/rust/pull/78718 - waiting on review from ecstatic-morse

view this post on Zulip Joshua Nelson (Nov 24 2020 at 03:25):

https://github.com/rust-lang/rust/pull/77671 - already has an approval, waiting on review from eddyb

maybe ask someone else to review? eddyb is pretty behind on notifications

view this post on Zulip Joshua Nelson (Nov 24 2020 at 03:27):

https://github.com/rust-lang/rust/pull/78525 - not pinging GuillaumeGomez because rust team member, but bounced back to address merge conflict

this should not be marked waiting-on-author - it's waiting on me to write up an RFC

view this post on Zulip Joshua Nelson (Nov 24 2020 at 03:27):

(which I should get around to at some point ...)

view this post on Zulip Joshua Nelson (Nov 24 2020 at 03:29):

https://github.com/rust-lang/rust/pull/77728 - still waiting on review "Dylan-DPC commented 24 days ago not sure who is a good candidate to review this"

pinged Peter Rabbit , I think they'll know whether it's a good idea

view this post on Zulip Joel Palmer (Nov 24 2020 at 12:17):

Waiting on Author → Nov 24, 2020:

#78704 opened 21 days ago by bjorn3 updated 18 days ago

#78407 opened 29 days ago by oli-obk updated 17 days ago

#76043 opened on Aug 28 by estebank updated 15 days ago

#77168 opened on Sep 24 by Aaron1011 Changes requested updated 15 days ago

#78884 opened 16 days ago by flotts updated 15 days ago

#78173 opened on Oct 20 by camelid Approved updated 15 days ago

view this post on Zulip LingM (Nov 24 2020 at 16:23):

hi, i noticed this one sitting on S-waiting-on-bors for 11 days:
https://github.com/rust-lang/rust/pull/76688
might need another @bors retry?

view this post on Zulip DPC (Nov 24 2020 at 16:26):

sure

view this post on Zulip Noah Lev (Nov 26 2020 at 21:48):

S-waiting-on-review

#72321 Oct 15 - appears to still need review - assignee: joshtriplett
#78718 22 days - [my own PR!] still needs review, but I think I also need to look at it - assignee: ecstatic-morse
#78901 17 days - now waiting on author (pinged) - assignee: estebank
#78578 17 days - unsure - assignee: ecstatic-morse
#76087 17 days - I think still needs review - assignee: KodrAus

view this post on Zulip Charles Lew (Nov 28 2020 at 07:10):

Nov 27~28, 2020 Friday (sorry i'm a little late today)

S-waiting-on-author
https://github.com/rust-lang/rust/pull/78407 oli-obk
https://github.com/rust-lang/rust/pull/77611 oli-obk
https://github.com/rust-lang/rust/pull/68828 oli-obk
https://github.com/rust-lang/rust/pull/76043 estebank
https://github.com/rust-lang/rust/pull/76896 spastorino
https://github.com/rust-lang/rust/pull/78611 jyn514

S-waiting-on-review
https://github.com/rust-lang/rust/pull/78259 KodrAus
https://github.com/rust-lang/rust/pull/76345 jethrogb (can't assign issue... do we have a sgx team?)


Last updated: Jan 26 2022 at 14:02 UTC