Stream: t-release/triage

Topic: 2020-10-26 to 11-01


view this post on Zulip DPC (Oct 26 2020 at 00:53):

Triage reports for the week starting 26.10.2020

view this post on Zulip Joel Palmer (Oct 27 2020 at 09:33):

Waiting on author:
#75078 opened on Aug 2 by ijackson updated 15 days ago
#77752 opened 18 days ago by lcnr updated 16 days ago
#76138 opened on Aug 30 by camelid • Changes requested updated 16 days ago
#75571 opened on Aug 15 by JulianKnodt updated 18 days ago
#76203 opened on Sep 1 by NextTurn updated 19 days ago
#74979 opened on Jul 31 by maekawatoshiki updated 19 days ago
#76552 opened on Sep 9 by ridiculousfish updated 19 days ago
#76716 opened on Sep 14 by GuillaumeGomez updated 19 days ago
#68699 opened on Jan 31 by GuillaumeGomez updated 19 days ago

view this post on Zulip Noah Lev (Oct 30 2020 at 04:52):

S-waiting-on-author

#68699 22 days - inactive, there's a replacement PR, so I closed it
#76716 22 days - has conflicts since Sept 16
#76427 Sept 8 - CI failed (just needs ./x.py fmt) and rustdoc team is unsure about change
#76467 17 days - has conflicts
#75752 28 days - needs review, updated label (assigned to LukasKalbertodt)
#74765 16 days - bors tests failed - author is unsure what to do
#75784 Sept 20 - author needs to address review, also has new conflicts
#77862 15 days - author needs to address review
#77333 14 days - seems to be waiting on team, so updated label (not fully sure what's up though)

S-waiting-on-review

#75644 22 days - seems to still be waiting on review (assigned to withoutboats)
#76339 Sept 21 - still waiting on review from matklad
#77636 21 days - waiting on review from estebank
#76257 21 days - looks like it could be done pretty fast (assigned to Dylan-DPC)
#76391 20 days - has conflicts (this is a conflict-prone PR), updated label but didn't ping
#76941 20 days - needs review - assignee: withoutboats
#77805 19 days - needs review - assignee: estebank
#74254 19 days - seems like there are complex issues, matthewjasper was cc'd by RalfJung
#77728 18 days - needs review - assignee: withoutboats
#77196 18 days - waiting on review since Sept 25 - assignee: eddyb
#77487 17 days - needs review - assignee: ecstatic-morse
#77700 17 days - reviewer (jyn514) wants to wait until another PR is merged, so I removed S-waiting-on-review (it already had S-blocked)
#77665 17 days - needs review but also has a bunch of conflicts (didn't ping, added S-waiting-on-author) - assignee: wesleywiser
#76767 17 days - I-needs-decision and waiting-on-team; also has conflicts
#77844 17 days - waiting on review from sfackler
#75866 17 days - unsure of status (CI failed) - assignee: eddyb
#76219 17 days - waiting on review from estebank - has conflicts, but author (Mark-Simulacrum) thinks as of 17 days ago that it won't impede review

Unlabeled PRs

#77693 22 days - there must have been a highfive bug because no one was assigned and waiting-on-review wasn't added! - I added waiting-on-review and assigned Amanieu
#78407 2 days - seems to be an experiment, but I added waiting-on-author so it isn't lost

There were 2 others that were unlabeled, but I didn't touch them:

#78416 "[Experiment] Testing out some formatting things." (author is m-ou-se, self-assigned to m-ou-se)
#72571 "[WIP] Pietro's CI playground" (what it sounds like!)

view this post on Zulip Joshua Nelson (Oct 30 2020 at 05:17):

#77700 17 days - reviewer (jyn514) wants to wait until another PR is merged, so I removed S-waiting-on-review (it already had S-blocked)

Ugh I really need to get around to https://github.com/rust-lang/rust/pull/76467 at some point

view this post on Zulip Joshua Nelson (Oct 30 2020 at 05:18):

I think I was too ambitious and need to cut it down so it can unblock Dániel Buga's changes

view this post on Zulip Noah Lev (Oct 30 2020 at 05:19):

It does have a pretty long PR description :)

view this post on Zulip Joshua Nelson (Oct 30 2020 at 05:19):

oh those are just the first commit :joy:

view this post on Zulip Joshua Nelson (Oct 30 2020 at 05:19):

I made a bunch more changes after

view this post on Zulip Joshua Nelson (Oct 30 2020 at 05:21):

#76767 17 days - I-needs-decision and waiting-on-team; also has conflicts

IMO this should just be closed, I don't think it's a good idea

view this post on Zulip Joshua Nelson (Oct 30 2020 at 05:21):

https://github.com/rust-lang/rust/pull/76767#discussion_r489768904

view this post on Zulip Joshua Nelson (Oct 30 2020 at 05:22):

I have a long-standing complaint that rustdoc mixes up 'this documentation isn't shown' with 'this part of the code doesn't get warnings'

view this post on Zulip Joshua Nelson (Oct 30 2020 at 05:22):

#77728 18 days - needs review - assignee: withoutboats

maybe ping or re-assign?

view this post on Zulip Joshua Nelson (Oct 30 2020 at 05:24):

#76257 21 days - looks like it could be done pretty fast (assigned to Dylan-DPC)

approved it

view this post on Zulip Joshua Nelson (Oct 30 2020 at 05:25):

#77196 18 days - waiting on review since Sept 25 - assignee: eddyb

eddyb is very behind on reviews, maybe assign someone else?

view this post on Zulip Joshua Nelson (Oct 30 2020 at 05:29):

@camelid camelid added the S-waiting-on-author label 1 hour ago

I don't think this is correct for https://github.com/rust-lang/rust/pull/76391, it's waiting on cuviper to take a look at the proposed split

view this post on Zulip Joshua Nelson (Oct 30 2020 at 05:29):

https://github.com/rust-lang/rust/pull/76391#issuecomment-703008179

view this post on Zulip Noah Lev (Oct 30 2020 at 05:46):

Joshua Nelson said:

@camelid camelid added the S-waiting-on-author label 1 hour ago

I don't think this is correct for https://github.com/rust-lang/rust/pull/76391, it's waiting on cuviper to take a look at the proposed split

Ok, I wasn't sure. I changed it back to waiting-on-review for now

view this post on Zulip Joshua Nelson (Oct 30 2020 at 05:53):

https://github.com/rust-lang/rust/pull/77027 is also waiting on review from Josh Triplett for 17 days

view this post on Zulip Joshua Nelson (Oct 30 2020 at 05:56):

is https://github.com/rust-lang/rust/pull/76858 waiting on anything? It's approved

view this post on Zulip Joshua Nelson (Oct 30 2020 at 06:05):

https://github.com/rust-lang/rust/pull/75911 is waiting on author for 15 days (the labels were wrong, I switched them)

view this post on Zulip Joshua Nelson (Oct 30 2020 at 06:06):

https://github.com/rust-lang/rust/pull/73945 is waiting on review for 14 days

view this post on Zulip Joshua Nelson (Oct 30 2020 at 06:22):

https://github.com/rust-lang/rust/pull/77950 is waiting on review by eddyb for 15 days

view this post on Zulip Joshua Nelson (Oct 30 2020 at 06:24):

https://github.com/rust-lang/rust/pull/77921 is waiting on review by Jake Goulding for 16 days

view this post on Zulip Joshua Nelson (Oct 30 2020 at 06:25):

I think I'll just approve, it's a trivial change and personallyI think the new code is better

view this post on Zulip Joshua Nelson (Oct 30 2020 at 06:38):

https://github.com/rust-lang/rust/pull/72321 is waiting on review by Josh Triplett for 14 days

view this post on Zulip Joshua Nelson (Oct 30 2020 at 06:41):

https://github.com/rust-lang/rust/pull/76894 is waiting on review for 11 days

view this post on Zulip Joshua Nelson (Oct 30 2020 at 06:41):

I think. Possibly it's waiting on author?

view this post on Zulip Joshua Nelson (Oct 30 2020 at 06:54):

https://github.com/rust-lang/rust/pull/73111 is waiting on review since June

view this post on Zulip Noah Lev (Oct 30 2020 at 06:55):

Joshua Nelson said:

https://github.com/rust-lang/rust/pull/73111 is waiting on review since June

That's funny, I had to re-implement that method recently :D

view this post on Zulip Noah Lev (Oct 30 2020 at 06:57):

It's marked as needs-rfc; is that still necessary? Or I guess we can merge it as unstable feature until there's an RFC?

view this post on Zulip Mara (Oct 30 2020 at 08:23):

There were 2 others that were unlabeled, but I didn't touch them:

#78416 "[Experiment] Testing out some formatting things." (author is m-ou-se, self-assigned to m-ou-se)

Should I mark PRs like that with some label? An experiment label might be useful.

view this post on Zulip Charles Lew (Oct 30 2020 at 12:47):

Oct 30, 2020

Needs action:
https://github.com/rust-lang/rust/pull/77099 <-- Needs a reviewer here!

S-waiting-on-review
https://github.com/rust-lang/rust/pull/77027 joshtriplett
https://github.com/rust-lang/rust/pull/75522 ollie27
https://github.com/rust-lang/rust/pull/76902 KodrAus

S-waiting-on-team
https://github.com/rust-lang/rust/pull/70904 T-libs
https://github.com/rust-lang/rust/pull/74989 T-libs
https://github.com/rust-lang/rust/pull/74860 T-libs
https://github.com/rust-lang/rust/pull/75065 T-libs
https://github.com/rust-lang/rust/pull/75180 T-libs PG-error-handling

view this post on Zulip Mara (Oct 30 2020 at 12:53):

https://github.com/rust-lang/rust/pull/77099 <-- Needs a reviewer here!

I can do that one.

view this post on Zulip Noah Lev (Oct 30 2020 at 17:02):

@Mara I just created the S-experimental label and added it to your PR

view this post on Zulip Mara (Oct 30 2020 at 17:16):

Ah cool :)

view this post on Zulip DPC (Nov 02 2020 at 13:56):

(deleted)


Last updated: Jan 26 2022 at 13:32 UTC