Stream: t-release/triage

Topic: 2020-10-19 to 10-25


view this post on Zulip DPC (Oct 19 2020 at 00:51):

Triage reports for the week starting 19.10

view this post on Zulip Joshua Nelson (Oct 22 2020 at 16:55):

You'd have to compute liveness of locals, which isn't too difficult. But since this optimization had no measurable performance benefits anyways, I'm not sure that's worth it (running dataflow might slightly regress performance).

No activity for a month.

Might be some others, I ran out of time.

view this post on Zulip Noah Lev (Oct 23 2020 at 03:21):

S-waiting-on-review

#77376 20 days - is a good cleanup change, but changes are error-prone - note: first-time contributor
#77377 18 days - has conflicts, but in .mir files which I think we're not supposed to ping for
#75793 18 days - reviewer wasn't comfortable with blanket impl, also waiting on withoutboats - note: PR originally opened on August 21 (2 months ago)!
#75728 18 days - reviewer wants someone to double-check
#77392 18 days - waiting on review from LukasKalbertodt - first-time contributor
#77232 17 days - author needs to address review comments; pinged
#77530 17 days - unsure of status, looks like needs review from T-lang
#76580 17 days - waiting on review from estebank
#77413 17 days - unsure of status
#77611 17 days - waiting on review from sfackler
#73314 16 days - unsure, is assigned to jyn514
#77633 16 days - unsure, is assigned to withoutboats
#77364 16 days - conflicts; pinged
#75414 ~6 wks - unsure; seems like reviewer (eddyb) was mixed
#76649 ~5 wks - unsure here too, is assigned to withoutboats - first-time contributor
#76345 15 days - waiting on review from jethrogb - first-time contributor!
#74699 1 month - waiting on review from kennytm (marked as I-needs-decision)
#74583 1 month - waiting on author and also review from cramertj
#76808 1 month - waiting on review from matklad

S-waiting-on-author

#77271 20 days - marked as experimental so leaving alone
#68828 18 days - conflicts; pinged
#76215 1 month - waiting on decision from author estebank
#74293 2 months- conflicts; pinged author (Rust team member) because I forgot the procedure :embarrassed:
#73936 2 months- waiting on team and author (author wants buy-in before investing more) - first-time contributor
#76301 1 month - very close to being merged, just needs a rebase from author matklad
#76671 1 month - conflicts; no ping because Rust team member

S-blocked

#70951 opened April 9, updated 6 hours ago - looks like waiting on MCP approval
#77227 updated 7 days ago - looks like the PR it's blocked on was closed

view this post on Zulip Charles Lew (Oct 23 2020 at 12:30):

Needs action:
https://github.com/rust-lang/rust/pull/76097 Is this ready for review?

S-waiting-on-team
https://github.com/rust-lang/rust/pull/74879 T-rustdoc
https://github.com/rust-lang/rust/pull/73530 T-core
https://github.com/rust-lang/rust/pull/75435 T-libs
https://github.com/rust-lang/rust/pull/76226 T-libs
https://github.com/rust-lang/rust/pull/76829 T-libs

I've bumped the labels and there's no other PRs > 15 days.

I'll try to give a more verbose report next time.

view this post on Zulip Joshua Nelson (Oct 23 2020 at 13:24):

76079 is waiting on the author to address comments


Last updated: Jan 29 2022 at 11:01 UTC