Stream: t-release/triage

Topic: 2020-09-21 to 09-27


view this post on Zulip DPC (Sep 21 2020 at 13:18):

Triage report for week starting 21.09

view this post on Zulip John Simon (Sep 21 2020 at 21:27):

S-waiting-on-author
https://github.com/rust-lang/rust/pull/74209 - 18 days, pinged lzutao. This one has approvals already, and might be ready for review

https://github.com/rust-lang/rust/pull/73111 - 18 days pinged clarfonthey - this has some merge conflicts again. Is this PR ready for review? Looks like this one has sat idle in the waiting on author state instead of being reviewed, so it just collected more merge conflicts as time went on
https://github.com/rust-lang/rust/pull/76096 - 18 days pinged pickfire and changed the tag to S-waiting-on-author, again merge conflicts.

https://github.com/rust-lang/rust/pull/75143 - 18 days - not pinged because oli-obk is part of the rust team
https://github.com/rust-lang/rust/pull/75738 - 17 days - pinged pickfire and moved back to S-waiting-on-author, looks like pickfire needs help": pickfire commented 17 days ago - jswrenn Can you please help me to take a look at this?
https://github.com/rust-lang/rust/pull/74942 - 16 days - ping marinpostma and moved back to s-waiting-on-author

S-waiting-on-review
https://github.com/rust-lang/rust/pull/76196 - 18 days - looks like this is ready for review so I've moved it there.
https://github.com/rust-lang/rust/pull/74699 - crlf0710 commented 17 days ago: Ping from triage! What's the current status? I assume the crater report needs to be analyzed? ---- we already have an approvals

https://github.com/rust-lang/rust/pull/76339 - 17 days - looks like still waiting on review
https://github.com/rust-lang/rust/pull/76388 - 16 days - looks like still waiting on review

view this post on Zulip Joshua Nelson (Sep 21 2020 at 23:52):

this has some merge conflicts again. Is this PR ready for review? Looks like this one has sat idle in the waiting on author state instead of being reviewed, so it just collected more merge conflicts as time went on

@DPC and I have discussed this before so I won't belabor it too much, but this seems like another reason not to mark merge conflicts as 'waiting-on-author'

view this post on Zulip DPC (Sep 21 2020 at 23:53):

i get your point but then even if it's reviewed we still have to wait for the author to resolve the conflicts (and likely re-approve again)

view this post on Zulip Joshua Nelson (Sep 21 2020 at 23:54):

sure, then change the status after it's approved

view this post on Zulip Joshua Nelson (Sep 21 2020 at 23:54):

otherwise there's not much point, it will just keep running into merge conflicts and never be looked at

view this post on Zulip Joshua Nelson (Sep 21 2020 at 23:54):

@jswrenn Can you please help me to take a look at this?
@pickfire moved this back to s-waiting-on-author

also this seems really unhelpful

view this post on Zulip DPC (Sep 21 2020 at 23:54):

uhm

view this post on Zulip DPC (Sep 21 2020 at 23:55):

is that the same pr or you are quoting another pr? :grinning:

view this post on Zulip DPC (Sep 21 2020 at 23:55):

i guess it's another one

view this post on Zulip Joshua Nelson (Sep 21 2020 at 23:55):

different pr, sorry

view this post on Zulip Joshua Nelson (Sep 21 2020 at 23:55):

https://github.com/rust-lang/rust/pull/75738#issuecomment-687545913

view this post on Zulip DPC (Sep 21 2020 at 23:55):

not sure why pickfire moved that one, since they are not part of the triage team

view this post on Zulip Joshua Nelson (Sep 21 2020 at 23:55):

they didn't, @John Simon did

view this post on Zulip DPC (Sep 21 2020 at 23:56):

pr is still opening :tortoise: sec

view this post on Zulip DPC (Sep 21 2020 at 23:57):

ah misread your quote

view this post on Zulip DPC (Sep 22 2020 at 00:28):

sure, then change the status after it's approved

Also that PR has a CI failure which i'm not sure if it is related to the PR, so it's fine to wait on the author

view this post on Zulip Joshua Nelson (Sep 22 2020 at 00:29):

:shrug: I guess this goes back to my point about 'waiting-on-help'

view this post on Zulip Joshua Nelson (Sep 22 2020 at 00:30):

never mind, didn't actually read the PR

view this post on Zulip Charles Lew (Sep 25 2020 at 14:11):

Friday, Sept 25th, 2020

Needs action:
https://github.com/rust-lang/rust/pull/76257 - Seems needs to be r+ed again.

S-waiting-on-author:
https://github.com/rust-lang/rust/pull/74879 - GuillaumeGomez, also needs some help from compiler team
https://github.com/rust-lang/rust/pull/75645 - Aaron1011, inactive for more than a month now.
https://github.com/rust-lang/rust/pull/75894 - lzutao, needs a rebase

S-waiting-on-review:
https://github.com/rust-lang/rust/pull/76232 - sfackler
https://github.com/rust-lang/rust/pull/75866 - eddyb

S-waiting-on-team:
https://github.com/rust-lang/rust/pull/71780 - t-libs

view this post on Zulip Joshua Nelson (Sep 25 2020 at 14:22):

https://github.com/rust-lang/rust/pull/74879 - GuillaumeGomez, also needs some help from compiler team

Personally I don't think it's worth it to fix this as is, I'd rather have https://github.com/rust-lang/rust/issues/76382

view this post on Zulip Joshua Nelson (Sep 25 2020 at 14:22):

the caching is just too intertwined

view this post on Zulip Joshua Nelson (Sep 25 2020 at 14:23):

I don't think compiler team would be able to help, this is a rustdoc issue


Last updated: Jan 26 2022 at 14:02 UTC