Stream: t-release/triage

Topic: 2020-06-22 to 06-28 triage report


view this post on Zulip DPC (Jun 22 2020 at 11:54):

Triage reports 22.06 ..= 28.06 :stuck_out_tongue: go here

view this post on Zulip John Simon (Jun 23 2020 at 05:24):

S-waiting-on-author
https://github.com/rust-lang/rust/pull/73211 -
Mark-Simulacrum commented 12 days ago "Hm actually I missed the license update here, I'm not familiar enough myself to know whether that's fine or not -- I presume "dropping" part of an AND is fine, though."

Not sure if this is for the author or reviewer

https://github.com/rust-lang/rust/pull/72412
Contributor - VFLashM commented 9 days ago
cyndis pnkfelix I don't really want to waste time rebasing this change if performance tradeoffs are not acceptable. Please let me know if they are. If not, I'll work on a different solution.

https://github.com/rust-lang/rust/pull/72633
VFLashM commented 9 days ago
eddyb I really don't want to waste time rebasing this change unless there is interest in it.
Could you please take a glance at it and tell me if it is worth merging?

https://github.com/rust-lang/rust/pull/71780
seems to be waiting on feedback from dtolnay

https://github.com/rust-lang/rust/pull/72843
workingjubilee commented 20 days ago
Reviewing the theme and extension logic here, I am more uncertain about this PR being correct now, and could use guidance on how to assure the assumptions it rests upon are in fact correct.

https://github.com/rust-lang/rust/pull/71648
marmeladema commented 26 days ago
it appears there is not really a consensus about what the prototype of such query should be. Possibilities are:

Author needs help

S-waiting-on-review
joshtriplett
https://github.com/rust-lang/rust/pull/73166
https://github.com/rust-lang/rust/pull/72688 - 26 days ago

eddyb
https://github.com/rust-lang/rust/pull/72620

sfackler
https://github.com/rust-lang/rust/pull/72481 - walk between oli-obk and RalfJung ended but no movement 24 days ago
https://github.com/rust-lang/rust/pull/72876 - 21 days
https://github.com/rust-lang/rust/pull/70835 - not sure if this is waiting on review or author, last updated May 18
https://github.com/rust-lang/rust/pull/72311 - discussion has stalled

cramertj
https://github.com/rust-lang/rust/pull/72443
RalfJung left a comment - LGTM! But this is tricky enough to justify more eyes checking it.
https://github.com/rust-lang/rust/pull/72369 - untouched since May 20
https://github.com/rust-lang/rust/pull/73243
https://github.com/rust-lang/rust/pull/72954

BurntSushi
https://github.com/rust-lang/rust/pull/72808

kennytm
https://github.com/rust-lang/rust/pull/72053

estebank
https://github.com/rust-lang/rust/pull/71681 - already approved, appears to be waiting on merge

withoutboats
https://github.com/rust-lang/rust/pull/72617
https://github.com/rust-lang/rust/pull/72734
https://github.com/rust-lang/rust/pull/72303 - 12 days

matthewjasper
https://github.com/rust-lang/rust/pull/71481 - conversation seems to have stalled.

kinnison
https://github.com/rust-lang/rust/pull/72967 - kinnison commented 10 days ago - I think this looks sane, GuillaumeGomez do you agree?

GuillaumeGomez
https://github.com/rust-lang/rust/pull/72771 - don't know if this is waiting on a review or changes from the author

ecstatic-morse
https://github.com/rust-lang/rust/pull/73323
davidtwco commented 9 days ago " I'll wait to see what the reviewer thinks - not entirely sure what the protocol is here."

Mark-Simulacrum
https://github.com/rust-lang/rust/pull/73374
https://github.com/rust-lang/rust/pull/73343

view this post on Zulip Joel Palmer (Jun 23 2020 at 10:23):

waiting on author
#72029 opened on May 8 by spastorino updated 17 days ago
#72714 opened 25 days ago by JohnTitor updated 17 days ago

waiting on review
None

view this post on Zulip DPC (Jun 23 2020 at 12:16):

https://github.com/rust-lang/rust/pull/73211 - has been moved to #t-core/licensing for discussion

view this post on Zulip Elinvynia (Jun 25 2020 at 21:18):

date: 2020-06-25
label: S-waiting-on-author
<https://github.com/rust-lang/rust/pull/72714> - 19 days | member JohnTitor | 2nd triage
<https://github.com/rust-lang/rust/pull/71349> - 19 days | member wesleywiser | 3rd triage
<https://github.com/rust-lang/rust/pull/72029> - 19 days | member spastorino | needs rebase
<https://github.com/rust-lang/rust/pull/72571> - 16 days | member pietroalbini | should most likely be unlabeled
<https://github.com/rust-lang/rust/pull/68362> - 15 days | member csmoe | 2nd triage, needs rebase
<https://github.com/rust-lang/rust/pull/72273> - 15 days | member estebank | 3rd triage
<https://github.com/rust-lang/rust/pull/70193> - 15 days | member Amanieu | 3rd triage
<https://github.com/rust-lang/rust/pull/70563> - 15 days | member GuillaumeGomez | 5th triage
<https://github.com/rust-lang/rust/pull/70743> - 15 days | member oli-obk | 4th triage
<https://github.com/rust-lang/rust/pull/71016> - 15 days | member vertexclique | 2nd triage
<https://github.com/rust-lang/rust/pull/71199> - 15 days | member DPC <3 | 4th triage, needs rebase
<https://github.com/rust-lang/rust/pull/56655> - 15 days | member eddyb | 4th triage after reopening, needs rebase
<https://github.com/rust-lang/rust/pull/72035> - 15 days | member sfackler | 2nd triage
<https://github.com/rust-lang/rust/pull/72189> - 15 days | member nnethercote | 2nd triage, needs rebase
<https://github.com/rust-lang/rust/pull/71670> - 15 days | member GuillaumeGomez | was updated, relabeled
<https://github.com/rust-lang/rust/pull/69167> - 14 days | member GuillaumeGomez | 9th triage!, needs rebase

label: S-waiting-on-review
<https://github.com/rust-lang/rust/pull/72481> - 15 days | sfackler assigned | no review from assigned | 2nd triage
<https://github.com/rust-lang/rust/pull/72808> - 15 days | BurntSushi assigned | no review from assigned | 2nd triage
<https://github.com/rust-lang/rust/pull/72053> - 15 days | kennytm assigned | no review from assigned | 3rd triage
<https://github.com/rust-lang/rust/pull/70835> - 15 days | sfackler assigned | no review from assigned | 5th triage
<https://github.com/rust-lang/rust/pull/73197> - 15 days | joshtriplett assigned | no review
<https://github.com/rust-lang/rust/pull/72734> - 15 days | withoutboats assigned | no review from assigned
<https://github.com/rust-lang/rust/pull/72569> - 15 days | nikomatsakis assigned | relabeled as author
<https://github.com/rust-lang/rust/pull/72303> - 14 days | withoutboats assigned | no review from assigned

label: S-waiting-on-team
all good

label: S-waiting-on-bors
<https://github.com/rust-lang/rust/pull/72571> - 15 days days | double-labeled

label: S-waiting-on-crater
all good

label: S-waiting-on-bikeshed
none

label: S-waiting-on-perf
none

view this post on Zulip Charles Lew (Jun 26 2020 at 17:26):

June 25th
S-waiting-on-team:
https://github.com/rust-lang/rust/pull/69741 (waiting on t-lang team, but there are already merge conflict, so better let Esteban Küber know)

nothing else.

view this post on Zulip DPC (Jun 26 2020 at 18:46):

i think we can wait on that


Last updated: Jan 26 2022 at 14:02 UTC