Stream: t-compiler/wg-incr-comp

Topic: work items


view this post on Zulip Wesley Wiser (Sep 14 2020 at 12:37):

Hey eveyone, I've opened an issue in our repo to track ongoing work as well as work we'd like to do. I've also started surveying the rust-lang/rust issue tracker for ideas.

There's already quite a few items in this list so if you're looking for something to do, please check it out!

https://github.com/rust-lang/wg-incr-comp/issues/1

view this post on Zulip Wesley Wiser (Sep 14 2020 at 12:38):

I would be happy to answer questions as much as I can so please don't hesitate to ask :smile:

view this post on Zulip davidtwco (Sep 14 2020 at 12:40):

I'll take a look at these, thanks for this @Wesley Wiser!

view this post on Zulip Santiago Pastorino (Sep 14 2020 at 16:13):

Wesley Wiser said:

Hey eveyone, I've opened an issue in our repo to track ongoing work as well as work we'd like to do. I've also started surveying the rust-lang/rust issue tracker for ideas.

There's already quite a few items in this list so if you're looking for something to do, please check it out!

https://github.com/rust-lang/wg-incr-comp/issues/1

I wonder if it's not better to use github projects to track all this :)

view this post on Zulip Aman Arora (Sep 14 2020 at 16:53):

Is there a possiblity of getting mentoring notes on https://github.com/rust-lang/rust/issues/45408?

If so I might be able to help out here :)

view this post on Zulip Wesley Wiser (Sep 14 2020 at 17:22):

Yes, I will record some notes tonight

view this post on Zulip Wesley Wiser (Sep 15 2020 at 13:00):

@Aman Arora I left some notes with what I know off hand here https://github.com/rust-lang/rust/issues/45408#issuecomment-692697561

view this post on Zulip Aman Arora (Sep 15 2020 at 14:40):

I'll take a look tonight, thanks

view this post on Zulip Aman Arora (Sep 20 2020 at 02:52):

So I started looking at some of this, if we don't allocate a DepNode what DepNodeIndex do we return? I tried it with virtual_index based on some similar code, but it fails when dep_node_index_of is called.

Here is what I did: https://github.com/arora-aman/rust/commit/e602ec0d6527051e888e8b000d6514ed0fe572e5

view this post on Zulip Aman Arora (Sep 20 2020 at 05:08):

Actually running without || edges.is_empty() , makes all stage1 tests pass

view this post on Zulip Aman Arora (Sep 20 2020 at 05:10):

I tried using rust-perf to benchmark locally but looks like I'd need root perms (which I don't have on the server I use) for editing /proc/sys/kernel/perf_event_paranoid

view this post on Zulip Aman Arora (Sep 20 2020 at 05:16):

Is there an non root alternative?

view this post on Zulip Aman Arora (Sep 22 2020 at 22:12):

@Wesley Wiser https://github.com/rust-lang/rust/pull/77070 had very minimal effect, -4% best case. +0.4% worst case

I'm assuming it still reduces the memory/storage footprint because we intern less things. That said I don't understand the query system enough to say how many anon DepNodes we have have and how large and impact not interning them would have on storage

view this post on Zulip DPC (Sep 26 2020 at 16:24):

hey :smile: i can start working on https://github.com/rust-lang/rust/issues/35902. I'll start looking into it later today but if you have any pointers, it would be helpful :smile:


Last updated: Oct 21 2021 at 20:47 UTC