Stream: t-compiler/wg-incr-comp

Topic: red-green relevant impls


view this post on Zulip lcnr (Dec 14 2020 at 22:18):

the following comment was added about incremental compilation 3 years ago https://github.com/rust-lang/rust/blob/fa416394275d2468d104b8f72ac31b1ddf7ee52e/compiler/rustc_middle/src/ty/trait_def.rs#L172

is that still relevant or should we just remove it?

view this post on Zulip Wesley Wiser (Dec 14 2020 at 22:20):

When we get red-green recompilation ...

That sounds really out of date to me. AFAIK the red-green system is what we've had for a while now.

view this post on Zulip lcnr (Dec 14 2020 at 22:22):

yeah, the interesting part to me was

// If we want to be faster, we could have separate queries for
// blanket and non-blanket impls, and compare them separately.

view this post on Zulip mw (Dec 15 2020 at 10:12):

Yeah, it's probably safe to remove the part of the comment add in 453ad8122c975dc82f6090f0c755d38932ccefc5


Last updated: Oct 21 2021 at 21:02 UTC