Stream: t-compiler/wg-incr-comp

Topic: planning wg next steps


view this post on Zulip pnkfelix (Aug 27 2020 at 15:31):

Lets chat in here @Wesley Wiser

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:32):

:wave:

view this post on Zulip pnkfelix (Aug 27 2020 at 15:32):

and maybe we can make a hackmd to take notes in

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:33):

I was thinking a bit after the meeting this week that it would be good to identify some work items that interested participants could work on.

view this post on Zulip pnkfelix (Aug 27 2020 at 15:33):

https://hackmd.io/rOKReG2AQFmLNHJT2WzJkw

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:33):

What's the best way to track that?

view this post on Zulip pnkfelix (Aug 27 2020 at 15:33):

presumably the main effort there would be in making mentoring instructions, right?

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:33):

Should we create a repo and start filing issues?

view this post on Zulip pnkfelix (Aug 27 2020 at 15:33):

that, and soliciting workers

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:34):

Yeah, for sure

view this post on Zulip pnkfelix (Aug 27 2020 at 15:34):

You know, a repo is probably a good idea

view this post on Zulip pnkfelix (Aug 27 2020 at 15:34):

I think other wg's have used them to great success

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:34):

There are some other wg-* repos in the rust-lang organization so that might be the thing to do

view this post on Zulip pnkfelix (Aug 27 2020 at 15:35):

okay. let me see if i can just make one now

view this post on Zulip pnkfelix (Aug 27 2020 at 15:36):

I might not have privileges to do so

view this post on Zulip pnkfelix (Aug 27 2020 at 15:36):

yeah okay. let me ask niko

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:37):

That would also give us a place to sketch out what project groups we want to spin up.

view this post on Zulip pnkfelix (Aug 27 2020 at 15:38):

Its possible that the intention is that dedicated repo's are meant for project groups, not domain WG's.

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:39):

Ah, ok.

view this post on Zulip pnkfelix (Aug 27 2020 at 15:39):

Its also possible that other ways to track the work would suffice

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:40):

Well, if possible, I think that would be good to have that repo so we can open issues tracking things we'd like to do.

view this post on Zulip pnkfelix (Aug 27 2020 at 15:40):

e.g. maybe a github project on rust-lang/rust ?

view this post on Zulip pnkfelix (Aug 27 2020 at 15:40):

true

view this post on Zulip pnkfelix (Aug 27 2020 at 15:41):

okay well lets assume for now that niko will eventually create the repo or show me who I need to talk to to do it

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:41):

I listed some "beginner" tasks in https://rust-lang.zulipchat.com/#narrow/stream/241847-t-compiler.2Fwg-incr-comp/topic/cgu.20partitioning.20brain.20dump/near/206143019 that we could turn into issues. It's mostly just "do a test and record what happens"

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:42):

You also mentioned doing an issue triage during the last meeting.

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:42):

I think that might be good to start doing.

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:42):

We could start by just going over any new issues from the previous meeting.

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:43):

It might be good to see if there are "buckets" of related issues. I feel like I see a lot of the same kinds of ICEs and things repeatedly.

view this post on Zulip pnkfelix (Aug 27 2020 at 15:46):

yeah

view this post on Zulip pnkfelix (Aug 27 2020 at 15:48):

I'd definitely want to do a once-over of the issues, to bucket them as you say. And then maybe after that we might consider doing regular triage

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:48):

Oh yeah, that's true.

view this post on Zulip pnkfelix (Aug 27 2020 at 15:48):

but since bucketing is itself a task

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:48):

We might want to do some quick searches to find any similar ICE messages

view this post on Zulip pnkfelix (Aug 27 2020 at 15:48):

going over new issues isn't a bad idea at all. :)

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:49):

I found a few and tagged them the other day.

view this post on Zulip pnkfelix (Aug 27 2020 at 15:49):

You know,

view this post on Zulip pnkfelix (Aug 27 2020 at 15:49):

now that I don't have to justify how I'm spending my time to anyone

view this post on Zulip pnkfelix (Aug 27 2020 at 15:49):

maybe I'll look more into methods for getting better feedback about incremental bugs

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:50):

That would be really useful I think

view this post on Zulip pnkfelix (Aug 27 2020 at 15:50):

pnkfelix said:

now that I don't have to justify how I'm spending my time to anyone

(this is false; I still do answer to some people. just not at Mozilla. :wink: )

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:51):

Heh :laughing:

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:51):

I wonder how far we could get by doing a catch_unwind at OnDiskCache::try_load_query_result and then recording data or adding some additional output.

view this post on Zulip pnkfelix (Aug 27 2020 at 15:52):

I was thinking more like

view this post on Zulip pnkfelix (Aug 27 2020 at 15:52):

having cargo store the source code state of the crate for the current and previous build

view this post on Zulip pnkfelix (Aug 27 2020 at 15:52):

and having cargo report-incremental-bug. :)

view this post on Zulip pnkfelix (Aug 27 2020 at 15:53):

but that would admittedly require people knowing that a bug is likely something arising from incremental compilation in the first place.

view this post on Zulip pnkfelix (Aug 27 2020 at 15:53):

but maybe rustc could feed such hypotheses back to cargo...

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:53):

Maybe we can patch enough places to catch most of these incremental ICEs and add a note to the error that would ask them to run that tool

view this post on Zulip pnkfelix (Aug 27 2020 at 15:53):

right, exactly.

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:54):

Or at least, let the triage/tagging team know to ask for that when the see they issue.

view this post on Zulip pnkfelix (Aug 27 2020 at 15:57):

beyond a github repo, are there other planning things?

view this post on Zulip pnkfelix (Aug 27 2020 at 15:58):

there's obviously the re-scheduling that's under discussion in #t-compiler/wg-incr-comp > alternating meeting time

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:58):

I'm not thinking of any off hand.

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:58):

Does that time work for you?

view this post on Zulip pnkfelix (Aug 27 2020 at 15:58):

okay. I've already pinged niko about the github repo; if I don't hear back from them soon-ish, I'll try someone else (either in core or in infra)

view this post on Zulip pnkfelix (Aug 27 2020 at 15:58):

I think the time will work

view this post on Zulip Wesley Wiser (Aug 27 2020 at 15:59):

Ok, that seems to work for everyone

view this post on Zulip pnkfelix (Aug 27 2020 at 16:01):

cool. Thanks @Wesley Wiser

view this post on Zulip pnkfelix (Aug 27 2020 at 16:05):

okay niko made https://github.com/rust-lang/wg-incr-comp

view this post on Zulip Aman Arora (Aug 27 2020 at 20:32):

It might be a good idea to put the meeting notes and youtube link in the repo, similar to how we have for 2229 here: https://github.com/rust-lang/project-rfc-2229/blob/master/meetings.md

view this post on Zulip Aman Arora (Aug 27 2020 at 20:33):

I can add that once the video from this week is uploaded

view this post on Zulip pnkfelix (Aug 27 2020 at 22:23):

yeah sorry I still need to take care of that video upload


Last updated: Oct 21 2021 at 20:21 UTC