Stream: t-compiler/wg-incr-comp

Topic: Reviewing "Serialize span hygiene data"


view this post on Zulip Vadim Petrochenkov (Jul 04 2020 at 08:52):

Could someone look at the on_disk_cache.rs part of https://github.com/rust-lang/rust/pull/72121?
I'm not too familiar with incremental and stable hashing and don't have time to dig into this in more detail.

view this post on Zulip Vadim Petrochenkov (Jul 04 2020 at 08:55):

I'm ready to answer questions about other parts of the PR and hygiene infra.
The most important part is that ExpnId and SyntaxContext are IDs that are sequentially assigned IDs (similar to NodeIds) that are not stable between compilations.

view this post on Zulip Vadim Petrochenkov (Jul 04 2020 at 08:56):

(Assigning @Santiago Pastorino as someone in management role.)

view this post on Zulip pnkfelix (Jul 07 2020 at 14:52):

I'll look at it

view this post on Zulip Vadim Petrochenkov (Jul 07 2020 at 18:09):

Thanks!

view this post on Zulip pnkfelix (Jul 17 2020 at 20:29):

I posted my thoughts on the PR itself, here.


Last updated: Oct 21 2021 at 20:47 UTC