Hey @Wesley Wiser regarding PR #74275
the first big commit, the commit text says that its the one that adds thet rait
but its basically impossible to use the diff to validate changes that are associated with the addition of the trait
Can you restructure. the commits, adding an extra. one at the beginning that just does the shuffling of code into new files/mods?
Yeah, that's fair. I can split adding the trait and moving the code around into separate commits.
thanks. It would make the review easier.
That's true. I should have done it that way to begin with.
I'm going to bed in about an hour so I probably won't have this ready for review tonight. I'll ping you again when it's ready for review.
let me know if you want advise on git incantations. to ease this revision
Okay no problem. Sorry again for the. many week delay; i could have given you this. feedback a long time ago
No problem! It hasn't been been very bit-rot-y :)
FYI, this is ready for review. Thanks for the feedback!
okay r+'ed. Thanks @Wesley Wiser !
Last updated: Oct 21 2021 at 22:01 UTC