Stream: t-compiler/wg-incr-comp

Topic: Refactor the partitioning module PR #74275


view this post on Zulip pnkfelix (Aug 19 2020 at 00:29):

Hey @Wesley Wiser regarding PR #74275

view this post on Zulip pnkfelix (Aug 19 2020 at 00:29):

the first big commit, the commit text says that its the one that adds thet rait

view this post on Zulip pnkfelix (Aug 19 2020 at 00:30):

but its basically impossible to use the diff to validate changes that are associated with the addition of the trait

view this post on Zulip pnkfelix (Aug 19 2020 at 00:30):

Can you restructure. the commits, adding an extra. one at the beginning that just does the shuffling of code into new files/mods?

view this post on Zulip Wesley Wiser (Aug 19 2020 at 00:31):

Yeah, that's fair. I can split adding the trait and moving the code around into separate commits.

view this post on Zulip pnkfelix (Aug 19 2020 at 00:31):

thanks. It would make the review easier.

view this post on Zulip Wesley Wiser (Aug 19 2020 at 00:31):

That's true. I should have done it that way to begin with.

view this post on Zulip Wesley Wiser (Aug 19 2020 at 00:32):

I'm going to bed in about an hour so I probably won't have this ready for review tonight. I'll ping you again when it's ready for review.

view this post on Zulip pnkfelix (Aug 19 2020 at 00:32):

let me know if you want advise on git incantations. to ease this revision

view this post on Zulip pnkfelix (Aug 19 2020 at 00:33):

Okay no problem. Sorry again for the. many week delay; i could have given you this. feedback a long time ago

view this post on Zulip Wesley Wiser (Aug 19 2020 at 00:33):

No problem! It hasn't been been very bit-rot-y :)

view this post on Zulip Wesley Wiser (Aug 25 2020 at 13:54):

FYI, this is ready for review. Thanks for the feedback!

view this post on Zulip pnkfelix (Aug 25 2020 at 17:28):

thanks!

view this post on Zulip pnkfelix (Aug 25 2020 at 17:28):

looking now

view this post on Zulip pnkfelix (Aug 25 2020 at 17:59):

okay r+'ed. Thanks @Wesley Wiser !

view this post on Zulip Wesley Wiser (Aug 25 2020 at 18:10):

Thanks @pnkfelix!


Last updated: Oct 21 2021 at 22:01 UTC