Stream: t-compiler/wg-incr-comp

Topic: FIXME: DefSpans are not really inputs


view this post on Zulip Aaron Hill (May 12 2021 at 20:12):

@mw I just saw this (quite old) FIXME mentioning you: https://github.com/rust-lang/rust/blob/70e52caed91a43fc01867921e67fcd3478056edd/compiler/rustc_middle/src/query/mod.rs#L888-L892

view this post on Zulip Aaron Hill (May 12 2021 at 20:12):

do you know if that still applies?

view this post on Zulip cjgillot (May 12 2021 at 21:13):

IMHO, it does not, since def_span is implemented in terms of hir_owner and hir_owner_nodes.

view this post on Zulip mw (May 14 2021 at 08:11):

I'd need to take a closer look if that FIXME still applies. I vaguely remember that there was something in debuginfo that needed a workaround at some point but that might even predate the red-green system.

view this post on Zulip mw (May 14 2021 at 08:20):

I opened https://github.com/rust-lang/rust/issues/85281 so I don't forget about it.


Last updated: Oct 21 2021 at 20:47 UTC