Stream: t-compiler/wg-incr-comp

Topic: Do not make local copies of inline(always) fns in debug mod


view this post on Zulip Santiago Pastorino (Sep 18 2020 at 19:57):

#76889

view this post on Zulip Santiago Pastorino (Sep 18 2020 at 19:58):

something that we were discussing with @Wesley Wiser

view this post on Zulip Santiago Pastorino (Sep 18 2020 at 19:58):

I'm trying other things out but this one seems that could be an easy "win"

view this post on Zulip Santiago Pastorino (Sep 18 2020 at 19:58):

although some other test regress a bit

view this post on Zulip Santiago Pastorino (Sep 19 2020 at 23:26):

btw, I've left a different try here #76896

view this post on Zulip Santiago Pastorino (Jan 11 2021 at 19:21):

@Wesley Wiser @davidtwco I think we should revert this PR

view this post on Zulip Santiago Pastorino (Jan 11 2021 at 19:21):

https://github.com/rust-lang/rust/pull/76896#issuecomment-758097233

view this post on Zulip Santiago Pastorino (Jan 11 2021 at 19:22):

cc @wg-incr-comp

view this post on Zulip Santiago Pastorino (Jan 11 2021 at 19:22):

but let's agree on something here and I guess I can provide a new PR

view this post on Zulip davidtwco (Jan 11 2021 at 19:23):

I think @Alex Crichton's reasoning is convincing and so I'd be fine with seeing the PR reverted.

view this post on Zulip Santiago Pastorino (Jan 11 2021 at 19:24):

yep, that was my reasoning too

view this post on Zulip Wesley Wiser (Jan 11 2021 at 19:24):

Yeah, let's revert but leave that issue open so we can track what needs to be done to land this again (if we can).

view this post on Zulip Santiago Pastorino (Jan 11 2021 at 19:30):

#80922


Last updated: Oct 21 2021 at 21:32 UTC