Stream: project-ffi-unwind

Topic: PRs on the repo


view this post on Zulip nikomatsakis (Oct 08 2019 at 17:54):

Hey @Kyle Strand -- I left a few nits on your PR. Also, a suggestion re: LICENSE (mainly: let's use the same things RFCs use)

view this post on Zulip nikomatsakis (Oct 08 2019 at 17:54):

Sorry for the delay

view this post on Zulip nikomatsakis (Oct 08 2019 at 17:54):

Not sure if we feel ready to schedule another time to sync up? I'd be game btw to try and do Zulip-sync'ing in the future (vs zoom)

view this post on Zulip acfoltzer (Oct 08 2019 at 17:56):

I'm open to Zulip syncing, but am still getting used to the platform

view this post on Zulip nikomatsakis (Oct 08 2019 at 18:03):

It depends on the project but I often find Zulip sync'ing a bit "lighter weight" -- it's also more accessible, keeps an automatic log, etc

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 08 2019 at 18:05):

I like accessibility and automatic logging; the only issue I have is that I tend to multi-task when participating in text-only meetings

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 08 2019 at 18:06):

I should have checked what license the RFC repo uses!

view this post on Zulip nikomatsakis (Oct 08 2019 at 18:09):

I like accessibility and automatic logging; the only issue I have is that I tend to multi-task when participating in text-only meetings

heh, yeah, that can be an issue

view this post on Zulip nikomatsakis (Oct 08 2019 at 18:09):

on the other hand, I can play music :musical_notes:

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 08 2019 at 18:25):

I am also a fan of music!

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 08 2019 at 18:39):

Okay, I believe the concerns have been addressed. Thanks!

view this post on Zulip nikomatsakis (Oct 08 2019 at 18:52):

merged, great

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 12 2019 at 19:44):

I've opened a new PR based on the discussion raised in previous PRs.

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 12 2019 at 20:00):

( @nikomatsakis I was trying to notify Ralf, but I don't know if that worked)

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 22 2019 at 00:13):

@nikomatsakis I started by reading your PR on a plane using Vim, so I couldn't help but start making edits, which is making it take longer than if I just read it through. There are some bits we probably need to discuss, but I think I'll start that discussion by opening a PR against your branch.

view this post on Zulip nikomatsakis (Oct 22 2019 at 17:54):

I am thinking -- maybe I should merge my PR to aid in collaboration?

view this post on Zulip nikomatsakis (Oct 22 2019 at 17:54):

@Kyle Strand sounds great!

view this post on Zulip nikomatsakis (Oct 22 2019 at 22:46):

@Kyle Strand maybe it makes sense to (a) move the two existing RFC PRs to a "drafts" directory and (b) create a minimal RFC that just announces this group -- since e.g. @Amanieu wasn't aware of its existence! -- and have as our first milestone to hammer out this issue of defaults.

view this post on Zulip nikomatsakis (Oct 22 2019 at 22:46):

this can be a pretty short RFC then

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 22 2019 at 22:50):

Kyle Strand maybe it makes sense to (a) move the two existing RFC PRs to a "drafts" directory and (b) create a minimal RFC that just announces this group -- since e.g. Amanieu wasn't aware of its existence! -- and have as our first milestone to hammer out this issue of defaults.

Absolutely.

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 22 2019 at 22:55):

Unfortunately it's hard for me to predict whether I'll have time this week to draft that. But I think our conversation in Discord is a good start

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 22 2019 at 22:55):

that plus the relevant sections in your current draft

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 25 2019 at 02:07):

@nikomatsakis were you able to take a look at my PR on your PR?

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 27 2019 at 19:37):

Quick update: I am working on the PR to _just_ announce the WG.

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 27 2019 at 22:08):

@nikomatsakis @Josh Triplett I'd like to have the RFC proposing the project-group link to the "final" location of the project-repo, i.e., /rust-lang/project-ffi-unwind rather than Niko's personal version. Can that be done soon, or is there a blocker to resolve first?

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 27 2019 at 22:08):

(And, if there's a blocker, should we wait on the RFC, or just link to Niko's repo?)

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 27 2019 at 22:21):

In any case, here's the draft of the RFC: https://github.com/nikomatsakis/project-ffi-unwind/pull/16

view this post on Zulip nikomatsakis (Oct 28 2019 at 20:41):

I will transfer the repo to rust-lang now

view this post on Zulip nikomatsakis (Oct 28 2019 at 20:43):

done

view this post on Zulip nikomatsakis (Oct 28 2019 at 20:45):

In any case, here's the draft of the RFC: https://github.com/nikomatsakis/project-ffi-unwind/pull/16

@Kyle Strand I dont' know of any blocker. If you want to open this RFC, it seems ok to me -- the main downside will be that we need to open a follow-up to do "C unwind". But at this point I just want to open up some RFCs.

view this post on Zulip nikomatsakis (Oct 28 2019 at 20:46):

I think if you open this one, I will immediately move to fcp merge :)

view this post on Zulip nikomatsakis (Oct 28 2019 at 20:46):

It seems fine for us to then work on the "C unwind" RFC

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 28 2019 at 20:58):

RFC opened: https://github.com/rust-lang/rfcs/pull/2797

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 28 2019 at 21:03):

I think I'll replace the entire file in our project repo with a link to that new RFC; does that sound reasonable?

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 28 2019 at 21:29):

When I get a chance I'll update my "Kyle's comments..." PR to remove the group-announcement text and replace it with links to the project repo and RFC #2797

view this post on Zulip BatmanAoD (Kyle Strand) (Oct 29 2019 at 22:58):

@acfoltzer I should have pinged you yesterday; FYI I have opened the RFC to announce this group (link above)


Last updated: Jan 26 2022 at 09:02 UTC