Stream: t-lang/meta

Topic: improving the triagebot


view this post on Zulip nikomatsakis (May 02 2021 at 09:55):

Hey @Sladyn Nunes -- let's talk about improving the lang team triagebot code!

view this post on Zulip nikomatsakis (May 02 2021 at 09:55):

Link to triagebot: https://github.com/rust-lang/triagebot/

view this post on Zulip nikomatsakis (May 02 2021 at 09:55):

Actually, I could open an issue on there and summarize some of the details probably

view this post on Zulip Sladyn Nunes (May 03 2021 at 09:48):

Sounds perfect. Let me know when you open one up and we can start with some small tasks

view this post on Zulip nikomatsakis (May 05 2021 at 10:10):

HEy @Sladyn Nunes -- I started writing a gist with ideas

view this post on Zulip nikomatsakis (May 05 2021 at 10:10):

I'm still working a bit on it

view this post on Zulip nikomatsakis (May 05 2021 at 10:10):

I probably started from the wrong side

view this post on Zulip nikomatsakis (May 05 2021 at 10:11):

in that I started with some of the bigger ideas I want to put into effect, but the right place to start the doc is from some smaller steps

view this post on Zulip nikomatsakis (May 05 2021 at 10:11):

I'll edit it a bit more in a bit from that perspective!

view this post on Zulip nikomatsakis (May 05 2021 at 14:49):

ok, edited!

view this post on Zulip nikomatsakis (May 05 2021 at 14:49):

I guess I should move this to an issue or 3

view this post on Zulip nikomatsakis (May 05 2021 at 14:51):

Hey @simulacrum -- is triagebot the same as rustbot?

view this post on Zulip nikomatsakis (May 05 2021 at 14:51):

can we...have fewer bots? :)

view this post on Zulip simulacrum (May 05 2021 at 14:51):

yeah

view this post on Zulip simulacrum (May 05 2021 at 14:51):

well, rustbot is the github name

view this post on Zulip nikomatsakis (May 05 2021 at 14:51):

I know i know

view this post on Zulip simulacrum (May 05 2021 at 14:51):

because triagebot was taken

view this post on Zulip nikomatsakis (May 05 2021 at 14:51):

it's more that rfcbot and rustbot confuse me

view this post on Zulip nikomatsakis (May 05 2021 at 14:51):

maybe they can just forward commands to one another lol

view this post on Zulip simulacrum (May 05 2021 at 14:51):

it is indeed my long-term plan to have everything go through rustbot

view this post on Zulip nikomatsakis (May 05 2021 at 14:51):

@rustbot concern foo

view this post on Zulip nikomatsakis (May 05 2021 at 14:51):

results in:

view this post on Zulip nikomatsakis (May 05 2021 at 14:52):

Hi Niko! let me help you:

@rfcbot concern foo

view this post on Zulip nikomatsakis (May 05 2021 at 14:52):

heh

view this post on Zulip nikomatsakis (May 05 2021 at 14:52):

anyway, just kdiding, not why I pinged you

view this post on Zulip nikomatsakis (May 05 2021 at 14:52):

I wrote up some plans in that gist for how to improve rustbot for lang team triage purposes

view this post on Zulip nikomatsakis (May 05 2021 at 14:52):

I was going to open up some issues

view this post on Zulip nikomatsakis (May 05 2021 at 14:53):

I gues I'll open them on the triagebot repo, I thnk @Sladyn Nunes is game to take a crack at fixing them

view this post on Zulip simulacrum (May 05 2021 at 14:53):

sounds good to me!

view this post on Zulip simulacrum (May 05 2021 at 14:54):

everything in the gist looks reasonable

view this post on Zulip nikomatsakis (May 05 2021 at 14:54):

(side note that I was editing some code in there and I got the worst compiler errors)

view this post on Zulip nikomatsakis (May 05 2021 at 14:54):

I have to try and minimize that

view this post on Zulip Sladyn Nunes (May 05 2021 at 15:06):

I read the gist and understood a bit of what we want to do, let me know when you open issues on the triage bot,so that I can take a crack at fixing them in small steps

view this post on Zulip Sladyn Nunes (May 05 2021 at 15:06):

The gist looks overwhelming :PPP

view this post on Zulip nikomatsakis (May 05 2021 at 15:09):

@Sladyn Nunes ok, I'll open up some issues shortly

view this post on Zulip nikomatsakis (May 05 2021 at 15:10):

I also am making a project board to track this

view this post on Zulip nikomatsakis (May 05 2021 at 15:10):

https://github.com/rust-lang/lang-team/projects/4

view this post on Zulip nikomatsakis (May 05 2021 at 15:40):

So @Sladyn Nunes here is a first issue

view this post on Zulip nikomatsakis (May 05 2021 at 15:42):

I'm adding more into the project board 'ready to implement' column

view this post on Zulip nikomatsakis (May 05 2021 at 15:44):

you should be able to claim issues by writing @rustbot claim fyi, @Sladyn Nunes

view this post on Zulip nikomatsakis (May 05 2021 at 15:53):

besides myself, @Santiago Pastorino is probably able to help here with questions, btw

view this post on Zulip nikomatsakis (May 05 2021 at 15:53):

/me volunteers others

view this post on Zulip Sladyn Nunes (May 05 2021 at 18:41):

Great I am reading through it and ill get started

view this post on Zulip Santiago Pastorino (May 05 2021 at 18:43):

nikomatsakis said:

besides myself, Santiago Pastorino is probably able to help here with questions, btw

:+1:

view this post on Zulip Sladyn Nunes (May 06 2021 at 18:46):

Started some stuff, and commented

view this post on Zulip nikomatsakis (May 06 2021 at 19:30):

@Sladyn Nunes where did you comment :)

view this post on Zulip Sladyn Nunes (May 07 2021 at 13:41):

On the issue you created : )

view this post on Zulip Sladyn Nunes (May 07 2021 at 13:41):

Just created a vector and had some questions on the loop

view this post on Zulip nikomatsakis (May 21 2021 at 14:56):

@simulacrum I'd like to get r+ on triagebot to help move @Sladyn Nunes PRs faster-- thoughts?

view this post on Zulip nikomatsakis (May 21 2021 at 14:56):

(does triagebot use bors?)

view this post on Zulip simulacrum (May 21 2021 at 14:57):

oh, no it's just merging directly, happy to add you

view this post on Zulip simulacrum (May 21 2021 at 14:57):

done

view this post on Zulip nikomatsakis (May 21 2021 at 14:58):

thanks!


Last updated: Jan 26 2022 at 07:02 UTC